1. 13 Oct, 2017 2 commits
  2. 12 Oct, 2017 1 commit
    • Jan Lindström's avatar
      MDEV-11336: Enable defragmentation on 10.2 when tests pass · a4fa940b
      Jan Lindström authored
      Problem was that we could take page latches on different
      order than wat is entitled with SX-lock. To follow the
      latching order defined in WL#6326, acquire index->lock X-latch.
      This entitles us to acquire page latches in any order for the index.
      
      btr0btr.cc
      	Document latch rules before and after MariaDB 10.2.2
      
      sync0rw.cc
      	Document latch compatibility rules better.
      
      btr_defragment_merge_pages
      	Fix parameter value.
      
      btr_defragment_thread
      	Acquire X-lock to dict_index_t::lock before restoring
      	cursor position and continuing defragmentation.
      
      ha_innobase::optimize
      	Restore defragment feature.
      
      Testing
      	Add GIS-index and FT-index to table being defragmented.
      
      	Defragmentation is not done to GIS-indexes and FT auxiliary
      	tables.
      a4fa940b
  3. 11 Oct, 2017 12 commits
  4. 10 Oct, 2017 12 commits
    • Marko Mäkelä's avatar
      Reapply a MySQL 5.6.23/5.7.10 Oracle Bug#20029625 fix that was inadvertently... · 4de344a8
      Marko Mäkelä authored
      Reapply a MySQL 5.6.23/5.7.10 Oracle Bug#20029625 fix that was inadvertently reverted in MariaDB 10.2.2
      
      The fix https://github.com/mysql/mysql-server/commit/716f97e2714e70f35d2dc01f0125ed833c62b408
      was inadvertently reverted in
      commit 2e814d47
      "Merge InnoDB 5.7 from mysql-5.7.9".
      
      Reapply the fix, because the test of the bug would fail
      after merging MDEV-13838, which replaced an earlier incorrect
      bug fix with a correct one.
      4de344a8
    • Varun Gupta's avatar
      MDEV-13974: Build failure in rocksdb/rdb_datadic.cc · ac2ae901
      Varun Gupta authored
      Added cstdlib librabry to rdb_datadic.h
      ac2ae901
    • Jan Lindström's avatar
      Fix test failure on galera.view caused by incorrect location · f2a0fa86
      Jan Lindström authored
      of WSREP_TO_ISOLATION_BEGIN.
      f2a0fa86
    • Marko Mäkelä's avatar
      MDEV-13311 Presence of old logs in 10.2.7 will corrupt restored instance (change in behavior) · 1b478a7a
      Marko Mäkelä authored
      Mariabackup 10.2.7 would delete the redo log files after a successful
      --prepare operation. If the user is manually copying the prepared files
      instead of using the --copy-back option, it could happen that some old
      redo log file would be preserved in the restored location. These old
      redo log files could cause corruption of the restored data files when
      the server is started up.
      
      We prevent this scenario by creating a "poisoned" redo log file
      ib_logfile0 at the end of the --prepare step. The poisoning consists
      of simply truncating the file to an empty file. InnoDB will refuse
      to start up on an empty redo log file.
      
      copy_back(): Delete all redo log files in the target if the source
      file ib_logfile0 is empty. (Previously we did this if the source
      file is missing.)
      
      SRV_OPERATION_RESTORE_EXPORT: A new variant of SRV_OPERATION_RESTORE
      when the --export option is specified. In this mode, we will keep
      deleting all redo log files, instead of truncating the first one.
      
      delete_log_files(): Add a parameter for the first file to delete,
      to be passed as 0 or 1.
      
      innobase_start_or_create_for_mysql(): In mariabackup --prepare,
      tolerate an empty ib_logfile0 file. Otherwise, require the first
      redo log file to be longer than 4 blocks (2048 bytes). Unless
      --export was specified, truncate the first log file at the
      end of --prepare.
      1b478a7a
    • Vladislav Vaintroub's avatar
      dc93ce8d
    • Vladislav Vaintroub's avatar
      Windows : small optimization in os_is_sparse_file_supported() · fa7a1a57
      Vladislav Vaintroub authored
      Use GetFileInformationByHandleEx with FileAttributeTagInfo to query whether
      the file is sparse. This saves 1 syscall, as GetFileInformationByHandle()
      would additionally query volume info.
      fa7a1a57
    • Vladislav Vaintroub's avatar
      MDEV-13941 followup. · ff2d9e12
      Vladislav Vaintroub authored
      Try to fix fragmentation (unsparse files), for pre-existing
      installations.
      
      Unsparse the innodb file, when it needs to be extended, unless compression
      is used. For Win7/2008R2 unsparse  does not work (as documented in MSDN),
      therefore for sparse files in older Windows, file extension will be done
      via writing zeroes at the end of file.
      ff2d9e12
    • Vladislav Vaintroub's avatar
      MDEV-13822 mariabackup incremental prepare incorrectly sets file size. · fe18e6b0
      Vladislav Vaintroub authored
      MDEV-13310 Preparing an incremental backup twice can corrupt data
      fe18e6b0
    • Vladislav Vaintroub's avatar
      Innodb : Refactor os_file_set_size() to be compatible 10.1 · b731a5bc
      Vladislav Vaintroub authored
      The last parameter to this function is now,"bool is_sparse", like in 10.1
      rather than the  unused/useless "bool is_readonly", merged from MySQL 5.7
      
      Like in 10.1, this function now supports sparse files, and efficient
      platform specific mechanisms for file extension
      
      os_file_set_size() is now consistenly used in all places where
      innodb files are extended.
      b731a5bc
    • sjaakola's avatar
      MW-416 DDL replication moved after acl checking · 0b5a5258
      sjaakola authored
      galera_events test shows a regression with the original fix for MW-416
      Reason was that Events::drop_event() can be called also from inside event
      execution, and there we have a speacial treatment for event, which executes
      "DROP EVENT" statement, and runs TOI replication inside the event processing body.
      This resulted in executing WSREP_TO_ISOLATION two times for such DROP EVENT statement.
      Fix is to call WSREP_TO_ISOLATION_BEGIN only in Events::drop_event()
      0b5a5258
    • sjaakola's avatar
      MW-416 · 70c23321
      sjaakola authored
      Changed return code for replicatio error to TRUE.
      This is aligned with native mysql convention to return TRUE (defined to 1) or FALSE (defined to 0) from a bool function.
      This is wrong, but follows the mysql conventiosn, at least...
      70c23321
    • sjaakola's avatar
      MW-416 · 1841ef1c
      sjaakola authored
      Moved TOI replication to happen after ACL checking for commands:
      SQLCOM_CREATE_EVENT
      SQLCOM_ALTER_EVENT
      SQLCOM_DROP_EVENT
      SQLCOM_CREATE_VIEW
      SQLCOM_CREATE_TRIGGER
      SQLCOM_DROP_TRIGGER
      SQLCOM_INSTALL_PLUGIN
      SQLCOM_UNINSTALL_PLUGIN
      1841ef1c
  5. 09 Oct, 2017 5 commits
    • Marko Mäkelä's avatar
      MDEV-14023 10.1 InnoDB tables with virtual columns cannot be accessed in 10.2 · e1d9a237
      Marko Mäkelä authored
      MariaDB 10.1 introduced non-indexed virtual columns for InnoDB tables.
      When MySQL 5.7 introduced virtual columns in InnoDB tables, it also
      introduced the table SYS_VIRTUAL that stores metadata on virtual
      columns. This table does not initially exist in data files that were
      imported from 10.1. So, we do not always have virtual column metadata
      inside InnoDB.
      
      dict_index_contains_col_or_prefix(): In the clustered index records,
      all non-virtual columns are present and no virtual columns are present.
      
      ha_innobase::build_template(): In the clustered index, do not
      include virtual columns in the query template. The SQL layer is
      supposed to compute the virtual column values when needed.
      e1d9a237
    • Marko Mäkelä's avatar
      btr_free_root(): Relax a too strict debug assertion · 3edd007c
      Marko Mäkelä authored
      When btr_create() invokes btr_free_root() after running out of space,
      fseg_create() would have acquired an SX-latch on the root page, not
      an X-latch. Relax the debug assertion in btr_free_root() accordingly.
      
      (In this case, SX-latch and X-latch are equivalent. During the CREATE
      operation there should be MDL_EXCLUSIVE and dict_operation_lock X-latch
      preventing concurrent access to the index. Normally the purpose of the
      SX-latch is to allow concurrent reads of the root page while certain
      fields in the root page are updated in place.)
      3edd007c
    • Sergei Petrunia's avatar
    • Sergei Petrunia's avatar
      Fix rocksdb.perf_context test · f62f9d66
      Sergei Petrunia authored
      The part of the test that counts IO should be run with default
      rocksdb_flush_log_at_trx_commt.
      f62f9d66
    • Sergei Petrunia's avatar
      6ff8d571
  6. 07 Oct, 2017 8 commits