1. 13 Oct, 2005 4 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · f525b84c
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-12736
      
      
      sql/sql_select.cc:
        Auto merged
      f525b84c
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 62941621
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      62941621
    • unknown's avatar
      A fix and a test case for Bug#12736 "Server crash during a select". · 9dc7b8c0
      unknown authored
      The bug was in JOIN::join_free which was wrongly determining that
      all joins have been already executed and therefore all used tables
      can be closed.
      
      
      mysql-test/r/subselect_innodb.result:
        - test results fixed (Bug#12736 "Server crash during a select
      mysql-test/t/subselect_innodb.test:
        - a test case for Bug#12736 "Server crash during a select": test
        that ha_index_or_rnd_end and mysql_unlock_tables are called
        for all used tables in proper order.
      sql/item_subselect.cc:
        - implement subselect_union_engine::is_executed
      sql/item_subselect.h:
        - implement Item_subselect::is_evaluated. This function is used
        to check whether we can clean up a non-correlated join of a subquery
        when cleaning up the join of the outer query
      sql/sql_lex.h:
        - declare st_select_lex::cleanup_all_joins
      sql/sql_select.cc:
        - remove an argument from JOIN::join_free, it's now not used
        - reimplement JOIN::join_free to not unlock tables if there
          is a subquery that has not yet been evaluated. Make sure that the
          new implementation calls ha_index_or_rnd_end for every table in
          the join and inner joins, because all table cursors must be closed
          before mysql_unlock_tables.
      sql/sql_select.h:
        - JOIN::join_free signature changed
      sql/sql_union.cc:
        - implement a helper method st_select_lex::cleanup_all_joins, which
          recursively walks over a tree of joins and calls cleanup() for
          each join.
      9dc7b8c0
    • unknown's avatar
      BUG# 13052 · 6c23c383
      unknown authored
      Clean application of patch - 
      - Added --tz-utc to fix issue of dumping timestamp values between 
      servers with different global time zone settings, particularly 
      with regard to the day of DST changeover, which without this fix,
       would dump duplicate timestamp values.
      
      
      client/client_priv.h:
        BUG# 13052 - clean application of http://lists.mysql.com/internals/30993
      client/mysqldump.c:
        BUG# 13052
        
        Clean application of patch http://lists.mysql.com/internals/30993
        
        - added new --tz-utc option
        - added saving of TIME_ZONE in dump file
        - set TIME_ZONE to "+00:00" in dump
      mysql-test/r/mysqldump.result:
        BUG# 13052 New results
      mysql-test/t/mysqldump.test:
        BUG# 13052
        
        Added new test to test if the new option --tz-utc places 
        'SET TIME_ZONE="+00:00" at the top of the file and that this fixes 
        the problem of ending up with duplicate timestamp values that should
         be unique on eve of DST
      6c23c383
  2. 12 Oct, 2005 32 commits
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · a69ddb7d
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-mysqlbinlog-ulong
      
      a69ddb7d
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · 720dac8c
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      720dac8c
    • unknown's avatar
      fixes after merge of 4.1. · 2dca61c4
      unknown authored
      
      mysql-test/r/subselect.result:
        correcting non-ascii chars hosed by automerge as usual
      mysql-test/t/subselect.test:
        correcting non-ascii chars hosed by automerge as usual
      sql/log_event.cc:
        correcting bad manual merge. ZERO_LEN is not needed in 5.0, as ::exec_event() just tell()s the relay log instead
        of using get_event_len().
      sql/log_event.h:
        get_event_len() is not needed in 5.0, ZERO_LEN neither.
      sql/slave.cc:
        fixes to take into account 5.0 specificities in replication. ZERO_LEN is not needed.
      2dca61c4
    • unknown's avatar
      Building with compile-pentium-valgrind-max (without safemalloc) defines my_free() without flags, · a3775d0f
      unknown authored
      so a typo on flags will go unnoticed; I put flags in this my_free() definition (as a no-op which
      will still make the compiler check correctness of the flags). Applied: this caught a typo in my_realloc.c. Kindly approved by Konstantin and Mats.
      
      
      include/my_sys.h:
        When we define my_free(PTR,FG) to be my_no_flags_free(PTR) we don't make the compiler check
        correctness of FG, which can hurt if another person build with a different definition of my_free;
        so I add FG in the expression.
      mysys/my_realloc.c:
        typo found by the change in my_sys.h :)
      a3775d0f
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · 36e10a4b
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-mysqlbinlog-ulong
      
      36e10a4b
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0 · 420c63da
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      420c63da
    • unknown's avatar
      replace port number with string identifier so that it may have different ports and still run · ad169fa7
      unknown authored
      (problem found by kent)
      
      
      mysql-test/r/federated.result:
        replace port number with a named identifier
      mysql-test/t/federated.test:
        add call to replace the resulting display of the port number with a string
      ad169fa7
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1 · 836a13aa
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0
      
      836a13aa
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 1df4d5ef
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-repl
      
      1df4d5ef
    • unknown's avatar
      make_binary_distribution.sh: · 0062a910
      unknown authored
        Copy *.cnf files in mysql-test/std_data/
      Makefile.am:
        Added std_data/*.cnf to copy ndb config
      
      
      mysql-test/Makefile.am:
        Added std_data/*.cnf to copy ndb config
      scripts/make_binary_distribution.sh:
        Copy *.cnf files in mysql-test/std_data/
      0062a910
    • unknown's avatar
      To force a restart at the end of test, the option file must be non-empty, it's... · 1d48b472
      unknown authored
      To force a restart at the end of test, the option file must be non-empty, it's not enough if it exists and is empty.
      
      
      mysql-test/t/rpl_dual_pos_advance-master.opt:
        the option file must be non-empty (because there's a -z test in mysql-test-run)
      1d48b472
    • unknown's avatar
      Merge mysql.com:/home/mysql_src/mysql-4.1 · 34046c98
      unknown authored
      into  mysql.com:/home/mysql_src/mysql-5.0;
      a very bad automerge (issues with non-ascii chars), plus some hard conflicts I'll fix by hand in a next cset
      
      
      BitKeeper/deleted/.del-compile-pentium64-valgrind-max:
        Delete: BUILD/compile-pentium64-valgrind-max
      BitKeeper/etc/config:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      client/mysqltest.c:
        manual merge
      mysql-test/r/subselect.result:
        manual merge
      mysql-test/t/subselect.test:
        manual merge
      sql/log_event.cc:
        manual merge
      sql/log_event.h:
        manual merge
      sql/slave.cc:
        manual merge
      sql/sql_yacc.yy:
        manual merge
      34046c98
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 063f50af
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-repl
      
      
      sql/sp_head.cc:
        Auto merged
      063f50af
    • unknown's avatar
      Temporary solution for bug #13969 "Routines which are replicated from master · f5d5a1c9
      unknown authored
      can't be executed on slave". It will be possible to solve this problem
      in more correct way when we will implement WL#2897 "Complete definer support
      in the stored routines".
      
      
      mysql-test/r/rpl_sp.result:
        Added test for bug #13969 "Routines which are replicated from master can't be
        executed on slave".
      mysql-test/t/rpl_sp.test:
        Added test for bug #13969 "Routines which are replicated from master can't be
        executed on slave".
      sql/sp_head.cc:
        sp_change_security_context():
          Currently the slave replication thread creates all stored routines with
          definer ''@'', ignoring the actual definer. When the slave replication
          thread executes these routines, it ignores the definer, and so the routines
          work. However, in case of a failover, the replica operates in a normal mysqld
          mode and changes security context to the definer when executing a routine.
          A proper fix for this issue is described in WL#2897 "Complete definer support
          in the stored routines". Until this WL is implemented, we need this temporary
          fix, which ignores errors when changing security context.
      f5d5a1c9
    • unknown's avatar
      slave.cc: · 2ccdbbb1
      unknown authored
        SCCS merged
      
      
      sql/slave.cc:
        SCCS merged
      2ccdbbb1
    • unknown's avatar
      Fix of incompatible types · 853077f3
      unknown authored
      len and packet_error needs to be of same type for (len == packet_error) to
      check failures
      
      853077f3
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · c034088a
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      
      ndb/src/mgmsrv/InitConfigFileParser.cpp:
        Auto merged
      c034088a
    • unknown's avatar
      postt review fixes · c4d896be
      unknown authored
      c4d896be
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · d4f64e84
      unknown authored
      into  mysql.com:/usr/home/pem/bug13510/mysql-5.0
      
      d4f64e84
    • unknown's avatar
      c0215705
    • unknown's avatar
      Bug #13009 No gaps allowed in node id number sequence · 1bfce2a6
      unknown authored
      + some small bugfixes in ndb_config
      + extending ndb_config to print connections and take shm option
      
      1bfce2a6
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 58e704e3
      unknown authored
      into  mysql.com:/usr/home/pem/bug13510/mysql-5.0
      
      58e704e3
    • unknown's avatar
      merge · 516c558c
      unknown authored
      516c558c
    • unknown's avatar
      Fix for BUG#13023: "SQL Thread is up but doesn't move forward". Details in slave.cc; · d536481f
      unknown authored
      in short we now record whenever the slave I/O thread ignores a master's event because of its server id,
      and use this info in the slave SQL thread to advance Exec_master_log_pos. Because if we
      do not, this variable stays at the position of the last executed event, i.e. the last *non-ignored*
      executed one, which may not be the last of the master's binlog (and so the slave *looks* behind
      the master though it's data-wise it's not).
      
      
      mysql-test/t/rpl_dual_pos_advance-master.opt:
        empty; its goal is just to trigger a server restart after running the test,
        so that the master forgets that it was a slave (otherwise it affects the following tests).
      sql/log.cc:
        No more default arguments for Rotate_log_event constructor.
        MYSQL_LOG::appendv() is now called without mutex.
      sql/log_event.cc:
        Moving one Rotate_log_event constructor from log_event.h. Support for on-demand choice of
        duplicating the string argument of the constructor or not (because there now are needs for both
        alternatives, see slave.cc).
      sql/log_event.h:
        We now have a case where a Rotate_log_event is executed by the slave SQL thread while
        not being in the relay log, so it needs to pretend its length is 0: a ZERO_LEN flag for that;
        a flag DUP_NAME (replaces "bool alloced") to be able to choose if we want the constructor
        to duplicate the string argument or not.
      sql/slave.cc:
        A comment for BUG#13861 (to be fixed). llstr() instead of %ld as the number is ulonglong.
        mi->rli becomes rli in some places.
        Fix for BUG#13023:
        - in the slave I/O thread, whenever we ignore an event because of its server id we update
        a couple of coordinates in memory
        - in the slave SQL thread, whenever we bump into the end of the latest relay log, we check
        this couple of coordinates to see if we should advance our Exec_master_log_pos.
        - when the slave I/O thread terminates it saves these in-memory coordinates into a Rotate event
        in the relay log, so that they are durable.
      sql/slave.h:
        A couple of coordinates in RELAY_LOG_INFO to keep track of the last ignored events received
        by the slave I/O thread (ignored because of the server id).
      mysql-test/r/rpl_dual_pos_advance.result:
        New BitKeeper file ``mysql-test/r/rpl_dual_pos_advance.result''
      mysql-test/t/rpl_dual_pos_advance.test:
        Test for BUG#13023 (with a part, disabled, to test BUG#13861 when I fix it).
        Before the fix, this test used to hang.
      d536481f
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 75854e3a
      unknown authored
      into  mysql.com:/usr/home/pem/bug13616/mysql-5.0
      
      
      sql/sp_head.cc:
        Auto merged
      75854e3a
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 7bea53e6
      unknown authored
      into  mysql.com:/usr/home/pem/bug13616/mysql-5.0
      
      7bea53e6
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 06e5fd5d
      unknown authored
      into mysql.com:/home/gluh/MySQL/Merge/5.0
      
      06e5fd5d
    • unknown's avatar
      after merge fix · 6223fcd8
      unknown authored
      
      config/ac-macros/yassl.m4:
        added HAVE_YASSL variable
      sql/mysqld.cc:
        added HAVE_YASSL define
      6223fcd8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 9c405eb5
      unknown authored
      into  mysql.com:/users/grog/4.1
      
      9c405eb5
    • unknown's avatar
      sql_yacc.yy: · 652c68e5
      unknown authored
        Bug #10308: Parse 'purge master logs' with subselect correctly.
      subselect.test:
        Bug #10308: Test for 'purge master logs' with subselect.
      subselect.result:
        Bug #10308: Test result for 'purge master logs' with subselect.
      
      
      mysql-test/r/subselect.result:
        Bug #10308: Test result for 'purge master logs' with subselect.
      mysql-test/t/subselect.test:
        Bug #10308: Test for 'purge master logs' with subselect.
      sql/sql_yacc.yy:
        Bug #10308: Parse 'purge master logs' with subselect correctly.
      652c68e5
    • unknown's avatar
      Merge lgrimmer@bk-internal:/home/bk/mysql-5.0 · be3aed8a
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      be3aed8a
    • unknown's avatar
      4.1->5.0 merge · b6d1d52f
      unknown authored
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        manual merge
      b6d1d52f
  3. 11 Oct, 2005 4 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 562163e4
      unknown authored
      into  mysql.com:/home/my/mysql-5.0
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      server-tools/instance-manager/instance.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_manager.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/unireg.cc:
        Auto merged
      562163e4
    • unknown's avatar
      Reviewing new pushed code · d6ccd7c7
      unknown authored
      - CHAR() now returns binary string as default
      - CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
      - Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        (Some old systems returns ETIME and it's safer to test for both values
         than to try to write a wrapper for each old system)
      - Fixed new introduced bug in NOT BETWEEN X and X
      - Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      - Use octet2hex() for all conversion of string to hex
      - Simplify and optimize code
      
      
      client/mysqldump.c:
        Simple optimizations of new code
        Indentation fixes
      client/mysqltest.c:
        Removed not needed variable
      include/mysql_com.h:
        Made octec2hex() more usable
      mysql-test/r/ctype_utf8.result:
        CHAR() now returns binary string as default
      mysql-test/r/func_str.result:
        CHAR() now returns binary string as default
      mysql-test/r/range.result:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/r/user_var-binlog.result:
        CHAR() now returns binary string as default
      mysql-test/r/view.result:
        More tests of view rename
      mysql-test/t/ctype_utf8.test:
        CHAR() now returns binary string as default
      mysql-test/t/func_str.test:
        CHAR() now returns binary string as default
      mysql-test/t/range.test:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/t/view.test:
        More tests of view rename
      mysys/mf_keycache.c:
        Indentation changes
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/my_os2cond.c:
        Fix to MySQL coding style
        Optimized functions
      mysys/thr_lock.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/thr_mutex.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/instance.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/thread_registry.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/ha_federated.cc:
        Use octet2hex()
      sql/ha_ndbcluster.cc:
        Removed not used variable
      sql/handler.cc:
        Simplify code
        Use *NONE* instead of 'none' for not existing storage engine
        Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      sql/item.h:
        Remove not needed test for *ref.  (If ref is set, it should never point at 0)
      sql/item_func.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        Simplify code
        More comments
        Require that last argument to find_and_check_access() is given
        (Made code shorter and faster)
      sql/item_strfunc.cc:
        Changed CHAR() to return result in binary collation
        CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
        
        Bar will shortly add the following syntax:
        CHAR(.... USING character_set)
        and ensure that
        CONVERT(CHAR(....) USING utf8) cuts not legal utf8 strings
        Use ocet2hex()
      sql/item_strfunc.h:
        CHAR() now returns a binary string
      sql/log_event.cc:
        Use octet2hex()
        Simplify code
      sql/parse_file.cc:
        Indentation fixes
        Use for() instead of while()
      sql/password.c:
        Make octet2hex() more generally usable by returning pointer to end 0
      sql/slave.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_base.cc:
        Indentation fixes
      sql/sql_insert.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_manager.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_parse.cc:
        Don't check thd->db when checking for function privileges
      sql/sql_prepare.cc:
        Fixed wrong merge
      sql/sql_select.cc:
        Fixed new bug for NOT BETWEEN X and X
      sql/sql_show.cc:
        Removed not used variable
      sql/sql_table.cc:
        Indentation fixed
        Removed DBUG_PRINT that is obvious from context
      sql/sql_view.cc:
        Simplify code
      sql/unireg.cc:
        Use octet2hex()
      d6ccd7c7
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1 · cff6c194
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      cff6c194
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 122b48fd
      unknown authored
      into moonbone.local:/work/13327-bug-5.0-mysql
      
      122b48fd