1. 29 Jun, 2007 1 commit
  2. 27 Jun, 2007 1 commit
    • unknown's avatar
      BUG#29207 - archive table reported as corrupt by check table (P1) · 09992cba
      unknown authored
      CHECK TABLE against ARCHIVE table may falsely report table corruption,
      or cause server crash.
      
      Fixed by using proper buffer for CHECK TABLE.
      
      Affects both 5.0 and 5.1.
      
      
      mysql-test/r/archive.result:
        A test case for BUG#28916.
      mysql-test/t/archive.test:
        A test case for BUG#28916.
      sql/ha_archive.cc:
        We call Field::get_length() from get_row(). Field::get_length() assumes
        that the row was read into table->record[0] buffer, which is not the
        case when we check a table. As a result we get wrongly initialized
        blob length.
        
        Use table->record[0] as record buffer for check table instead.
      09992cba
  3. 24 Jun, 2007 3 commits
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-amain · 0e2cae5a
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      0e2cae5a
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-ateam · 8d8c66a1
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-axmrg
      
      8d8c66a1
    • unknown's avatar
      BUG#15787 - MySQL crashes when archive table exceeds 2GB · 0f01d4a9
      unknown authored
      Max compressed file size was calculated incorretly causing server
      crash on INSERT.
      
      With this patch we use proper max file size provided by zlib.
      
      Affects 5.0 only.
      
      
      sql/ha_archive.cc:
        When calculating max compressed file size, use the real offset size
        that is provided by zlib, instead of sizeof(z_off_t), which may be
        different from actual offset size.
        
        When we're about to write and the data file is almost full flush gzio
        buffer to get accurate real file size.
      mysql-test/r/archive-big.result:
        New BitKeeper file ``mysql-test/r/archive-big.result''
      mysql-test/t/archive-big.test:
        New BitKeeper file ``mysql-test/t/archive-big.test''
      0f01d4a9
  4. 22 Jun, 2007 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 3300b8eb
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      3300b8eb
    • unknown's avatar
      Bug #29138 'kill' fails in pushbuild · 86ae7940
      unknown authored
      The reason the "reap;" succeeds unexpectedly is because the query was completing(almost always) and the network buffer was big enough to store the query result (sometimes) on Windows, meaning the response was completely sent before the server thread could be killed.
      
      Therefore we use a much longer running query that doesn't have a chance to fully complete before the reap happens, testing the kill properly.
      
      
      mysql-test/r/kill.result:
        We use a much longer running query that doesn't have a chance to fully complete before the reap happens.
      mysql-test/t/kill.test:
        We use a much longer running query that doesn't have a chance to fully complete before the reap happens.
      86ae7940
  5. 21 Jun, 2007 12 commits
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 839c07db
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      839c07db
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 6367bd2a
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge
      6367bd2a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-rpl · 42247162
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      42247162
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · d3662296
      unknown authored
      into  amd64.(none):/src/bug27029/my50-bug27029
      
      
      myisam/sort.c:
        Auto merged
      d3662296
    • unknown's avatar
      Bug#27029 alter table ... enable keys crashes mysqld on large table · 8d27f335
      unknown authored
      - When creating an index for the sort, the number of rows plus 1 is used 
      to allocate a buffer.  In this test case, the number of rows 4294967295 
      is the max value of an unsigned integer, so when 1 was added to it, a 
      buffer of size 0 was allocated causing the crash.
      - Create new test suite for this bug's test suite as per QA.
      
      
      myisam/sort.c:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - Check to make sure the value of records is < UINT_MAX32 to avoid a 
        false positive on the remaining condition.
      mysql-test/suite/large_tests/README.TXT:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added mtr hint for potential testers.
      mysql-test/suite/large_tests/r/alter_table.result:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added results for bug.
      mysql-test/suite/large_tests/t/alter_table.test:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added test for bug.
      8d27f335
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 6c70aa11
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      6c70aa11
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bk/mysql-5.0 · 9dfd4335
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bk/mysql-5.0-rpl
      
      9dfd4335
    • unknown's avatar
      Test fix · aacbe21c
      unknown authored
      aacbe21c
    • unknown's avatar
      66e76447
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28769/my50-bug28769 · 863e3da3
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      863e3da3
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28742/my50-bug28742 · bd099cd8
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      bd099cd8
    • unknown's avatar
      Bug#24924: shared-memory-base-name that is too long causes buffer overflow · 26e9aba4
      unknown authored
      long shared-memory-base-names could overflow a static internal buffer
      and thus crash mysqld and various clients.  change both to dynamic
      buffers, show everything but overflowing those buffers still works.
      
      The test case for this would pretty much amount to
      mysqld --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX --shared-memory=1 &
      mysqladmin --no-defaults --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX shutdown
      
      Unfortunately, we can't just use an .opt file for the
      server. The .opt file is used at start-up, before any
      include in the actual test can tell mysqltest to skip
      this one on non-Windows. As a result, such a test would
      break on unices.
      
      Fixing mysql-test-run.pl to export full path for master
      and slave would enable us to start a server from within
      the test which is ugly and, what's more, doesn't work as
      the server blocks (mysqltest offers no fire-and-forget
      fork-and-exec), and mysqladmin never gets run.
      
      Making the test rpl_windows_shm or some such so we can
      is beyond ugly. As is introducing another file-name based
      special case (run "win*.test" only when on Windows). As is
      (yuck) coding half the test into mtr (as in, having it
      hand out a customized environment conductive to the shm-
      thing on Win only).
      
      Situation is exacerbated by the fact that .sh is not
      necessary run as expected on Win.
      
      In short, it's just not worth it. No test-case until we
      have a new-and-improved test framework.
      
      
      sql-common/client.c:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (clients)
      sql/mysqld.cc:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (server)
      26e9aba4
  6. 20 Jun, 2007 4 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.0-rpl · 0f3bc4cd
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b29030-mysql-5.0-rpl
      
      0f3bc4cd
    • unknown's avatar
      BUG#29030 (DROP USER command that errors still gets written to binary log · 15375044
      unknown authored
      and replicated):
      
      A DROP USER statement with a non-existing user was correctly written to
      the binary log (there might be users that were removed, but not all),
      but the error code was not set, which caused the slave to stop with an
      error.
      
      The error reporting code was moved to before the statement was logged
      to ensure that the error information for the thread was correctly set
      up. This works since my_error() will set the fields net.last_errno and
      net.last_error for the thread that is reporting the error, and this
      will then be picked up when the Query_log_event is created and written
      to the binary log.
      
      
      sql/sql_acl.cc:
        Moving error reporting code to ensure that thd->net.last_err{or,no} is
        set and adding debug printout.
      mysql-test/r/rpl_grant.result:
        New BitKeeper file ``mysql-test/r/rpl_grant.result''
      mysql-test/t/rpl_grant.test:
        New BitKeeper file ``mysql-test/t/rpl_grant.test''
      15375044
    • unknown's avatar
      Bug #27583 slave sql fails to read from iocache when slave got stopped at pos==4 · 1b42af2c
      unknown authored
      forgotten merge with 5.0. There can be some bugs waiting for this fix in 5.0 like Bug@29232
      
      
      sql/log_event.cc:
        file name is changed in step with the position.
      1b42af2c
    • unknown's avatar
      Bug#28742 mysql-test-run is very slow on "Stopping All Servers" step · 8c1c0ed1
      unknown authored
       - Improve shutdown algorithm 
       - Wait up to 5 seconds for processes to exit after their port is free
      
      
      mysql-test/lib/mtr_process.pl:
        Improve shutdown algorithm, shutdown the server hard
        if it hasn't responded to "mysqladmin shutdown" and it's port is free.
        Print error to servers error log indicating "hard shutdown"
        Give processes up to 5 seconds to exit after their port is free
      mysql-test/lib/mtr_report.pl:
        Indicate in what file the warning was found
      mysql-test/mysql-test-run.pl:
        Pass path of process error log to 'mtr_check_stop_servers'
      8c1c0ed1
  7. 19 Jun, 2007 9 commits
  8. 18 Jun, 2007 8 commits
    • unknown's avatar
      Bug #28921 Queries containing UDF functions are cached · 624d2d3d
      unknown authored
      Fixed runtime to no longer allow the caching of queries with UDF calls.
      
      
      mysql-test/r/udf.result:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      mysql-test/t/udf.test:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      sql/sql_yacc.yy:
        Fixed code to set safe_to_cache_query=0 regardless if the function call is a UDF or SP. Where it was placed previously -- at the very end of the else testing for UDFs -- it only executed the statement if the function call was a stored procedure call.
      624d2d3d
    • unknown's avatar
      Bug #29053 SQL_CACHE in UNION causes non-deterministic functions to be cached · f89957c7
      unknown authored
      Changed code to enforce that SQL_CACHE only in the first SELECT is used to turn on caching(as documented), but any SQL_NO_CACHE will turn off caching (not documented, but a useful behaviour, especially for machine generated queries). Added test cases to explicitly test the documented caching behaviour and test cases for the reported bug. 
      
      
      mysql-test/r/query_cache.result:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      mysql-test/t/query_cache.test:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      sql/sql_yacc.yy:
        Added an explicit check to make sure "SELECT SQL_CACHE" only works on the first select in a query.
        
        The parser will always hit the outermost SELECT first, and if the SQL_CACHE option is found it sets the safe_to_query flag in the lex. Then, if there are subseqent "uncachable" subqueries or functions, as it parses those elements it sets the safe_to_query to 0. However, this cause problems if nested SELECTs also used the SQL_CACHE option, because then it would set back safe_to_query to 1, even though there are uncacheable expressions previously parsed.
        
        By adding the check to ensure only the first SELECT can turn caching on, it means a subsequent SQL_CACHE option can't turn caching back on after a uncacheable subsequery was already encountered.
      f89957c7
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 60f23378
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      60f23378
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 88c218b3
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      88c218b3
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/41 · 3d46e759
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      
      configure.in:
        Auto merged
      3d46e759
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge · 69f01d70
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      69f01d70
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl · ca9b245b
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      ca9b245b
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-4.1-rpl · 1b98baef
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge
      
      1b98baef