1. 30 May, 2022 1 commit
  2. 27 May, 2022 1 commit
  3. 26 May, 2022 1 commit
    • Ting Nian's avatar
      Add option --enable-cleartext-plugin to the MariaDB client · 31e30329
      Ting Nian authored
      For compatibility reasons, add the option to the MariaDB client without
      any functional changes besides simply accepting the option and emitting
      a warning that it is obsolete.
      
      In MySQL this security related option is compulsory in certain use
      cases. When users switch to MariaDB, this client command that used to
      work starts failing without a sensible error message. In worst case
      users resort to re-installing the mysql client from MySQL.
      
      In MariaDB the option is obsolete and should simply be ignored. Users
      however don't have any opportunity to learn that unless the client
      program tells them so.
      
      Before:
      
          mysql --enable-cleartext-plugin ...
          mysql: unknown option '--enable-cleartext-plugin'
      
          (program terminates)
      
      After:
      
          mysql --enable-cleartext-plugin ...
          WARNING: option '--enable-cleartext-plugin' is obsolete.
      
          (program executes)
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer Amazon Web
      Services, Inc.
      31e30329
  4. 25 May, 2022 2 commits
  5. 23 May, 2022 1 commit
  6. 20 May, 2022 2 commits
  7. 19 May, 2022 1 commit
    • Oleg Smirnov's avatar
      MDEV-28246 Optimizer uses all partitions after upgrade to 10.3 · 40d9dbb2
      Oleg Smirnov authored
      Cause: a copy of the joined TABLE_LIST is created during multi_update::prepare
      and TABLE::pos_in_table_list of the tables are set to point to the new
      TABLE_LIST object. This prevents some optimization steps to perform correctly.
      Solution: do not update pos_in_table_list during multi_update::prepare
      40d9dbb2
  8. 18 May, 2022 1 commit
    • KiyoshiTakeda's avatar
      MDEV-14642 Assertion 'table->s->db_create_options ==... · 8881c010
      KiyoshiTakeda authored
      MDEV-14642 Assertion 'table->s->db_create_options == part_table->s->db_create_options' failed in compare_table_with_partition
      
      When trying to execute ALTER TABLE EXCHANGE PARTITION with different
      definitions, assertion
      
          table->s->db_create_options == part_table->s->db_create_options
      
      failed in compare_table_with_partition().
      
      However, this execution should not be allowed since executing
      'exchange partition' requires the identical structure of the two tables.
      
      To fix the problem, I deleted the assertion code and added code that
      returns an error that indicates tables have different definitions.
      
      Reviewed By: Nayuta Yanagisawa
      8881c010
  9. 17 May, 2022 8 commits
  10. 16 May, 2022 2 commits
  11. 15 May, 2022 1 commit
    • Sergei Petrunia's avatar
      Code cleanup in/around check_interleaving_with_nj() · 730eb1c4
      Sergei Petrunia authored
      - In best_extension_by_limited_search(), do not check for
        "(remaining_tables & real_table_bit)", it is guaranteed to be true.
        Make it an assert.
      - In (!idx || check_interleaving_with_nj())", remove the !idx part.
        This check made sense only in the original version of this function.
      - "micro optimization" in check_interleaving_with_nj().
      730eb1c4
  12. 13 May, 2022 3 commits
  13. 12 May, 2022 1 commit
  14. 09 May, 2022 1 commit
  15. 08 May, 2022 1 commit
  16. 07 May, 2022 2 commits
  17. 06 May, 2022 7 commits
    • Daniel Black's avatar
      MDEV-27816: Set sql_mode before DROP IF EXISTS already (postfix) · 0db27eff
      Daniel Black authored
      Test compat/oracle.sp-package-mysqldump needed re-record.
      0db27eff
    • Andrei's avatar
      MDEV-28310 Missing binlog data for INSERT .. ON DUPLICATE KEY UPDATE · a5dc12ee
      Andrei authored
      MDEV-21810 MBR: Unexpected "Unsafe statement" warning for unsafe IODKU
      
      MDEV-17614 fixes to replication unsafety for INSERT ON DUP KEY UPDATE
      on two or more unique key table left a flaw. The fixes checked the
      safety condition per each inserted record with the idea to catch a user-created
      value to an autoincrement column and when that succeeds the autoincrement column
      would become the source of unsafety too.
      It was not expected that after a duplicate error the next record's
      write_set may become different and the unsafe decision for that
      specific record will be computed to screw the Query's binlogging
      state and when @@binlog_format is MIXED nothing gets bin-logged.
      
      This case has been already fixed in 10.5.2 by 91ab42a8 that
      relocated/optimized THD::decide_logging_format_low() out of the record insert
      loop. The safety decision is computed once and at the right time.
      Pertinent parts of the commit are cherry-picked.
      
      Also a spurious warning about unsafety is removed when MIXED
      @@binlog_format; original MDEV-17614 test result corrected.
      The original test of MDEV-17614 is extended and made more readable.
      a5dc12ee
    • Daniel Black's avatar
      MDEV-4875 Can't restore a mysqldump if --add-drop-database meets general_log · 221ced92
      Daniel Black authored
      or slow query log when the log_output=TABLE.
      
      When this happens, we temporary disable by changing log_output until
      we've created the general_log and slow_log tables again.
      
      Move </database> in xml mode until after the transaction_registry.
      
      General_log and slow_log tables where moved to be first to be dumped so
      that the disabling of the general/slow queries is minimal.
      221ced92
    • Hartmut Holzgraefe's avatar
      MDEV-27816 Set sql_mode before DROP IF EXISTS already · 9fe3bc2a
      Hartmut Holzgraefe authored
      Previously the correct SQL mode for a stored routine or
      package was only set before doing the CREATE part, this
      worked out for PROCEDUREs and FUNCTIONs, but with ORACLE
      mode specific PACKAGEs the DROP also only works in ORACLE
      mode.
      
      Moving the setting of the sql_mode a few lines up to happen
      right before the DROP statement is writen fixes this.
      9fe3bc2a
    • Oleksandr Byelkin's avatar
      MDEV-28402 ASAN heap-use-after-free in create_tmp_table, Assertion `l_offset... · 141ab971
      Oleksandr Byelkin authored
      MDEV-28402 ASAN heap-use-after-free in create_tmp_table, Assertion `l_offset >= 0 && table->s->rec_buff_length - l_offset > 0'
      
      Make default() function follow Item_field and use get_tmp_table_item() for
      change_to_use_tmp_fields().
      141ab971
    • Sergei Petrunia's avatar
      624cb973
    • Marko Mäkelä's avatar
      MDEV-28478: INSERT into SPATIAL INDEX in TEMPORARY table writes log · 20ae4816
      Marko Mäkelä authored
      row_ins_sec_index_entry_low(): If a separate mini-transaction is
      needed to adjust the minimum bounding rectangle (MBR) in the parent
      page, we must disable redo logging if the table is a temporary table.
      For temporary tables, no log is supposed to be written, because
      the temporary tablespace will be reinitialized on server restart.
      
      rtr_update_mbr_field(): Plug a memory leak.
      20ae4816
  18. 05 May, 2022 4 commits
    • Sergei Petrunia's avatar
      MDEV-28437: Assertion `!eliminated' failed: Part #2 · 84e32eff
      Sergei Petrunia authored
      In SELECT_LEX::update_used_tables(),
      do not run the loop setting tl->table->maybe_null
      when tl is an eliminated table
      
      (Rationale: First, with current table elimination, tl already
       has maybe_null=1. Second, one should not care what flags
       eliminated tables had)
      84e32eff
    • Sergei Petrunia's avatar
      MDEV-28437: Assertion `!eliminated' failed in Item_subselect::exec · 8dbfaa2a
      Sergei Petrunia authored
      (This is the assert that was added in fix for MDEV-26047)
      
      Table elimination may remove an ON expression from an outer join.
      However SELECT_LEX::update_used_tables() will still call
      
        item->walk(&Item::eval_not_null_tables)
      
      for eliminated expressions. If the subquery is constant and cheap
      Item_cond_and will attempt to evaluate it, which will trigger an
      assert.
      The fix is not to call update_used_tables() or eval_not_null_tables()
      for ON expressions that were eliminated.
      8dbfaa2a
    • Tuukka Pasanen's avatar
      MDEV-28388: As Travis is not used anymore remove configurations files · 06562b84
      Tuukka Pasanen authored
      As Travis is not used anymore for CI is not wise to keep untested CI files laying around
      that someone can base their effort to update un-used files.
      06562b84
    • Tuukka Pasanen's avatar
      MDEV-12275: Add switch '--silent' to SySV init upgrade · db47855e
      Tuukka Pasanen authored
      Debian script debian-start upgrades database (which can be huge)
      and prints lots of unnecessary information (not errors). Add
      '--silent' to only sport possible errors
      db47855e