1. 27 Mar, 2008 8 commits
  2. 26 Mar, 2008 6 commits
    • unknown's avatar
      Merge host.loc:/home/uchum/work/5.0-opt-35193 · e7efc8b9
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      e7efc8b9
    • unknown's avatar
      Fixed bug #35193. · b6bf896b
      unknown authored
      View definition as SELECT ... FROM DUAL WHERE ... has
      valid syntax, but use of such view in SELECT or
      SHOW CREATE VIEW syntax causes unexpected syntax error.
      
      Server omits FROM DUAL clause when storing view body
      string in a .frm file for further evaluation.
      However, syntax of SELECT-witout-FROM query is more
      restrictive than SELECT FROM DUAL syntax, and doesn't
      allow the WHERE clause.
      
      NOTE: this syntax difference is not documented.
      
      
      View registration procedure has been modified to
      preserve original structure of view's body.
      
      
      
      mysql-test/r/view.result:
        Added test case for bug #35193.
      mysql-test/t/view.test:
        Added test case for bug #35193.
      sql/sql_select.cc:
        Fixed bug #35193.
        The st_select_lex::print function always omits FROM DUAL clause,
        even if original SELECT query has the WHERE clause.
        
        The mysql_register_view function uses this function to reconstruct
        a body of view's AS clause for further evaluation and stores that
        reconstructed clause in a .frm file.
        
        SELECT without FROM syntax is more restrictive than 
        SELECT FROM DUAL syntax: second one allows
        the WHERE clause, but first one is not.
        
        Use of this view in SELECT or SHOW CREATE VIEW queries
        causes unexpected syntax errors.
        
        
        The st_select_lex::print function has been modified to
        reconstruct FROM DUAL clause in queries when needed.
        
        
        TODO: Syntax difference is not documented and should be
        eliminated, however improvement of
        the SELECT-without-FROM syntax is not trivial and leads to
        significant modification of grammar file because of additional
        shift/reduce conflicts.
      b6bf896b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-build · 13c3814f
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-build
      
      13c3814f
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 20cf640c
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      20cf640c
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 768d675a
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      768d675a
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 8f24dc76
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_cp932.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/slave.cc:
        Auto merged
      8f24dc76
  3. 25 Mar, 2008 5 commits
    • unknown's avatar
      Bug#20906 (Multiple assignments in SET in stored routine produce incorrect · 88c29180
      unknown authored
      instructions)
      
      This bug can not be reproduced in the current version,
      adding the test case to the test suite for coverage, no code change.
      
      
      mysql-test/r/sp-code.result:
        Bug#20906 (Multiple assignments in SET in stored routine produce incorrect
        instructions)
      mysql-test/t/sp-code.test:
        Bug#20906 (Multiple assignments in SET in stored routine produce incorrect
        instructions)
      88c29180
    • unknown's avatar
      information_schema.test, information_schema.result: · a9b04d58
      unknown authored
        Minor test case cleanup after bug#34529.
      
      
      mysql-test/r/information_schema.result:
        Minor test case cleanup after bug#34529.
      mysql-test/t/information_schema.test:
        Minor test case cleanup after bug#34529.
      a9b04d58
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 49c6e9b6
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      49c6e9b6
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0 · 04cf5127
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt-merged
      
      
      sql/sql_delete.cc:
        Auto merged
      04cf5127
    • unknown's avatar
      BUG#35509 - Federated leaks memory when connecting to · 62c8302b
      unknown authored
                  localhost/default port
      
      When creating federated table that points to unspecified host or
      localhost on unspecified port or port is 0, small memory leak occurs.
      
      This happens because we make a copy of unix socket path, which is
      never freed.
      
      With this fix we do not make a copy of unix socket path, instead
      share->socket points to MYSQL_UNIX_ADDR constant directly.
      
      This fix is covered by a test case for BUG34788.
      
      Affects 5.0 only.
      
      
      mysql-test/t/federated.test:
        A test case for BUG#35509.
      sql/ha_federated.cc:
        When creating federated table we call parse_url() to check if connect
        string is correct. parse_url() may make a copy of unix socket path if
        port is not specified or 0 and host is not specified or 'localhost'.
        This copy is never freed.
        
        As there is no need to make a copy of unix socket path, let
        share->socket point to MYSQL_UNIX_ADDR directly.
      62c8302b
  4. 24 Mar, 2008 1 commit
  5. 23 Mar, 2008 1 commit
  6. 22 Mar, 2008 2 commits
  7. 21 Mar, 2008 2 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d4efe068
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26461-5.0-opt
      
      d4efe068
    • unknown's avatar
      Bug #26461: Intrinsic data type bool (1 byte) redefined to BOOL (4 bytes) · edd613be
      unknown authored
      The bool data type was redefined to BOOL (4 bytes on windows).
      Removed the #define and fixed some of the warnings that were uncovered
      by this.
      Note that the fix also disables 2 warnings :
      4800 : 'type' : forcing value to bool 'true' or 'false' (performance warning)
      4805: 'operation' : unsafe mix of type 'type' and type 'type' in operation
      
      These warnings will be handled in a separate bug, as they are performance related or bogus.
      
      Fixed to int the return type of functions that return more than 
      2 distinct values.
      
      
      CMakeLists.txt:
        Bug #26461: disable the C4800 and C4805 warnings temporarily
      include/config-win.h:
        Bug #26461: 
         - no need for this define for Windows.
         - windows C++ compilers have a bool type
      include/my_global.h:
        Bug #26461: removed bool_defined (no longer needed)
      sql/handler.h:
        Bug #26461: bool functions must return boolean values
      sql/mysql_priv.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/procedure.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_acl.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_acl.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_analyse.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_analyse.h:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_base.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_db.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_delete.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_load.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_parse.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_prepare.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      sql/sql_update.cc:
        Bug #26461: fixed return type of functions that return more than
        2 distinct values.
      edd613be
  8. 20 Mar, 2008 3 commits
    • unknown's avatar
      BUG#34788 - malformed federated connection url is not handled · 6c599276
      unknown authored
                  correctly - crashes server !
      
      Creating federated table with connect string containing empty
      (zero-length) host name and port is evaluated as 0 (port is
      incorrect, omitted or 0) crashes server.
      
      This happens because federated calls strcmp() with NULL pointer.
      
      Fixed by avoiding strcmp() call if hostname is set to NULL.
      
      
      mysql-test/r/federated.result:
        A test case for BUG#34788.
      mysql-test/t/federated.test:
        A test case for BUG#34788.
      sql/ha_federated.cc:
        Fixed that parse_url() may call strcmp() with NULL pointer.
      6c599276
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · acb93f9d
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      acb93f9d
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-4.1-axmrg · f2715573
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      configure.in:
        Manual merge
      f2715573
  9. 19 Mar, 2008 12 commits
    • unknown's avatar
      Suggestion of Tim. Avoid unnecessary sleep. · aced970c
      unknown authored
      aced970c
    • unknown's avatar
      Bug#30378: mysql.server needs to skip wait_for_pid() when mysqld \ · a8436014
      unknown authored
      	isn't running
      
      Pass the process id of the manager as a parameter to "wait_for_pid"
      and if the manager isn't running, then do not continue to wait.
      
      Also, capture the error message of our process-existence test, 
      "kill -0", as we expect errors and shouldn't pass them to the user.  
      Additionally, be a bit more descriptive of what the problem is.
      
      
      support-files/mysql.server.sh:
        Test that the PID-file's manager is running while we're waiting for
        something to happen with the pid-file.
        
        Capture the error message of our process-existence test, "kill -0",
        as we expect errors and shouldn't pass them to the user.
        Additionally, be a bit more descriptive of what the problem is.
      a8436014
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 4248a29c
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      4248a29c
    • unknown's avatar
      Merge host.loc:/home/uchum/work/PA/5.0-opt-34763 · 622aec64
      unknown authored
      into  host.loc:/home/uchum/work/5.0-opt
      
      
      sql/item.cc:
        Auto merged
      622aec64
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/b25486/50 · 5dfbc690
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      5dfbc690
    • unknown's avatar
      Merge trift2.:/MySQL/M41/push-4.1 · 13aec1e4
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      configure.in:
        Use local - version number changes don't propagate.
      13aec1e4
    • unknown's avatar
      Merge trift2.:/MySQL/M41/man8-4.1 · 6671e092
      unknown authored
      into  trift2.:/MySQL/M50/man8-5.0
      
      
      support-files/mysql.spec.sh:
        Manual merge: Add the man pages for "ndbd" and "ndb_mgmd".
      6671e092
    • unknown's avatar
      Merge trift2.:/MySQL/M41/man8-4.1 · 03536aa7
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      03536aa7
    • unknown's avatar
      support-files/mysql.spec.sh : Add the man pages for "ndbd" and "ndb_mgmd". · 8da236f7
      unknown authored
      
      support-files/mysql.spec.sh:
        Add the man pages for "ndbd" and "ndb_mgmd".
      8da236f7
    • unknown's avatar
      Bug#30960 processlist state '*** DEAD ***' on recent 5.0.48 windows builds · c9b63800
      unknown authored
      The problem is that unimplemented WIN32 version of pthread_kill
      is returning ESRCH no matter the arguments, causing calls to
      mysqld_list_processes to set the procinfo to dead because
      pthread_kill returns non zero. The dead procinfo would show
      up on a second invocation of show processlist.
      
      
      include/my_pthread.h:
        When unimplemented, pthread_kill must return zero for
        any process id other then zero.
      c9b63800
    • unknown's avatar
      Merge trift2.:/MySQL/M41/mysql-4.1 · da2f149f
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      
      configure.in:
        Auto merged
      da2f149f
    • unknown's avatar
      Bug#34529: Crash on complex Falcon I_S select after ALTER .. PARTITION BY · 53d310a2
      unknown authored
        
      When swapping out heap I_S tables to disk, this is done after plan refinement.
      Thus, READ_RECORD::file will still point to the (deleted) heap handler at start
      of execution. This causes segmentation fault if join buffering is used and the 
      query is a star query where the result is found to be empty before accessing
      some table. In this case that table has not been initialized (i.e. had its 
      READ_RECORD re-initialized) before the cleanup routine tries to close the handler.
      Fixed by updating READ_RECORD::file when changing handler.
      
      
      mysql-test/r/information_schema.result:
        Bug#34529: Test result.
      mysql-test/t/information_schema.test:
        Bug#34529: Test case.
      sql/sql_show.cc:
        Bug#34529: The fix.
      53d310a2