1. 04 Oct, 2004 3 commits
    • unknown's avatar
      Bug #5829 mysqlimport garbles path of the file to be imported · f76b8e6e
      unknown authored
      Original code was checking ! unix_socket for local_file flag.  This doesn't work and so was removed.  Now
      to import a local file, you must use the --local command line option.
      
      mysqlimport.c:
        Removed check of unix_socket to set local_file
      
      
      client/mysqlimport.c:
        Removed check of unix_socket to set local_file
      f76b8e6e
    • unknown's avatar
      patch fixing after review on patch-fixing of · 2db92385
      unknown authored
      Bug #5492 
      "set @@session.read_rnd_buffer_size=33554432" crashes server on query
      
      1. added warning comments for uint3korr (need one more byte allocated)
      2. unsigned long in uint3korr was replaced by unsigned int to 
         avoid problems on 64-bits platforms
      3. shorten warning comments in init_rr_cache in sql/records.cc
      
      
      include/config-win.h:
        1. added warning comments for uint3korr (need one more byte allocated)
        2. unsigned long in uint3korr was replaced by unsigned int to 
           avoid problems on 64-bits platforms
      include/my_global.h:
        1. added warning comments for uint3korr (need one more byte allocated)
        2. unsigned long in uint3korr was replaced by unsigned int to 
           avoid problems on 64-bits platforms
      sql/records.cc:
        shorten warning comments for my_malloc_lock in init_rr_cache
      2db92385
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.0 · 43bf4ace
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_5492/mysql-4.0
      
      43bf4ace
  2. 02 Oct, 2004 3 commits
    • unknown's avatar
      Merge acurtis@bk-internal.mysql.com:/home/bk/mysql-4.0 · 256dcf7e
      unknown authored
      into ltantony.rdg.cyberkinetica.homeunix.net:/usr/home/antony/work/bug4118
      
      256dcf7e
    • unknown's avatar
      Merge ltantony.rdg.cyberkinetica.homeunix.net:/usr/home/staff/repositories/mysql-4.0 · 23bba897
      unknown authored
      into ltantony.rdg.cyberkinetica.homeunix.net:/usr/home/antony/work/bug4118
      
      
      sql/sql_parse.cc:
        Auto merged
      23bba897
    • unknown's avatar
      Bug#4118: multi-table UPDATE takes WRITE lock on read table · 308b6792
      unknown authored
        Ensures that WRITE lock is not obtained on all tables referenced.
      
      
      mysql-test/r/lock_multi.result:
        Bug#4118
          New test for multi-update locking
      mysql-test/r/multi_update.result:
        Bug#4118
          Fix test
      mysql-test/t/lock_multi.test:
        Bug#4118
          New test for multi-update locking
      mysql-test/t/multi_update.test:
        Bug#4118
          Fix test
      sql/sql_parse.cc:
        Bug#4118
          Split multi-update to its own case statement in sql_parse.cc
      sql/sql_update.cc:
        Bug#4118
          Overview of locking checking:    
            1. Open and acquire READ lock
            2. Check to see which tables need WRITE lock
            3. Unlock tables and relock
      sql/sql_yacc.yy:
        Bug#4118
          Split multi-update to its own case statement in sql_parse.cc
      308b6792
  3. 27 Sep, 2004 1 commit
  4. 26 Sep, 2004 4 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · b99d728a
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.0-bg4131-3
      
      
      sql/sql_parse.cc:
        Auto merged
      b99d728a
    • unknown's avatar
      Fix for bug #4131 "TIMESTAMP columns missing minutes and seconds when · 0b1a83ea
      unknown authored
      using GROUP BY"
      Now we are setting Field_timestamp::field_length to 19 in open_table()
      if we are in new mode (and we are restoring it back when we are coming
      back to normal mode). This also should solve potential problems with
      some of LOAD DATA INFILE and SELECT * INTO in this mode.
      
      
      mysql-test/r/type_timestamp.result:
        Added test for bug #4131 'TIMESTAMP columns missing minutes and seconds
        when using GROUP BY' and other --new mode related behavior.
      mysql-test/t/type_timestamp.test:
        Added test for bug #4131 'TIMESTAMP columns missing minutes and seconds
        when using GROUP BY' and other --new mode related behavior.
      sql/field.cc:
        Added Field_timestamp::orig_field_length member for saving original
        field_length value, because this member can be modified if new_mode is
        in effect.
        Lot of Field_timestamp code simplified and Field_timestamp::make_field()
        is no longer needed because we are setting field_length to 19 if we are
        in --new mode now.
      sql/field.h:
        Added Field_timestamp::orig_field_length member for saving original
        field_length value, because this member can be modified if new_mode
        is in effect. 
        Field_timestamp::make_field() is no longer needed because we are setting
        field_length to 19 if we are in --new mode now.
      sql/sql_base.cc:
        If --new mode is in effect all TIMESTAMP fields should pretend that they
        have length of 19. We are achieving this by setting 
        Field_timestamp::field_length to 19 (or original value) in open_table().
        We are using TABLE::timestamp_mode variable for avoiding of unnecessary
        looping over all fields of the table and setting field_length if table
        was used with same new_mode value before.
        
        Note: We do not introduce general framework for setting up Field objects
        for usage with current THD here because this fix is only needed in 4.0
        and Monty said that we will also remove looping over all fields when
        updating table_name member at some point. This more general framework
        will also complicate nice optimization with avoiding of unneeded looping.
      sql/sql_parse.cc:
        Now when we are creating TIMESTAMP(19) fields by default in --new mode,
        otherwise we will have unaligned behavior between ALTER and CREATE.
      sql/table.h:
        Added TABLE::timestamp_mode field for saving information whenever we set 
        field_length members of table's TIMESTAMP fields to 19 (to honor 
        new_mode) or they have original values.
      0b1a83ea
    • unknown's avatar
      added --without-man option similar to --without-docs · 121a0c6f
      unknown authored
      (part of BUG#5379)
      
      121a0c6f
    • unknown's avatar
      make --with-openssl work with parameters as expected, · ffdac3e6
      unknown authored
      old options for include path and library settings still
      work for backwards compatibility
      (fix for BUG #5494)
      
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      ffdac3e6
  5. 25 Sep, 2004 1 commit
    • unknown's avatar
      Bug #5539 SHOW DATABASES LIKE and symlinks · 6dc8d45c
      unknown authored
      sql_show.cc:
        Made change suggested by Serge. REmoved else in mysql_find_files so symlink files fall through to the wildcard check
      
      
      sql/sql_show.cc:
        Made change suggested by Serge. REmoved else in mysql_find_files so symlink files fall through to the wildcard check
      6dc8d45c
  6. 24 Sep, 2004 2 commits
    • unknown's avatar
      Fix for BUG#3248 "Doc says MyISAM warns if disk full but it does not": · 5dd9b86f
      unknown authored
      we force the message to the error log, and we make it more informative;
      we treat EDQUOT like ENOSPC.
      
      
      mysys/errors.c:
        more informative message
      mysys/my_fstream.c:
        Treat EDQUOT like ENOSPC.
      mysys/my_pread.c:
        Treat EDQUOT like ENOSPC.
      mysys/my_write.c:
        Treat EDQUOT like ENOSPC.
      mysys/mysys_priv.h:
        Define EDQUOT when it does not exist. Finally decided to put it here after discussion with Monty:
        as this constant is used only in 3 files only in mysys/, I don't make it visible everywhere
        (there currently is no file of choice for such defines; my_base.h does not contain any).
        Using a value which never happens avoids collisions.
      sql/mysqld.cc:
        If ME_NOREFRESH, we write message to error log, even if it has been saved for client (because if operation
        is hanging, the message does not get to client now; example is MyISAM waiting for free disk space).
      5dd9b86f
    • unknown's avatar
      Bug #5539 SHOW DATABASES LIKE and symlinks · 05f7a47f
      unknown authored
      sql_show.cc:
        Added wild card check to symdir block in mysql_find_files
      
      
      sql/sql_show.cc:
        Added wild card check to symdir block in mysql_find_files
      05f7a47f
  7. 23 Sep, 2004 4 commits
  8. 22 Sep, 2004 3 commits
  9. 20 Sep, 2004 1 commit
    • unknown's avatar
      When coyright text is changed, autotools must be run after all · cbe47383
      unknown authored
      other actions, as otherwise timestamps of "config.h.in" will 
      cause re-run on compilation machine (fatal version problem!).
      
      
      Build-tools/mysql-copyright:
        1) Ensure that autotools are run as last action, after copyright
        change, for proper timestamps.
        2) Move the trimming of subtrees to an own function "trim_the_fat".
        3) Align 4.0 and 4.1 versions.
      cbe47383
  10. 19 Sep, 2004 3 commits
  11. 18 Sep, 2004 3 commits
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.0 · 1d475076
      unknown authored
      into mysql.com:/home/mydev/mysql-4.0-bug2831
      
      1d475076
    • unknown's avatar
      bug#2831 - --extenral-locking does not fully work with --myisam-recover. · 3573368b
      unknown authored
      Changed the semantics of open_count so that it is decremented
      at every unlock (if it was incremented due to data changes).
      So it indicates a crash, if it is non-zero after a lock.
      The table will then be repaired.
      
      
      myisam/mi_close.c:
        bug#2831 - --extenral-locking does not fully work with --myisam-recover.
        To avoid flushing the open_count at every unlock,
        we need to do so at close at least.
      myisam/mi_locking.c:
        bug#2831 - --extenral-locking does not fully work with --myisam-recover.
        open_count is now decremented at unlock (from a writelock) with
        mi_unlock_open_count(). After every new lock the state is read
        from the index file and the open_count checked. If not zero,
        another server must have crashed, so the table is marked as crashed.
        In certain situations the decremented open_count mut be flushed to
        the index file. I tried to keep these extra flushes as seldom as possible.
      sql/ha_myisam.cc:
        bug#2831 - --extenral-locking does not fully work with --myisam-recover.
        Added code to repair the table, if it is marked crashed after
        successful locking and the --myisam-recover option is set.
      sql/sql_table.cc:
        This does not really belong to the bugfix for #2831.
        But it was detected during fixing the external locking.
      3573368b
    • unknown's avatar
  12. 17 Sep, 2004 1 commit
    • unknown's avatar
      Bug#5553 - Multi table UPDATE IGNORE fails on dup key · e8bc5611
      unknown authored
        We don't want the update to abort when IGNORE is specified
      
      
      mysql-test/r/update.result:
        Bug#5553 - UPDATE IGNORE fails on dup key
          New test
      mysql-test/t/update.test:
        Bug#5553 - UPDATE IGNORE fails on dup key
          New test
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      e8bc5611
  13. 16 Sep, 2004 2 commits
    • unknown's avatar
      dict0dict.h, dict0dict.c, row0row.c, pars0opt.c: · cac596f9
      unknown authored
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      
      
      innobase/pars/pars0opt.c:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      innobase/row/row0row.c:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      innobase/dict/dict0dict.c:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      innobase/include/dict0dict.h:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      cac596f9
    • unknown's avatar
      Fixed Bug #5492 "set @@session.read_rnd_buffer_size=33554432" · 4fd743e4
      unknown authored
         crashes server on query
      
      incremented size of allocated buffer in the init_rr_cache(sql/records.cc)
      (
      We are going to read the last three bytes of the buffer via uint3korr
      This macro reads actually 4 bytes (for speed)
      So, we have to allocate one more byte at the end of the buffer 
      to avoid memory assertion fault
      )
      
      
      sql/records.cc:
        incremented size of allocated buffer in the init_rr_cache
        (
        We are going to read the last three bytes of the buffer via uint3korr
        This macro reads actually 4 bytes (for speed)
        So, we have to allocate one more byte at the end of the buffer 
        to avoid memory assertion fault
        )
        Fixed Bug #5492 "set @@session.read_rnd_buffer_size=33554432" 
          crashes server on query
      4fd743e4
  14. 14 Sep, 2004 4 commits
  15. 13 Sep, 2004 4 commits
    • unknown's avatar
      sync0arr.c: · 92082aa5
      unknown authored
        Correct the comment on the 'waiting' field in sync_cell_struct
      
      
      innobase/sync/sync0arr.c:
        Correct the comment on the 'waiting' field in sync_cell_struct
      92082aa5
    • unknown's avatar
      row0mysql.h: · f6b77bbc
      unknown authored
        Improve the comment on stored_select_lock_type
      ha_innodb.cc:
        Let InnoDB remember select_lock_type inside LOCK TABLES, also over plain consistent read SELECTs; fix Bug #5538 : assertion failure when using mysqldump with the -l option; in MERGING this patch to 4.1, there may be PROBLEMS; that is because previous patch was never merged to 4.1; Heikki Tuuri has to polish the code in 4.1 after this patch has been merged.
      
      
      sql/ha_innodb.cc:
        Let InnoDB remember select_lock_type inside LOCK TABLES, also over plain consistent read SELECTs; fix Bug #5538 : assertion failure when using mysqldump with the -l option; in MERGING this patch to 4.1, there may be PROBLEMS; that is because previous patch was never merged to 4.1; Heikki Tuuri has to polish the code in 4.1 after this patch has been merged.
      innobase/include/row0mysql.h:
        Improve the comment on stored_select_lock_type
      f6b77bbc
    • unknown's avatar
    • unknown's avatar
      Fix for bug #4809 (Backticks not handled in mysql) · 578320c0
      unknown authored
      
      client/mysql.cc:
        Code added to handle backticks
      578320c0
  16. 11 Sep, 2004 1 commit
    • unknown's avatar
      os0file.c: · 153c38de
      unknown authored
        Add more precise diagnostics about the state of the I/O threads of InnoDB; print in SHOW INNODB STATUS if the event wait semaphore of each I/O thread is set
      
      
      innobase/os/os0file.c:
        Add more precise diagnostics about the state of the I/O threads of InnoDB; print in SHOW INNODB STATUS if the event wait semaphore of each I/O thread is set
      153c38de