1. 27 Oct, 2021 6 commits
  2. 26 Oct, 2021 2 commits
    • Eugene Kosov's avatar
      MDEV-18543 IMPORT TABLESPACE fails after instant DROP COLUMN · d74d9596
      Eugene Kosov authored
      ALTER TABLE IMPORT doesn't properly handle instant alter metadata.
      This patch makes IMPORT read, parse and apply instant alter metadata at the
      very beginning of operation. So, cases when source table has some metadata
      and destination table doesn't have it now works fine.
      
      DISCARD already removes instant metadata so importing normal table into
      instant table worked fine before this patch.
      
      decrypt_decompress(): decrypts and decompresses page if needed
      
      handle_instant_metadata(): this should be the first thing to read source
      table. Basically, it applies instant metadata to a destination
      dict_table_t object. This is the first thing to read FSP flags so
      all possible checks of it were moved to this function.
      
      PageConverter::update_index_page(): it doesn't now read instant metadata.
      This logic were moved into handle_instant_metadata()
      
      row_import::match_flags(): this is a first part row_import::match_schema().
      As a separate function it's used by handle_instant_metadata().
      
      fil_space_t::is_full_crc32_compressed(): added convenient function
      
      ha_innobase::discard_or_import_tablespace(): do not reload table definition
      to read instant metadata because handle_instant_metadata() does it better.
      The reverted code was originally added in
      4e7ee166
      
      ANONYMOUS_VAR: this is a handy thing to use along with make_scope_exit()
      
      full_crc32_import.test shows different results, because no
      dict_table_close() and dict_table_open_on_id() happens.
      Thus, SHOW CREATE TABLE shows a little bit older table definition.
      d74d9596
    • Alexander Barkov's avatar
      MDEV-26732 Assertion `0' failed in Item::val_native · 49098bfd
      Alexander Barkov authored
      Also fixes MDEV-24619 Wrong result or Assertion `0' in Item::val_native / Type_handler_inet6::Item_val_native_with_conversion
      
      Type_handler_inet6::create_item_copy() created a generic Item_copy_string,
      which does not implement val_native() - it has a dummy implementation
      with DBUG_ASSERT(0), which made the server crash.
      
      Fix:
      
      - Adding a new class Type_handler_inet6
        which implements val_native().
      - Fixing Type_handler_inet6::create_item_copy()
        to make Item_copy_inet6 instead of Item_copy_string.
      49098bfd
  3. 25 Oct, 2021 2 commits
    • Anel Husakovic's avatar
      MDEV-22552: mytop packaging · 395a0332
      Anel Husakovic authored
      `mytop` and `my_print_defaults` for RPM
      
      - Add `mytop` to client package
      - Add man page of `my_print_defaults` to client package
      - Add dependencies for RPMs
      - Remove old comment
      - Remove dead link
      
      Reviewed by: serg@mariadb.com
      395a0332
    • Bernard Spil's avatar
      MDEV-22552: mytop packaging · 2011fcf8
      Bernard Spil authored
      Make `my_print_defaults` a client app (required by `mytop`).
      
      Closes #1566
      
      Reviewed by: serg@mariadb.com, anel@mariadb.org
      2011fcf8
  4. 21 Oct, 2021 18 commits
  5. 20 Oct, 2021 8 commits
    • Marko Mäkelä's avatar
    • Nikita Malyavin's avatar
      MDEV-20131 Assertion `!pk->has_virtual()' failed · d10c42b4
      Nikita Malyavin authored
      Assertion `!pk->has_virtual()' failed in dict_index_build_internal_clust
      while creating PRIMARY key longer than possible to store in the page.
      
      This happened because the key was wrongly deduced as Long UNIQUE supported,
      however PRIMARY KEY cannot be of that type. The main reason is that
      only 8 bytes are used to store the hash, see HA_HASH_FIELD_LENGTH.
      
      This is also why HA_NOSAME flag is removed (and caused the assertion in
      turn) in open_table_from_share:
            if (key_info->algorithm == HA_KEY_ALG_LONG_HASH)
            {
              key_part_end++;
              key_info->flags&= ~HA_NOSAME;
            }
      
      To make it unique, the additional check is done by
      check_duplicate_long_entries call from ha_write_row, and similar one from
      ha_update_row.
      
      PRIMARY key is already forbidden, which is checked by the first test in
      main.long_unique, however is_hash_field_needed was wrongly deduced to true
      in mysql_prepare_create_table in this particular case.
      
      FIX:
      
      * Improve the check for Key::PRIMARY type
      * Simplify is_hash_field_needed deduction for a more neat reading
      d10c42b4
    • Marko Mäkelä's avatar
      Update libmariadb · 69b3de83
      Marko Mäkelä authored
      69b3de83
    • Marko Mäkelä's avatar
      MDEV-22627 Failing assertion: dict_tf2_is_valid(flags, flags2) · b06e8167
      Marko Mäkelä authored
      create_table_info_t::innobase_table_flags(): Refuse to create
      a PAGE_COMPRESSED table with PAGE_COMPRESSION_LEVEL=0 if also
      innodb_compression_level=0.
      
      The parameter value innodb_compression_level=0 was only somewhat
      meaningful for testing or debugging ROW_FORMAT=COMPRESSED tables.
      For the page_compressed format, it never made any sense, and the
      check in dict_tf_is_valid_not_redundant() that was added in
      72378a25 (MDEV-12873) would cause
      the server to crash.
      b06e8167
    • Nikita Malyavin's avatar
      MDEV-22445 Crash on HANDLER READ NEXT after XA PREPARE · caebe151
      Nikita Malyavin authored
      The assertion is absolutely correct since no data access is possible after
      XA PREPARE.
      
      The check is added in mysql_ha_read.
      caebe151
    • Nikita Malyavin's avatar
      MDEV-26262 frm is corrupted after ER_EXPRESSION_REFERS_TO_UNINIT_FIELD · 1811fd51
      Nikita Malyavin authored
      This is a duplicate of MDEV-18278 89936f11, but I will add an
      additional assertion
      
      Description:
      
      The frm corruption should not be reported during CREATE TABLE. Normally
      it doesn't, and the data to fill TABLE is taken by open_table_from_share
      call. However, the vcol data is stored as SQL string in
      table->s->vcol_defs.str and is anyway parsed on each table open.
      It is impossible [or hard] to avoid, because it's hard to clone the
      expression tree in general (it's easier to parse).
      
      Normally parse_vcol_defs should only fail on semantic errors. If so,
      error_reported is set to true. Any other failure is not expected during
      table creation. There is either unhandled/unacknowledged error, or
      something went really wrong, like memory reject. This all should be
      asserted anyway.
      
      Solution:
      * Set *error_reported=true for the forward references check;
      * Assert for every unacknowledged error during table creation.
      1811fd51
    • Nikita Malyavin's avatar
    • Daniel Black's avatar
      MDEV-26363 Passwords incorrectly expiring after MySQL5.7 -> MariaDB10.3 -> 10.4+ upgrades · 4590f8b4
      Daniel Black authored
      MySQL-5.7 mysql.user tables have a last_password_changed field.
      
      Because before MariaDB-10.4 remained oblivious to this, the act of creating
      users or otherwise changing a users row left the last_password_field with 0.
      
      Running a MariaDB-10.4 instance on this would work correctly, until mysql_upgrade
      is run, when this 0 value immediately translates to password expired
      state.
      
      MySQL-5.7 relied on the password_expired enum to indicate password
      expiry so we aren't going to activate password that were expired in
      MySQL-5.7.
      
      Thanks Hans Borresen for the bug report and review of the fix.
      4590f8b4
  6. 19 Oct, 2021 4 commits
    • Vicențiu Ciorbaru's avatar
      Fix Groonga crash on MIPS: Correctly link to libatomic · 1388845e
      Vicențiu Ciorbaru authored
      MIPS (and possibly other) platforms require linking against libatomic to
      support 64-bit atomic integers. Groonga was failing to do so and all related
      tests were failing with an atomics relocation error on MIPS.
      
      Contributors:
      James Cowgill <jcowgill@debian.org>
      1388845e
    • Sergei Krivonos's avatar
    • Vicențiu Ciorbaru's avatar
      Fix MIPS build failure: Handle unaligned buffers in connect's TYPBLK class · a33c1082
      Vicențiu Ciorbaru authored
      On MIPS platforms (and probably others) unaligned memory access results in a
      bus error. In the connect storage engine, block data for some data formats is
      stored packed in memory and the TYPBLK class is used to read values from it.
      Since TYPBLK does not have special handling for this packed memory, it can
      quite easily result in unaligned memory accesses.
      
      The simple way to fix this is to perform all accesses to the main buffer
      through memcpy. With GCC and optimizations turned on, this call to memcpy is
      completely optimized away on architectures where unaligned accesses are ok
      (like x86).
      
      Contributors:
      James Cowgill <jcowgill@debian.org>
      a33c1082
    • Vicențiu Ciorbaru's avatar
      Link with libatomic to enable C11 atomics support · f502ccbc
      Vicențiu Ciorbaru authored
      Some architectures (mips) require libatomic to support proper
      atomic operations. Check first if support is available without
      linking, otherwise use the library.
      
      Contributors:
      James Cowgill <jcowgill@debian.org>
      Jessica Clarke <jrtc27@debian.org>
      Vicențiu Ciorbaru <vicentiu@mariadb.org>
      f502ccbc