- 09 Jul, 2008 4 commits
-
-
Matthias Leich authored
-
Mattias Jonsson authored
-
Matthias Leich authored
"funcs_2: The tests do not check if optional character sets exist." 2. Minor cleanup
-
Mattias Jonsson authored
The problem is that relying on the output of the 'ls' command is not portable as its behavior is not the same between systems and it might even not be available at all in (Windows). So I added list_files that relies on the portable mysys library instead. (and also list_files_write_file and list_files_append_file, since the test was using '--exec ls' in that way.) client/mysqltest.c: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' To be able to replace the use of '--exec ls' I have added list_files, list_files_write_file and list_files_append_file. list_files <dirname> [<filename incl. wild-cards>] is equivalent to 'ls <dirname>/[<filename incl. wild-cards>]' list_files_write_file creates/overwrites a file with the content list_files_append_file creates/appends a file with the content list_files* return a sorted output. mysql-test/r/mysqltest.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' result file change, due to added test of the new list_files command. mysql-test/suite/parts/inc/partition_check_drop.inc: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Using the new list_files instead of 'ls'. Changed the use of local variables (ls_file, file_list) and server variable (@aux). mysql-test/suite/parts/inc/partition_layout.inc: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Using the new list_files instead of 'ls'. mysql-test/suite/parts/inc/partition_layout_check1.inc: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Using the new list_files instead of 'ls'. mysql-test/suite/parts/inc/partition_layout_check2.inc: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_alter1_1_2_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_alter1_1_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_alter1_2_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_alter2_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_alter3_innodb.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_alter3_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_basic_innodb.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_basic_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_basic_symlink_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_engine_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/suite/parts/r/partition_syntax_myisam.result: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Replaces '--exec ls' with list_files. Removal of the directory part of file listing. mysql-test/t/mysqltest.test: Bug#35736 Test 'parts.partition_basic_symlink_myisam' depends on output of 'ls' Adding test for the new mysqltest commands list_files, list_files_write_file and list_files_append_file.
-
- 08 Jul, 2008 5 commits
-
-
Marc Alff authored
-
Marc Alff authored
-
Marc Alff authored
Fixed the test to expect the correct result. The previous test script was in fact affected by 26030, and wrongly expected a ER_PARSE_ERROR error.
-
Mats Kindahl authored
-
Mats Kindahl authored
-
- 07 Jul, 2008 8 commits
-
-
Mattias Jonsson authored
-
Marc Alff authored
-
Mattias Jonsson authored
-
Mattias Jonsson authored
problem was that ha_partition::records was not implemented, thus using the default handler::records, which is not correct if the engine does not support HA_STATS_RECORDS_IS_EXACT. Solution was to implement ha_partition::records as a wrapper around the underlying partitions records. The rows column in explain partitions will now include the total number of records in the partitioned table. (recommit after removing out-commented code)
-
Marc Alff authored
-
Marc Alff authored
enabled) Before this fix, the lexer and parser would treat the ';' character as a different token (either ';' or END_OF_INPUT), based on convoluted logic, which failed in simple cases where a stored procedure is implemented as a single statement, and used in a multi query. With this fix: - the character ';' is always parsed as a ';' token in the lexer, - parsing multi queries is implemented in the parser, in the 'query:' rules, - the value of thd->client_capabilities, which is the capabilities negotiated between the client and the server during bootstrap, is immutable and not arbitrarily modified during parsing (which was the root cause of the bug)
-
Georgi Kodinov authored
- moved the test into a separate file to check for presence of the test variable mysql-test/r/subselect.result: Bug#37627: moved the test to a separate file mysql-test/r/subselect_debug.result: Bug#37627: moved the test to a separate file mysql-test/t/subselect.test: Bug#37627: moved the test to a separate file mysql-test/t/subselect_debug.test: Bug#37627: moved the test to a separate file
-
Mats Kindahl authored
On certain kinds of errors (e.g., out of stack), a call to Item_func_ set_user_var::fix_fields() might fail. Since the return value of this call was not checked inside User_var_log_event::exec_event(), continuing execution after this will cause a crash inside Item_func_set_user_var:: update_hash(). The bug is fixed by aborting execution of the event with an error if fix_fields() fails, since it is not possible to continue execution anyway. sql/log_event.cc: Aborting execution of event if fix_fields() fails since execution of update_hash() might cause a crash.
-
- 04 Jul, 2008 5 commits
-
-
Chad MILLER authored
-
Chad MILLER authored
-
Chad MILLER authored
to use ANSI_QUOTES Make all have_* tests universally safe by using ANSI quotes.
-
Georgi Kodinov authored
-
Georgi Kodinov authored
When there is an error executing EXISTS predicates they return NULL as their string or decimal value but don't set the NULL value flag. Fixed by returning 0 (as a decimal or a string) on error exectuting the subquery. Note that we can't return NULL as EXISTS is not supposed to return NULL. mysql-test/r/subselect.result: Bug#37627: test case mysql-test/t/subselect.test: Bug#37627: test case sql/item_subselect.cc: Bug#37627: return decimal (or string) 0 isntead of a NULL pointer on error calculating an EXISTS predicate.
-
- 03 Jul, 2008 3 commits
-
-
Konstantin Osipov authored
Bug#12093 "SP not found on second PS execution if another thread drops other SP in between" and Bug#21294 "executing a prepared statement that executes a stored function which was recreat" Stored functions are resolved at prepared statement prepare only. If someone flushes the stored functions cache between prepare and execute, execution fails. The fix is to detect the situation of the cache flush and automatically reprepare the prepared statement after it. mysql-test/r/ps_ddl.result: Update results (Bug#12093 and Bug#21294, the test cases are already in the source tree). mysql-test/r/ps_ddl1.result: Update results (Bug#12093 and Bug#21294, the test cases are already in the source tree). mysql-test/r/sp-error.result: Update results (Bug#12093 and Bug#21294, the test cases are already in the source tree). mysql-test/t/ps_ddl.test: Modify the test to not expect an error where there is no error any more (Bug#12093, Bug#21294). mysql-test/t/ps_ddl1.test: Modify the test to not expect an error where there is no error any more (Bug#12093, Bug#21294). mysql-test/t/sp-error.test: Modify the test to not expect an error where there is no error any more (Bug#12093, Bug#21294). sql/sp_cache.cc: Implement sp_cache_version() -- returns the current version of a stored routines cache. sql/sp_cache.h: Declare sp_cache_version(). sql/sql_prepare.cc: Keep track of stored functions cache version, and invalidate the statement if it changed between prepared statement prepare and execute (and the statement actually uses stored routines).
-
Sven Sandberg authored
-
Sven Sandberg authored
This bug has been fixed in two slightly different ways in 6.0-rpl and {5.1,6.0}-bugteam. To avoid future merge problems, I'm now copying the 6.0-rpl fix to 5.1-bugteam.
-
- 02 Jul, 2008 3 commits
-
-
Timothy Smith authored
-
Sven Sandberg authored
The previous fix for the bug was incomplete. The test failed because t2 did not exist on the slave (since the slave was lagging) when the wait_condition was executed. Fixed by inserting sync_slave_with_master just after t2 was created.
-
Timothy Smith authored
-
- 01 Jul, 2008 3 commits
-
-
Patrick Crews authored
-
Patrick Crews authored
Test was failing due to the addition of a '\x05' character in result sets Latest builds of the server have shown this problem to have disappeared. Removing code within the test that disables the test on Mac OS X. Recommit due to tree error on earlier, approved patch.
-
Mattias Jonsson authored
REORGANIZE TEST parts WHERE ENGINE='NDB' ;) Updated tests for better matching NDB's limitations. Removed some duplicate tests. mysql-test/suite/parts/inc/part_supported_sql_funcs_delete.inc: Bug#36732: many disabled ndb tests in test suite parts Added variable for NDB (since it does not support DROP PARTITION) mysql-test/suite/parts/inc/partition_alter_11.inc: Bug#36732: many disabled ndb tests in test suite parts Assigning directly to variable without going through the server. mysql-test/suite/parts/inc/partition_bigint.inc: Bug#36732: many disabled ndb tests in test suite parts Added --sorted_result for consistency lowered number of partitions for use with NDB (NDB can only do maximum of 8 partitions) mysql-test/suite/parts/inc/partition_int.inc: Bug#36732: many disabled ndb tests in test suite parts Added --sorted_result for consistency lowered number of partitions for use with NDB (NDB can only do maximum of 8 partitions) mysql-test/suite/parts/inc/partition_mediumint.inc: Bug#36732: many disabled ndb tests in test suite parts Added --sorted_result for consistency lowered number of partitions for use with NDB (NDB can only do maximum of 8 partitions) mysql-test/suite/parts/inc/partition_smallint.inc: Bug#36732: many disabled ndb tests in test suite parts Added --sorted_result for consistency lowered number of partitions for use with NDB (NDB can only do maximum of 8 partitions) mysql-test/suite/parts/inc/partition_supported_sql_funcs.inc: Bug#36732: many disabled ndb tests in test suite parts Made it work better with NDB mysql-test/suite/parts/inc/partition_tinyint.inc: Bug#36732: many disabled ndb tests in test suite parts Added --sorted_result for consistency lowered number of partitions for use with NDB (NDB can only do maximum of 8 partitions) mysql-test/suite/parts/r/ndb_blob_partition.result: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/r/ndb_dd_backuprestore.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/ndb_partition_error.result: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/r/ndb_partition_key.result: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/r/ndb_partition_list.result: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/r/ndb_partition_range.result: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/r/part_supported_sql_func_ndb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_alter1_1_innodb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_alter1_1_myisam.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_alter1_2_innodb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file. Diff bigger than necessary, due to bzr diff bug. mysql-test/suite/parts/r/partition_alter1_2_myisam.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_alter2_innodb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_alter2_myisam.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_engine_ndb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_int_innodb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_int_myisam.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/partition_int_ndb.result: Bug#36732: many disabled ndb tests in test suite parts Updated result file mysql-test/suite/parts/r/rpl_ndb_dd_partitions.result: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/rpl_ndb mysql-test/suite/parts/t/disabled.def: Bug#36732: many disabled ndb tests in test suite parts Removed some duplicate tests, fixed some tests. Removed the 'runs too long on PB' test from disabled.def and made them to require 'big-test'. mysql-test/suite/parts/t/ndb_blob_partition.test: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/t/ndb_dd_backuprestore.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/ndb_partition_error.test: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/t/ndb_partition_key.test: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/t/ndb_partition_list.test: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/t/ndb_partition_range.test: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/ndb mysql-test/suite/parts/t/part_supported_sql_func_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. Added ndb restriction variables. mysql-test/suite/parts/t/partition_alter1_1_2_ndb.test: Bug#36732: many disabled ndb tests in test suite parts requiring big-test instead of disable it. mysql-test/suite/parts/t/partition_alter1_1_ndb.test: Bug#36732: many disabled ndb tests in test suite parts requiring big-test instead of disable it. mysql-test/suite/parts/t/partition_alter1_2_ndb.test: Bug#36732: many disabled ndb tests in test suite parts requiring big-test instead of disable it. mysql-test/suite/parts/t/partition_alter2_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/partition_basic_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/partition_bit_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/partition_engine_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/partition_int_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/partition_syntax_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/partition_value_ndb.test: Bug#36732: many disabled ndb tests in test suite parts Added new=on for allowing test of hash/range and list partitioning. mysql-test/suite/parts/t/rpl_ndb_dd_partitions.test: Bug#36732: many disabled ndb tests in test suite parts Removing this duplicate test since it already exists (and updated) in suite/rpl_ndb
-
- 30 Jun, 2008 1 commit
-
-
Sven Sandberg authored
Problem: rpl_switch_stm_row_mixed did not wait until row events generated by INSERT DELAYED were written to the master binlog before it synchronized slave with master. This caused sporadic errors where these rows were missing on slave. Fix: wait until all rows appear on the slave. This is a backport, applying the same to 5.1-bugteam as was previously applied to 6.0-rpl
-
- 27 Jun, 2008 8 commits
-
-
Timothy Smith authored
-
Timothy Smith authored
-
Timothy Smith authored
Differences in 5.1: include "/etc/mysql/" in include directories; no OS/2 support.
-
Gleb Shchepa authored
-
Gleb Shchepa authored
InnoDB table, where all selected columns belong to the same unique index key, returns incorrect results Server executes some queries via QUICK_GROUP_MIN_MAX_SELECT (MIN/MAX optimization for queries with GROUP BY or DISTINCT clause) and that optimization implies loose index scan, so all grouping is done by the QUICK_GROUP_MIN_MAX_SELECT::get_next method. The server does not set the precomputed_group_by flag for some QUICK_GROUP_MIN_MAX_SELECT queries and duplicates grouping by call to the end_send_group function. Fix: when the test_if_skip_sort_order function selects loose index scan as a best way to satisfy an ORDER BY/GROUP BY type of query, the precomputed_group_by flag has been set to use end_send/end_write functions instead of end_send_group/ end_write_group functions. mysql-test/r/group_min_max_innodb.result: Fixed bug #36632: SELECT DISTINCT from a simple view on an InnoDB table, where all selected columns belong to the same unique index key, returns incorrect results mysql-test/t/group_min_max_innodb.test: Fixed bug #36632: SELECT DISTINCT from a simple view on an InnoDB table, where all selected columns belong to the same unique index key, returns incorrect results sql/sql_select.cc: Fixed bug #36632: SELECT DISTINCT from a simple view on an InnoDB table, where all selected columns belong to the same unique index key, returns incorrect results
-
Gleb Shchepa authored
-
Gleb Shchepa authored
Bug#35658 (An empty binary value leads to mysqld crash) Before this fix, the following token b'' caused the parser to crash when reading the binary value from the empty string. The crash was caused by: ptr+= max_length - 1; because max_length is unsigned and was 0, causing an overflow. With this fix, an empty binary literal b'' is parsed as a binary value 0, in Item_bin_string. mysql-test/r/varbinary.result: Bug#35658 (An empty binary value leads to mysqld crash) mysql-test/t/varbinary.test: Bug#35658 (An empty binary value leads to mysqld crash) sql/item.cc: Bug#35658 (An empty binary value leads to mysqld crash)
-
Gleb Shchepa authored
Bug#35658 (An empty binary value leads to mysqld crash) Before this fix, the following token b'' caused the parser to crash when reading the binary value from the empty string. The crash was caused by: ptr+= max_length - 1; because max_length is unsigned and was 0, causing an overflow. With this fix, an empty binary literal b'' is parsed as a binary value 0, in Item_bin_string. mysql-test/r/varbinary.result: Bug#35658 (An empty binary value leads to mysqld crash) mysql-test/t/varbinary.test: Bug#35658 (An empty binary value leads to mysqld crash) sql/item.cc: Bug#35658 (An empty binary value leads to mysqld crash)
-