1. 25 May, 2004 3 commits
    • unknown's avatar
      Proposed fix for bug #3818 (libmysqld.dll leads to program's crash) · f85e1443
      unknown authored
      configurations added to build the libraries with USE_TLS flag to be
      used for libmysqld
      
      
      VC++Files/dbug/dbug.dsp:
        TLS_DEBUG configuration added
      VC++Files/heap/heap.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/isam/isam.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/libmysql/libmysql.dsp:
        MYSQL_CLIENT define enabled
      VC++Files/libmysqld/libmysqld.dsp:
        using of _tls libraries added
      VC++Files/myisam/myisam.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/myisammrg/myisammrg.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/mysys/mysys.dsp:
        TLS and TLS_DEBUG configurations added
      include/mysql_com.h:
        __declspec(dllimport) seems to be necessary when one uses .dll
        on Windows
      f85e1443
    • unknown's avatar
      Removed references to BDB and InnoDB from 'classic' release · 745510b6
      unknown authored
      
      VC++Files/mysqldemb/mysqldemb.dsp:
        Removed references to BDB and InnoDB from 'classic'
      VC++Files/sql/mysqld.dsp:
        Removed references to BDB and InnoDB from 'classic'
      745510b6
    • unknown's avatar
      fixed typos · d672bf8c
      unknown authored
      d672bf8c
  2. 24 May, 2004 5 commits
    • unknown's avatar
      Fixed typo · bd8c505b
      unknown authored
      bd8c505b
    • unknown's avatar
      New MYSQL_SERVER_SUFFIX usage (for easier compilation) · 072d1044
      unknown authored
      Update of VC++ project files.
      
      
      VC++Files/mysqlmanager/childfrm.cpp:
        Rename: VC++Files/mysqlmanager/CHILDFRM.CPP -> VC++Files/mysqlmanager/childfrm.cpp
      VC++Files/mysqlmanager/childfrm.h:
        Rename: VC++Files/mysqlmanager/CHILDFRM.H -> VC++Files/mysqlmanager/childfrm.h
      VC++Files/mysqlmanager/mainfrm.cpp:
        Rename: VC++Files/mysqlmanager/MAINFRM.CPP -> VC++Files/mysqlmanager/mainfrm.cpp
      VC++Files/mysqlmanager/mainfrm.h:
        Rename: VC++Files/mysqlmanager/MAINFRM.H -> VC++Files/mysqlmanager/mainfrm.h
      VC++Files/mysqlmanager/mysqlmanager.dsp:
        Rename: VC++Files/mysqlmanager/MySqlManager.dsp -> VC++Files/mysqlmanager/mysqlmanager.dsp
      VC++Files/mysqlmanager/mysqlmanager.mak:
        Rename: VC++Files/mysqlmanager/MySqlManager.mak -> VC++Files/mysqlmanager/mysqlmanager.mak
      VC++Files/mysqlmanager/resource.h:
        Rename: VC++Files/mysqlmanager/RESOURCE.H -> VC++Files/mysqlmanager/resource.h
      VC++Files/mysqlmanager/stdafx.cpp:
        Rename: VC++Files/mysqlmanager/STDAFX.CPP -> VC++Files/mysqlmanager/stdafx.cpp
      VC++Files/mysqlmanager/stdafx.h:
        Rename: VC++Files/mysqlmanager/STDAFX.H -> VC++Files/mysqlmanager/stdafx.h
      VC++Files/mysqlmanager/toolsql.cpp:
        Rename: VC++Files/mysqlmanager/TOOLSQL.CPP -> VC++Files/mysqlmanager/toolsql.cpp
      VC++Files/mysqlmanager/toolsql.h:
        Rename: VC++Files/mysqlmanager/TOOLSQL.H -> VC++Files/mysqlmanager/toolsql.h
      VC++Files/mysqlmanager/RES/bitmap1.bmp:
        Rename: VC++Files/mysqlmanager/RES/BITMAP1.BMP -> VC++Files/mysqlmanager/RES/bitmap1.bmp
      VC++Files/mysqlmanager/RES/bitmap3.bmp:
        Rename: VC++Files/mysqlmanager/RES/BITMAP3.BMP -> VC++Files/mysqlmanager/RES/bitmap3.bmp
      VC++Files/mysqlmanager/RES/bmp00001.bmp:
        Rename: VC++Files/mysqlmanager/RES/BMP00001.BMP -> VC++Files/mysqlmanager/RES/bmp00001.bmp
      VC++Files/mysqlmanager/RES/bmp00002.bmp:
        Rename: VC++Files/mysqlmanager/RES/BMP00002.BMP -> VC++Files/mysqlmanager/RES/bmp00002.bmp
      VC++Files/mysqlmanager/RES/database.bmp:
        Rename: VC++Files/mysqlmanager/RES/DATABASE.BMP -> VC++Files/mysqlmanager/RES/database.bmp
      VC++Files/mysqlmanager/RES/fontd.bmp:
        Rename: VC++Files/mysqlmanager/RES/FONTD.BMP -> VC++Files/mysqlmanager/RES/fontd.bmp
      VC++Files/mysqlmanager/RES/fontu.bmp:
        Rename: VC++Files/mysqlmanager/RES/FONTU.BMP -> VC++Files/mysqlmanager/RES/fontu.bmp
      VC++Files/mysqlmanager/RES/query_ex.bmp:
        Rename: VC++Files/mysqlmanager/RES/QUERY_EX.BMP -> VC++Files/mysqlmanager/RES/query_ex.bmp
      VC++Files/mysqlmanager/RES/toolbar.bmp:
        Rename: VC++Files/mysqlmanager/RES/TOOLBAR.BMP -> VC++Files/mysqlmanager/RES/toolbar.bmp
      BUILD/compile-pentium-valgrind-max:
        Use MYSQL_SERVER_SUFFIX
      VC++Files/bdb/bdb.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysql.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqladmin.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqldump.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqlimport.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqlshow.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/copy_mysql_files.bat:
        Assume we are in correct directory
      VC++Files/innobase/innobase.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
        Remove old files
      VC++Files/isamchk/isamchk.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/libmysqld/libmysqld.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/my_print_defaults/my_print_defaults.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/myisamchk/myisamchk.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/myisamlog/myisamlog.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/myisampack/myisampack.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysql.dsw:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysqlbinlog/mysqlbinlog.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysqlcheck/mysqlcheck.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysys/mysys.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/pack_isam/pack_isam.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/perror/perror.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/replace/replace.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/sql/mysqld.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      include/my_global.h:
        Added QUOTE and STRINGIFY
      include/mysql_version.h.in:
        New MYSQL_SERVER_SUFFIX handling
      innobase/eval/eval0eval.c:
        Fixed compiler warning
      libmysql/libmysql.c:
        Use STRINGIFY()
      sql/mysqld.cc:
        New MYSQL_SERVER_SUFFIX handling
      sql/mysqld_suffix.h:
        New MYSQL_SERVER_SUFFIX handling
      sql/set_var.cc:
        Use STRINGIFY()
      zlib/contrib/asm386/zlibvc.dsp:
        Updated for 4.0
      072d1044
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 1d75858c
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      1d75858c
    • unknown's avatar
      Fix for BUG#3871: a slave must always replicate a statement, even if it examines more than 4G rows, · b5b38cd9
      unknown authored
      so we set SQL_BIG_SELECTS to 1.
      
      
      sql/slave.cc:
        The slave SQL thread must always have SQL_BIG_SELECTS=1, so that it does not fail to replicate an INSERT SELECT
        examining more than 4 billion rows (for client threads, SQL_BIG_SELECTS is automatically set to 1 if
        max_join_size is 4G, but that's in handle_one_connection, so not for the slave thread).
      b5b38cd9
    • unknown's avatar
      InnoDB cleanup: sync0arr.c: sync_array_cell_print(): Remove unused variable str · 2b5c2069
      unknown authored
      
      innobase/sync/sync0arr.c:
        sync_array_cell_print(): Remove unused variable str
      2b5c2069
  3. 20 May, 2004 1 commit
    • unknown's avatar
      Bug fixes: · 8dd7e396
      unknown authored
      Use %windir% instead of c:\winnt\ (Bug #3786)
      Fixed wrong foreign key test in crash-me (Bug #3740)
      
      
      VC++Files/libmysql/libmysql.dsp:
        Use %windir% instead of c:\winnt\ (Bug #3786)
      sql-bench/crash-me.sh:
        Fixed wrong foreign key test (Bug #3740)
      sql-bench/limits/mysql.cfg:
        Updated results
      8dd7e396
  4. 19 May, 2004 6 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.0 · 0cc766f4
      unknown authored
      into mysql.com:/dbdata/psergey/mysql-4.0-root
      
      0cc766f4
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · bf8e565b
      unknown authored
      into mysql.com:/home/my/mysql-4.0
      
      
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      bf8e565b
    • unknown's avatar
      Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt' · 0178851c
      unknown authored
      Ensured that all projects compile
      Removed compiler warnings
      Better setting of server_version variable.
      Fix that make_win_src_distribution creates the privilege tables.
      
      
      VC++Files/bdb/bdb.dsp:
        Small, automatic changes
      VC++Files/client/mysql.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqladmin.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqlclient.dsp:
        Removed files that should only be used with mysql command line client
      VC++Files/client/mysqldump.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqlimport.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqlshow.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/comp_err/comp_err.dsp:
        Automatic changes
      VC++Files/dbug/dbug.dsp:
        Automatic changes
      VC++Files/heap/heap.dsp:
        automatic changes
      VC++Files/innobase/innobase.dsp:
        Automatic changes
      VC++Files/isam/isam.dsp:
        Automatic changes
      VC++Files/isamchk/isamchk.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/libmysql/libmysql.dsp:
        Automatic changes
      VC++Files/libmysqld/examples/test_libmysqld.dsp:
        Add missing files
      VC++Files/libmysqld/libmysqld.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/libmysqltest/myTest.dsp:
        Automatic changes
      VC++Files/merge/merge.dsp:
        Automatic changes
      VC++Files/my_print_defaults/my_print_defaults.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisam/myisam.dsp:
        automatic changes
      VC++Files/myisam_ftdump/myisam_ftdump.dsp:
        automatic changes
      VC++Files/myisamchk/myisamchk.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisamlog/myisamlog.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisammrg/myisammrg.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisampack/myisampack.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysql.dsw:
        Automatic changes
      VC++Files/mysqlbinlog/mysqlbinlog.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysqlcheck/mysqlcheck.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysqldemb/mysqldemb.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysqlserver/mysqlserver.dsp:
        Automatic changes
      VC++Files/mysqlshutdown/mysqlshutdown.dsp:
        Automatic changes
      VC++Files/mysqlwatch/mysqlwatch.dsp:
        Automatic changes
      VC++Files/mysys/mysys.dsp:
        Automatic changes
      VC++Files/pack_isam/pack_isam.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/perror/perror.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/regex/regex.dsp:
        Automatic changes
      VC++Files/replace/replace.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/sql/mysqld.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/strings/strings.dsp:
        Removed duplicate code for strnlen
      VC++Files/test1/test1.dsp:
        Automatic changes
      VC++Files/thr_test/thr_test.dsp:
        Automatic changes
      VC++Files/vio/vio.dsp:
        Automatic changes
      VC++Files/zlib/contrib/asm386/zlibvc.dsp:
        Automatic changes
      VC++Files/zlib/zlib.dsp:
        Automatic changes
      extra/my_print_defaults.c:
        Fixed bug in --verbose
      include/m_string.h:
        Portability fix
      include/mysql_embed.h:
        Better setting of server_version variable
      include/mysql_version.h.in:
        Better license text handling
      innobase/pars/pars0lex.l:
        Remove compiler warnings
      innobase/trx/trx0sys.c:
        Remove compiler warnings
      libmysqld/lib_sql.cc:
        Better setting of server_version variable
      libmysqld/libmysqld.def:
        Add functions needed for mysql command line client
      myisam/myisam_ftdump.c:
        Remove compiler warnings
      mysys/sha1.c:
        Remove compiler warnings
      scripts/make_win_src_distribution.sh:
        Safety fix
      scripts/mysql_install_db.sh:
        Backport from 4.1 to allow make_win_src_distribution create the privilege tables
      sql/Makefile.am:
        Add new file mysqld_suffix.h
        Remove not used file sql_olap.h
      sql/ha_innodb.cc:
        Remove not used variable
      sql/mysqld.cc:
        Better setting of server_version variable
      sql/set_var.cc:
        Fixed bug when showing lower_case_file_system
      strings/ctype-tis620.c:
        Remove compiler warnings
      0178851c
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 45ef055d
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      sql/set_var.cc:
        Auto merged
      45ef055d
    • unknown's avatar
      Fix for BUG#3829 "Setting server_id on fly doesn't allow replication to start" · bf47ff08
      unknown authored
      (fix by our Harrison Fisk): when one does SET GLOBAL SERVER_ID=x, we must set
      server_id_supplied to 1.
      
      
      sql/mysql_priv.h:
        server_id_supplied must be here to be visible in set_var.cc
      sql/mysqld.cc:
        rephrasing warnings when server id is not set explicitely.
      sql/set_var.cc:
        when one does SET GLOBAL SERVER_ID=x; it should be considered as explicitely setting
        the server id, so do server_id_supplied=1.
      sql/slave.cc:
        Correcting wrong comment
      bf47ff08
    • unknown's avatar
      Fix for Bug#3754 "SET GLOBAL myisam_max_sort_file_size doesn't · b7a0883c
      unknown authored
      work as expected": precision-losing conversion removed from 
      sys_var_thd_ulonglong.
      
      
      mysql-test/r/variables.result:
        Test case for Bug#3754
      mysql-test/t/variables.test:
        Test case for Bug#3754
      sql/set_var.cc:
        Fix for Bug#3754: precision-losing conversion removed from 
        sys_var_thd_ulonglong.
      b7a0883c
  5. 18 May, 2004 3 commits
  6. 17 May, 2004 7 commits
    • unknown's avatar
      mem0pool.c: · 8133349d
      unknown authored
        Fix a memory corruption bug: in 32-bit computers, every 4 billionth malloc outside innodb_additional_mem_pool_size was mistreated when freeing the memory; this could corrupt the InnoDB additional mem pool and could have caused crashes anywhere, also inside MySQL, or even database corruption! the bug exists also in 3.23 and 4.1; workaround: configure innodb_additional_mem_pool_size big enough
      
      
      innobase/mem/mem0pool.c:
        Fix a memory corruption bug: in 32-bit computers, every 4 billionth malloc outside innodb_additional_mem_pool_size was mistreated when freeing the memory; this could corrupt the InnoDB additional mem pool and could have caused crashes anywhere, also inside MySQL, or even database corruption! the bug exists also in 3.23 and 4.1; workaround: configure innodb_additional_mem_pool_size big enough
      8133349d
    • unknown's avatar
      dict0dict.c: · 527f80b8
      unknown authored
        Allocate the table name buffer from the mem heap of a foreign key object rather than pointing to the name buffer in the table object; even though this apparently caused no bugs in RENAME, DROP, ALTER TABLE, or elsewhere, this convention was very prone to memory allocation bugs
      
      
      innobase/dict/dict0dict.c:
        Allocate the table name buffer from the mem heap of a foreign key object rather than pointing to the name buffer in the table object; even though this apparently caused no bugs in RENAME, DROP, ALTER TABLE, or elsewhere, this convention was very prone to memory allocation bugs
      527f80b8
    • unknown's avatar
      InnoDB: srv0srv.c: Remove reference to sync0ipm.h (fix ChangeSet@1.1833) · ef12e29e
      unknown authored
      
      innobase/srv/srv0srv.c:
        Remove reference to sync0ipm.h
      ef12e29e
    • unknown's avatar
      added newline at the end of the file. · e881a387
      unknown authored
      e881a387
    • unknown's avatar
      InnoDB: Remove unused module sync0ipm · b0a97a1e
      unknown authored
      
      BitKeeper/deleted/.del-sync0ipm.c~48eb5196b6819734:
        Delete: innobase/sync/sync0ipm.c
      BitKeeper/deleted/.del-sync0ipm.h~92a27f3bd9b15164:
        Delete: innobase/include/sync0ipm.h
      BitKeeper/deleted/.del-sync0ipm.ic~2024167f6418de39:
        Delete: innobase/include/sync0ipm.ic
      innobase/sync/makefilewin:
        Remove unused file sync0ipm.c
      innobase/include/Makefile.am:
        Remove unused files sync0ipm.h and sync0ipm.ic
      innobase/sync/Makefile.am:
        Remove unused file sync0ipm.c
      b0a97a1e
    • unknown's avatar
      InnoDB: Remove unused module os0shm · 2a4a0a37
      unknown authored
      
      BitKeeper/deleted/.del-os0shm.h~72e5e03d7b74061f:
        Delete: innobase/include/os0shm.h
      BitKeeper/deleted/.del-os0shm.c~489ce7f33d07ffa:
        Delete: innobase/os/os0shm.c
      BitKeeper/deleted/.del-os0shm.ic~1cac6731d2a64d53:
        Delete: innobase/include/os0shm.ic
      innobase/include/Makefile.am:
        Remove unused files os0shm.h and os0shm.ic
      innobase/os/Makefile.am:
        Remove unused file os0shm.c
      innobase/os/makefilewin:
        Remove unused file os0shm.c
      2a4a0a37
    • unknown's avatar
  7. 15 May, 2004 1 commit
  8. 14 May, 2004 4 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · b2d2dd5c
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      b2d2dd5c
    • unknown's avatar
      Replication testsuite: making the master-slave synchronization less likely to fail, · 190b3a25
      unknown authored
      by adding sleep-and-retries (max 4 times) if MASTER_POS_WAIT() returns NULL
      in sync_with_master and sync_slave_with_master.
      The problem showed up only today, in MySQL 5.0 in rpl_server_id2.test,
      but may affect 4.x as well, so fixing it here. Note that I am also fixing
      5.0 too, with the same exact patch, because I don't want to leave 5.0 broken
      until the next 4.0->4.1->5.0 merge.
      
      
      client/mysqltest.c:
        in sync_with_master (and sync_slave_with_master), if MASTER_POS_WAIT() returns NULL,
        it may be that the slave SQL thread did not have time to start yes, so we sleep
        1 sec and retry, 4 times at most.
      mysql-test/r/rpl_server_id2.result:
        result update
      mysql-test/t/rpl_server_id2.test:
        master_slave.inc already drops the table
      190b3a25
    • unknown's avatar
      Many files: · aecddd8e
      unknown authored
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      
      
      sql/sql_class.h:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/ha_innodb.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/log_event.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/slave.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/sql_db.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/sql_parse.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      sql/sql_show.cc:
        Fix remaining cases of Bug #3596: fix possible races caused by an obsolete value of thd->query_length in SHOW PROCESSLIST and SHOW INNODB STATUS; this fix depends on the fact that thd->query is always set to NULL before setting it to point to a new query
      aecddd8e
    • unknown's avatar
      InnoDB: Remove unused function ut_str_catenate() · 80264cb0
      unknown authored
      
      innobase/include/ut0mem.h:
        Remove unused function ut_str_catenate()
      innobase/ut/ut0mem.c:
        Remove unused function ut_str_catenate()
      80264cb0
  9. 13 May, 2004 8 commits
    • unknown's avatar
      ha_innodb.cc, trx0trx.h, lock0lock.c, trx0trx.c: · 961cd760
      unknown authored
      Reserve the MySQL LOCK_thread_count mutex when printing thd->query of
      an arbitrary transaction; if we are printing thd->query of a transaction that
      we know is currently executing inside InnoDB, then we know that MySQL cannot
      meanwhile change thd->query, and no need to reserve the MySQL mutex; note
      that this patch still leaves open the possibility of races in MySQL's
      thd->query_len
      
      
      innobase/trx/trx0trx.c:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      innobase/lock/lock0lock.c:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      innobase/include/trx0trx.h:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      sql/ha_innodb.cc:
        Reserve the MySQL LOCK_thread_count mutex when printing thd->query of an arbitrary transaction; if we are printing thd->query of the a transaction that we know is currently executing inside InnoDB, then we know that MySQL cannot meanwhile change thd->query, and no need to reserve the MySQL mutex; note that thsi patch still leaves aopen the possibility of races in MySQL's thd->query_len
      961cd760
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · e58e8a1b
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      e58e8a1b
    • unknown's avatar
      ha_innodb.cc: · d6360496
      unknown authored
        A flawed fix of the thd->query race in SHOW INNODB STATUS; see the comments in code about how to fix this properly; we cannot use LOCK_thread_count to protect thd->query, because that will cause a deadlock of threads
      
      
      sql/ha_innodb.cc:
        A flawed fix of the thd->query race in SHOW INNODB STATUS; see the comments in code about how to fix this properly; we cannot use LOCK_thread_count to protect thd->query, because that will cause a deadlock of threads
      d6360496
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.0 · bddf10f5
      unknown authored
      into mysql.com:/space/my/mysql-4.0-build
      
      bddf10f5
    • unknown's avatar
      - make sure the binaries are executable before calling them during · 8d5fb1a3
      unknown authored
         make_binary_distribution (bug#2857)
      
      
      scripts/make_binary_distribution.sh:
         - make sure the binaries are executable before calling them (bug#2857)
      8d5fb1a3
    • unknown's avatar
      ha_innodb.cc: · 568b6cfa
      unknown authored
        innobase_mysql_print_thd(): protect thd with LOCK_thread_count (Bug #3596)
      
      
      sql/ha_innodb.cc:
        innobase_mysql_print_thd(): protect thd with LOCK_thread_count
      568b6cfa
    • unknown's avatar
      InnoDB: fixed bug in dict0dict.c: dict_index_name_print() · 7aa4652d
      unknown authored
      
      innobase/dict/dict0dict.c:
        dict_index_name_print(): output table name to file, not stderr
      7aa4652d
    • unknown's avatar
      InnoDB: Remove os_file_lock() from the 4.0 tree (unfix Bug #3608) · 1fbd375c
      unknown authored
      
      innobase/os/os0file.c:
        Remove os_file_lock()
      1fbd375c
  10. 12 May, 2004 2 commits