- 06 Oct, 2017 1 commit
-
-
Marko Mäkelä authored
In MariaDB Server 10.1, this problem manifests itself only as a debug assertion failure in page_zip_decompress() when an insert requires a page to be decompressed. In MariaDB 10.1, the encryption of InnoDB data files repurposes the previously unused field FILE_FLUSH_LSN for an encryption key version. This field was only used in the first page of each file of the system tablespace. For ROW_FORMAT=COMPRESSED tables, the field was always written as 0 until encryption was implemented. There is no bug in the encryption, because the buffer pool blocks will not be written to files. Instead, copies of the blocks will be encrypted. In these encrypted copies, the key version field will be updated before the buffer is written to the file. The field in the buffer pool is basically garbage that does not really matter. Already in MariaDB 10.0, the memset() calls to reset this unused field in buf_flush_update_zip_checksum() and buf_flush_write_block_low() are unnecessary, because fsp_init_file_page_low() would guarantee that the field is always 0 in the buffer pool (unless 10.1 encryption is used). Removing the unnecessary memset() calls makes page_zip_decompress() happy and will prevent a SPATIAL INDEX corruption bug in MariaDB Server 10.2. In MySQL 5.7.5, as part of WL#6968, the same field was repurposed for an R-tree split sequence number (SSN) and these memset() were removed. (Because of the repurposing, MariaDB encryption is not available for tables that contain SPATIAL INDEX.)
-
- 05 Oct, 2017 1 commit
-
-
Alexander Barkov authored
-
- 02 Oct, 2017 4 commits
-
-
sachin authored
This is regression caused by patch of mdev-10767. 1st problem :- mktmp is invoked without '-t' or specifing tmp directory. 2nd problem :- Since eval_log_error redirect stderr to stdout '2>' will return nothing. and hence $wr_logfile will be empty. Patch Credit:- Andrii Nikitin
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
btr_cur_pessimistic_delete(): Discard a possible record lock also in the case when the record was the only one in the page. Failure to do this would corrupt the record lock data structures in a partial rollback (ROLLBACK TO SAVEPOINT or rolling back a row operation due to some error, such as a duplicate key in a unique secondary index).
-
- 29 Sep, 2017 1 commit
-
-
Jan Lindström authored
Patch contibuted by Gordon Fisher. Thank you for your contribution!
-
- 28 Sep, 2017 1 commit
-
-
Jan Lindström authored
After review cleanup.
-
- 27 Sep, 2017 6 commits
-
-
Daniel Bartholomew authored
-
Sergei Golubchik authored
fix some old bad merge
-
Sergei Golubchik authored
-
Sergei Golubchik authored
avoid a function call for a commonly used one-liner. followup for 0627929f
-
Sergei Golubchik authored
remove copy-pasted code, fix meaningless comparison. followup for ea2162b6
-
Sachin Setiya authored
Problem:- This crash happens because of thd = NULL , and while checking for wsrep_on , we no longer check for thd != NULL (MDEV-7955). So this problem is regression of MDEV-7955. However this patch not only solves this regression , It solves all regression caused by MDEV-7955 patch. To get all possible cases when thd can be null , assert(thd)/ assert(trx->mysql_thd) is place just before all wsrep_on and innodb test suite is run. And the assert which caused failure are removed with a physical check for thd != NULL. Rest assert are removed. Hopefully this method will remove all current/potential regression of MDEV-7955.
-
- 25 Sep, 2017 3 commits
-
-
Daniel Bartholomew authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 24 Sep, 2017 3 commits
-
-
Varun Gupta authored
The issue was that r_loops, r_rows and r_filtered in ANALYZE FORMAT= JSON were not calculated for the table on which we were performing the MRR scan in the BKA join Fixed this by adding respective counter in the JOIN_TAB_SCAN_MRR::open and JOIN_TAB_SCAN_MRR::next
-
Varun Gupta authored
The problem is there is an overflow for the key_file_length. Added the maximum limit for the key_file_length
-
Marko Mäkelä authored
The ALTER TABLE…IMPORT TABLESPACE adjustment code that was introduced by WL#5522 in MySQL 5.6 is incorrectly invoking rec_get_status() on a ROW_FORMAT=REDUNDANT record to determine if a record is a leaf page record. The function rec_get_status(rec) is only to be called on ROW_FORMAT=COMPACT, DYNAMIC or COMPRESSED records.
-
- 23 Sep, 2017 1 commit
-
-
Vladislav Vaintroub authored
-
- 22 Sep, 2017 4 commits
-
-
Elena Stepanova authored
-
Sergei Golubchik authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
log_group_read_log_seg(): Only display the message during recovery, not during normal operation. When the XtraDB configuration parameter innodb_log_archive is set, this function will be called during normal operation.
-
- 21 Sep, 2017 10 commits
-
-
Sergei Golubchik authored
don't do it via MYSQL_TIME, that conversion is lossy around DST change dates.
-
Sergei Golubchik authored
Implement a special Copy_field method for timestamps, that copies timestamps without converting them to MYSQL_TIME (the conversion is lossy around DST change dates).
-
Sergei Golubchik authored
libmariadbclient_18 version nodes, specially for debian builds
-
Sergei Golubchik authored
-
Sergei Golubchik authored
followup for 378beed0 - only count WARN_LEVEL_ERROR, not warnings or notes.
-
Sergei Golubchik authored
tabtyp was defined under ODBC_SUPPORT, but used outside of it too (under JDBC_SUPPORT).
-
Marko Mäkelä authored
-
Sergei Golubchik authored
don't prepare for checking view's CHECK OPTION, if there is no CHECK OPTION in the first place.
-
Sachin Setiya authored
Binlog_background_thread does not make a call to set_time(), And when we call binlog_checkpoint_log_event->write() , we write the wrong timestamp. In this patch we correct this by calling thd->set_time().
-
sachin authored
Problem:- To create file in /tmp dir mysqld require permission initrc_tmp_t. And mysqld does not have his permission. Solution:- Instead of giving mysqld permission of initrc_tmp_t , we redirected log to file in /tmp dir through shell. I also removed a earlier workarround in mysqld_safe.sh , which create tmp log file in datadir.
-
- 20 Sep, 2017 5 commits
-
-
Sergei Golubchik authored
MDEV-13290: Assertion Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' or `! is_set()' failed followup for 97c2a735 - don't use thd->is_error(), the error could've been set before TABLE_LIST::cleanup_items. Use the error handler to count errors. This fixes rpl.rpl_row_binlog_max_cache_size - it was failing when ER_STMT_CACHE_FULL happened duing multi-table update. Because multi_update::abort_result_set() calls do_updates() to update as much as possible, so one cannot rely on thd->is_error() after that.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
disable Mongo in 10.0, compiler warnings.
-
Sergei Golubchik authored
-
Vicențiu Ciorbaru authored
-