1. 02 Aug, 2007 1 commit
  2. 31 Jul, 2007 1 commit
    • unknown's avatar
      BUG#29152 - INSERT DELAYED does not use concurrent_insert on slave · 8018d6ac
      unknown authored
      INSERT DELAYED on a replication slave was converted to regular INSERT,
      whereas it should try concurrent INSERT first.
      
      With this patch we try to convert delayed insert to concurrent insert on
      a replication slave. If it is impossible for some reason, we fall back to
      regular insert.
      
      No test case for this fix. I do not see anything indicating this is
      regression - we behave this way since Nov 2000.
      
      
      sql/sql_insert.cc:
        If we're executing INSERT DELAYED on a replication slave, we're upgrading
        lock type to TL_WRITE as we need to ensure serial execution of queries on
        the slave.
        
        OTOH if we're executing regular INSERT on a replication slave, we're
        trying TL_WRITE_CONCURRENT_INSERT first, and if we may not use it, we
        fall back to TL_WRITE.
        
        Fixed INSERT DELAYED on a replication slave to behave the same way as
        regular INSERT, that is to try TL_WRITE_CONCURRENT_INSERT first.
      8018d6ac
  3. 28 Jul, 2007 3 commits
  4. 27 Jul, 2007 3 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.0-engines · f97155c9
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.1-engines
      
      
      storage/myisam/mi_extra.c:
        Auto merged
      mysql-test/r/alter_table.result:
        Manual merge
      mysql-test/t/alter_table.test:
        Manual merge
      f97155c9
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 766725c5
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG29957/mysql-5.0-engines
      
      
      766725c5
    • unknown's avatar
      BUG#29957 - alter_table.test fails · e92ce5d5
      unknown authored
      INSERT/DELETE/UPDATE followed by ALTER TABLE within LOCK TABLES
      may cause table corruption on Windows.
      
      That happens because ALTER TABLE writes outdated shared state
      info into index file.
      
      Fixed by removing obsolete workaround.
      
      Affects MyISAM tables on Windows only.
      
      
      myisam/mi_extra.c:
        On windows when mi_extra(HA_EXTRA_PREPARE_FOR_DELETE) is called,
        we release external lock and close index file. If we're in LOCK
        TABLES, MyISAM state info doesn't get updated until UNLOCK TABLES.
        
        That means when we release external lock and we're in LOCK TABLES,
        we may write outdated state info.
        
        As SQL layer closes all table instances, we do not need this
        workaround anymore.
      mysql-test/r/alter_table.result:
        A test case for BUG#29957.
      mysql-test/t/alter_table.test:
        A test case for BUG#29957.
      e92ce5d5
  5. 26 Jul, 2007 8 commits
  6. 25 Jul, 2007 10 commits
    • unknown's avatar
      table.cc, sql_select.cc: · ddd72899
      unknown authored
        Post-merge fix.
      
      
      sql/sql_select.cc:
        Post-merge fix.
      sql/table.cc:
        Post-merge fix.
      ddd72899
    • unknown's avatar
      sql_select.cc: · c5948832
      unknown authored
        Post-merge fix.
      
      
      sql/sql_select.cc:
        Post-merge fix.
      c5948832
    • unknown's avatar
      Bug#29522 · b37ca18a
      unknown authored
        "log.cc:1448: failed assertion `mysql_bin_log.is_open() && rex_data->empty()'"
        When Federated's transaction support was disabled by bug29875,
        this assertion became unreproducable.
      
      
      mysql-test/t/disabled.def:
        bug29522
          reenable federated_innodb test
      b37ca18a
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0 · 2df3b7b0
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      mysql-test/t/create.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      mysql-test/r/create.result:
        Merge with 5.0 (main).
      2df3b7b0
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 21b83ab7
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      mysql-test/r/having.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/having.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Merge with 5.0-opt.
      mysql-test/r/create.result:
        Merge with 5.0-opt.
      mysql-test/r/innodb_mysql.result:
        Merge with 5.0-opt.
      mysql-test/r/type_enum.result:
        Merge with 5.0-opt.
      mysql-test/t/type_enum.test:
        Merge with 5.0-opt.
      sql/filesort.cc:
        Merge with 5.0-opt.
      sql/sql_base.cc:
        Merge with 5.0-opt.
      sql/table.cc:
        Merge with 5.0-opt.
      storage/innobase/handler/ha_innodb.cc:
        Merge with 5.0-opt.
      21b83ab7
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25679.3 · c6a0b224
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25679.3.merge-5.1
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      storage/federated/ha_federated.h:
        Auto merged
      storage/federated/ha_federated.cc:
        manual merge 5.0 to 5.1
      c6a0b224
    • unknown's avatar
      Bug#25679 · b42247bc
      unknown authored
        "Federated Denial of Service"
        Federated storage engine used to attempt to open connections within
        the ::create() and ::open() methods which are invoked while LOCK_open
        mutex is being held by mysqld. As a result, no other client sessions
        can open tables while Federated is attempting to open a connection.
        Long DNS lookup times would stall mysqld's operation and a rogue
        connection string which connects to a remote server which simply
        stalls during handshake can stall mysqld for a much longer period of
        time.
        This patch moves the opening of the connection much later, when the
        federated actually issues queries, by which time the LOCK_open mutex is
        no longer being held.
      
      
      mysql-test/r/federated.result:
        change of test/results due to patch for bug25679
      mysql-test/t/federated.test:
        change of test/results due to patch for bug25679
      sql/ha_federated.cc:
        bug25679
          remove function check_foreign_fata_source()
          ha_federated::open() no longer opens the federated connection.
          ha_federated::create() no longer opens and tests connection.
          ha_federated::real_connect() opens connection and tests presence of table.
          ha_federated::real_query() sends query, calling real_connect() if neccessary.
      sql/ha_federated.h:
        bug25679
          new methods real_query() and real_connect()
      b42247bc
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/4.1-opt · 0784d924
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      0784d924
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.1-engines · 34864af8
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG29806/mysql-5.1-engines
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/lock.cc:
        Auto merged
      34864af8
    • unknown's avatar
      BUG#29806 - binlog_innodb.test creates a server log · 4537a0c9
      unknown authored
      Stopping mysql server could result in an entry in mysql error
      file: "InnoDB: Error: MySQL is freeing a thd".
      
      This happened because InnoDB assumes that the server will never
      call external_lock(F_UNLCK) in case external_lock(READ/WRITE)
      failed.
      
      Prior to this patch we haven't had strict definition whether
      external_lock(F_UNLCK) must be called in case external_lock(READ/WRITE)
      fails.
      
      This patch states that we never call external_lock(F_UNLCK) in case
      external_lock(READ/WRITE) fails.
      
      
      mysql-test/suite/binlog/t/disabled.def:
        Re-enabled binlog_innodb and binlog_killed tests.
      sql/ha_ndbcluster.cc:
        Restore handler state in case external_lock() failed.
      sql/ha_partition.cc:
        Do not call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed.
      sql/lock.cc:
        Do not call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed.
      storage/myisammrg/myrg_locking.c:
        Restore handler state in case external_lock() failed.
      4537a0c9
  7. 24 Jul, 2007 14 commits
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · 6d0e3441
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      6d0e3441
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 8ed01f83
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      8ed01f83
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 2a7d2030
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      2a7d2030
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 607ab14c
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.0-runtime
      
      
      607ab14c
    • unknown's avatar
      Merge... · 8a159e38
      unknown authored
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
      
      
      
      8a159e38
    • unknown's avatar
      fix compile on Windows for bug25714.c · 5415dcc3
      unknown authored
      ---
      fix compile on Windows for bug25714.c
      
      
      tests/bug25714.c:
        fix compile on Windows
      5415dcc3
    • unknown's avatar
      build bug25714 test app on Windows · 791eee3e
      unknown authored
      791eee3e
    • unknown's avatar
      Merge... · e6b02976
      unknown authored
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
      
      
      BitKeeper/deleted/.del-CMakeLists.txt~5:
        Auto merged
      e6b02976
    • unknown's avatar
      build bug25714 test app on Windows · 4ab0c0cf
      unknown authored
      4ab0c0cf
    • unknown's avatar
      Merge... · 9097da00
      unknown authored
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
      
      
      
      9097da00
    • unknown's avatar
      post 5.0 to 5.1 merge fixes · 541e40f9
      unknown authored
      541e40f9
    • unknown's avatar
      Bug#15130: CREATE .. SELECT was denied to use advantages of the SQL_BIG_RESULT. · c4d53e31
      unknown authored
      When the SQL_BIG_RESULT flag is specified SELECT should store items from the
      select list in the filesort data and use them when sending to a client.
      The get_addon_fields function is responsible for creating necessary structures
      for that. But this function was allowed to do so only for SELECT and
      INSERT .. SELECT queries. This makes the SQL_BIG_RESULT useless for
      the CREATE .. SELECT queries.
      
      Now the get_addon_fields allows storing select list items in the filesort
      data for the CREATE .. SELECT queries.
      
      
      mysql-test/t/create.test:
        Added a test case for the bug#15130: CREATE .. SELECT was denied to use
        advantages of the SQL_BIG_RESULT.
      mysql-test/r/create.result:
        Added a test case for the bug#15130: CREATE .. SELECT was denied to use
        advantages of the SQL_BIG_RESULT.
      sql/filesort.cc:
        Bug#15130: CREATE .. SELECT was denied to use advantages of the SQL_BIG_RESULT.
        Now the get_addon_fields allows storing select list items in the filesort
        data for the CREATE .. SELECT queries.
      c4d53e31
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25714.1 · e1b3b931
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25714.1.merge-5.1
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      tests/Makefile.am:
        Auto merged
      storage/federated/ha_federated.cc:
        manual merge from 5.0 to 5.1
      e1b3b931
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25714.1 · 594d71a4
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25714.1.merge-5.0
      
      
      594d71a4