1. 13 Apr, 2022 2 commits
    • Sergei Golubchik's avatar
      MDEV-27767 poor scaling with InnoDB and utf8mb3 because of charset stats · fc839644
      Sergei Golubchik authored
      Access the all_charsets[] array directly in a hot loop.
      This avoids get_charset() that increments a shared counter via
      my_collation_statistics_inc_use_count(), causing a scalability issue.
      
      Instead, call get_charset() when a table is opened (and InnoDB
      fills in dtype_t values) - this is enough, as charset is marked
      ready (MY_CS_READY) only once, on the first get_charset() call,
      after that it can be accessed directly.
      
      This also fixes a potential bug in InnoDB. It used to access charsets
      directly when filling dtype_t values. This wasn't preceded by any
      get_charset() call inside InnoDB. Normally the server would call
      get_charset() on reading the frm, but if the table was first opened
      from a purge thread InnoDB could, theoretically, access a not-ready
      charset in innobase_get_cset_width().
      fc839644
    • Oleksandr Byelkin's avatar
      MDEV-28266 Crash in Field_string::type_handler when calling procedures · 5615a78a
      Oleksandr Byelkin authored
      on_table_fill_finished() should always be done at the end of open()
      even if result is not Select_materialize but (for example)
      Select_fetch_into_spvars.
      5615a78a
  2. 12 Apr, 2022 4 commits
  3. 11 Apr, 2022 4 commits
  4. 10 Apr, 2022 2 commits
  5. 09 Apr, 2022 2 commits
  6. 08 Apr, 2022 1 commit
    • Nayuta Yanagisawa's avatar
      MDEV-27239 Spider: Assertion `thd->transaction->stmt.ha_list == __null ||... · d8463b64
      Nayuta Yanagisawa authored
      MDEV-27239 Spider: Assertion `thd->transaction->stmt.ha_list == __null || trans == &thd->transaction->stmt' failed in ha_commit_trans on BEGIN WORK after FTWRL
      
      The check on the SQL command type, in ha_spider::external_lock() is deleted
      by e954d9de. This resulted in the wrong call of spider_internal_start_trx()
      (and thus Ha_trx_info::register_ha()).
      
      I reverted the check and refactored ha_spider::external_lock().
      d8463b64
  7. 07 Apr, 2022 9 commits
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 6645b1d2
      Marko Mäkelä authored
      6645b1d2
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 7b957316
      Marko Mäkelä authored
      7b957316
    • Daniel Black's avatar
      deb: make --output-sync=target · dea4e178
      Daniel Black authored
      Rather than Debian logs containing a barely decipherable mix
      of build command and the output of some other command, we
      use the make option --output-sync=target. This make the compile
      line and the output stay together in the output stream.
      
      This option exists even in the make version in debian;stretch
      so should work everywhere.
      
      Test on debian:stretch, ubuntu:18.04, the two lowest version that
      use the debian/rules.
      dea4e178
    • Daniel Black's avatar
      MDEV-28153: Debian autobake to generate control · 8990ffe6
      Daniel Black authored
      Without doing the full build.
      
      Autobake now includes a dependency on lsb-release.
      
      As the BB CI images
      (https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/ci_build_images/debian.Dockerfile)
      have explicit dependencies, there's no point maintaining them in
      two places. We don't want do the full autobake-deb.sh there, just enough
      to have the control file containing the correct dependencies.
      
      Helps: https://github.com/MariaDB/mariadb.org-tools/pull/130
      8990ffe6
    • Jan Lindström's avatar
      MDEV-28247 : Disable background ibuf merge during Galera SST · 3c99a48d
      Jan Lindström authored
      This failure was caused by MDEV-25975, which removed the parameter
      innodb_disallow_writes.
      
      Added a check for wsrep_sst_disable_writes to the function
      ibuf_merge_in_background().
      3c99a48d
    • Daniel Black's avatar
      MDEV-28250 aix test case failure innodb_zip.innochecksum_3,4k,crc32,innodb · 4ee00a29
      Daniel Black authored
      As discovered by tracing, but also presenting in AIX fseeko
      documentation, seeking beyond the EOF is acceptable, as you can write
      there.
      
      To display the same error in AIX to other implementations that return
      errors on seek, we take the EFBIG error code on reading and error the
      same way.
      
      An AIX truss of an aspect of the test:
      
      truss extra/innochecksum --page=18446744073709551615 $MYSQLD_DATADIR/test/tab1.ibd
      
        statx("./mysql-test/var/log/innodb_zip.innochecksum_3-4k,crc32,innodb/mysqld.1/data//test/tab1.ibd", 0x0FFFFFFFFFFFF610, 176, 010) = 0
        kopen("./mysql-test/var/log/innodb_zip.innochecksum_3-4k,crc32,innodb/mysqld.1/data//test/tab1.ibd", O_RDONLY|O_LARGEFILE) = 3
        kfcntl(3, 12, 0x00000001100006C8)               = 0
        kfcntl(3, F_GETFL, 0x00000001100A6CF8)          = 67108864
        kioctl(3, 22528, 0x0000000000000000, 0x0000000000000000) Err#25 ENOTTY
        klseek(3, 0, 1, 0x0FFFFFFFFFFFF3F0)             = 0
        kioctl(3, 22528, 0x0000000000000000, 0x0000000000000000) Err#25 ENOTTY
        kread(3, "DEADBEEF\0\0\0\0FFFFFFFF".., 4096)    = 4096
        klseek(3, 0, 1, 0x0FFFFFFFFFFFF450)             = 0
        klseek(3, 17592186040320, 0, 0x0FFFFFFFFFFFF450) = 0
        klseek(3, 0, 1, 0x0FFFFFFFFFFFF3F0)             = 0
        kread(3, "DEADBEEF\0\0\0\0FFFFFFFF".., 4096)    Err#27 EFBIG
      
      An equivalent Linux trace:
      
      ltrace extra/innochecksum --page=18446744073709551615 $MYSQLD_DATADIR/test/tab1.ibd
      
        stat64(0x7fff10ea2dc3, 0x7fff10ea0670, 88, 0x8026be41)         = 0
        open64("./mysql-test/var/log/innodb_zip."..., 0, 02072403160)  = 3
        fcntl64(3, 6, 0x139f180, 1)                                    = 0
        fgetpos64(0x615000000080, 0x7fff10ea0760, 1, 0)                = 0
        fseeko64(0x615000000080, 0xffffffff000, 0, 5 <unfinished ...>
        pthread_getspecific(0, 0x4d0eb8, 0x7fff10ea0490, 0)            = 0x7f7b2806d000
        <... fseeko64 resumed> )                                       = 0
        fgetpos64(0x615000000080, 0x7fff10ea0760, 1, 1)                = 0
        feof(0x615000000080)                                           = 0
        feof(0x615000000080)                                           = 1
        Error: Unable to seek to necessary offset
      4ee00a29
    • Daniel Black's avatar
      e84e134a
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-27783 InnoDB: Failing assertion: table->get_ref_count() == 0 upon ALTER... · 27b0030b
      Thirunarayanan Balathandayuthapani authored
      MDEV-27783 InnoDB: Failing assertion: table->get_ref_count() == 0 upon ALTER TABLE ... MODIFY COLUMN
      
      - There is a race condition occurs between purge thread and DDL.
      So purge thread can increment n_ref_count even after DDL does
      purge_sys_t::stop_FTS().
      
      - dict_table_open_on_id for purge thread should check
      purge_sys.must_wait_FTS() before acquring the table.
      
      - purge_sys.stop_FTS() does acquire dict_sys.latch for setting
      the purge system flag and check table ref count on auxilary tables.
      27b0030b
    • Alexander Barkov's avatar
  8. 06 Apr, 2022 14 commits
  9. 05 Apr, 2022 2 commits
    • Dmitry Shulga's avatar
      MDEV-21173: Assertion `m_thd == __null' failed in sp_head::~sp_head · f6b09a7c
      Dmitry Shulga authored
      Some SQL statements that involves subqueries or stored routines could
      fail since execution of subqueries or stored routines is not supported
      for theses statements. Unfortunately, parsing error could result in
      abnormal termination by firing the following assert
        DBUG_ASSERT(m_thd == NULL);
      in a destructor of the class sp_head.
      
      The reason of the assert firing is that the method
        sp_head::restore_thd_mem_root()
      is not called on semantic action code to clean up resources allocated
      during parsing. This happens since the macros YYABORT is called instead of
      MYSQL_YYABORT by semantic action code for some grammar rules.
      
      So, to fix the bug YYABORT was just replaced with MYSQL_YYABORT.
      f6b09a7c
    • Sergei Golubchik's avatar
      MDEV-27673 Warning after "select progress from information_schema.processlist" · 2d2c3da8
      Sergei Golubchik authored
      after moving fields in optimize_schema_tables_memory_usage()
      store default values into their new, moved, locations.
      2d2c3da8