1. 21 May, 2011 1 commit
  2. 20 May, 2011 1 commit
  3. 19 May, 2011 4 commits
    • Sergei Golubchik's avatar
      microseconds in log tables: · 7ffb5249
      Sergei Golubchik authored
        TIMESTAMP -> TIMESTAMP(6)
        TIME -> TIME(6)
      in general_log and slow_log tables.
      
      include/my_sys.h:
        use constants
      7ffb5249
    • Sergei Golubchik's avatar
      post review changes 2 · d0fae754
      Sergei Golubchik authored
      sql/event_parse_data.cc:
        don't use "not_used" variable
      sql/item_timefunc.cc:
        Item_temporal_func::fix_length_and_dec()
        and other changes
      sql/item_timefunc.h:
        introducing Item_timefunc::fix_length_and_dec()
      sql/share/errmsg.txt:
        don't say "column X" in the error message that used not only for columns
      d0fae754
    • Sergei Golubchik's avatar
      many changes to my_getsystime.c: · 90b1a385
      Sergei Golubchik authored
      * my_getsystime() is only an interval timer. Its value can beused for calculating
        time intervals.
      * renamed my_getsystime() to my_interval_timer(), to make the semantics
        clearer and let the compiler catch wrong usages of my_getsystime()
        (also future ones, that may come in merges).
      * increased its granularity from 100ns to 1ns, old value was for UUID,
        but as UUID can no longer use it directly there is no need to downgrade
        the OS provided value
      * fixed the UUID code to anchor the my_interval_timer() on the epoch, as
        required by the UUID standard. That is, this was only needed by UUID,
        and now I've moved it to UUID code from my_getsystime().
      * fixed other wrong usages of my_getsystime() - e.g. in calculating
        times for pthread_cond_timedwait. It was buggy and could've caused
        long waits if OS clock would be changed.
      90b1a385
    • Sergei Golubchik's avatar
      post-review changes 1 · 404928b9
      Sergei Golubchik authored
      include/my_time.h:
        remove duplicate defines.
        cast to ulonglong to avoid overflow
      sql/field.cc:
        perform sign extension when reading packed TIME values
      sql/item_cmpfunc.cc:
        when converting a string to a date for the purpose of comparing it with another date,
        we should ignore strict sql mode.
      sql/item_timefunc.cc:
        better error message
      sql/item_timefunc.h:
        limit decimals appropriately
      sql/share/errmsg.txt:
        don't refer to an object as a "column" in error messages that are used not only for columns.
      404928b9
  4. 19 Apr, 2011 1 commit
  5. 18 Apr, 2011 1 commit
  6. 03 Apr, 2011 1 commit
  7. 29 Mar, 2011 1 commit
  8. 28 Mar, 2011 1 commit
  9. 26 Mar, 2011 1 commit
  10. 24 Mar, 2011 3 commits
    • Sergei Golubchik's avatar
      fixes for funcs_1 suite · fb5850c0
      Sergei Golubchik authored
      fb5850c0
    • Vladislav Vaintroub's avatar
      merge · fd29195e
      Vladislav Vaintroub authored
      fd29195e
    • Vladislav Vaintroub's avatar
      Fix compilation on Windows: · e5591e3e
      Vladislav Vaintroub authored
      - Fixes for type-conversion
        (time_t   is not interchangeable  with  my_time_t on Windows as time_t s 64 bit while my_time_t is long)
      - BIGENDIAN-> ARCH_BIGENDIAN . 
        BIGENDIAN constant  is defined in winsock2.h (as 0)
      - added explicit cast for longlong->double conversion in sql/item.h  (fixed many warnings) 
      
      Also, HAVE_SNPRINTF is now defined and snprintf is defined to _snprintf in config-win.h
      e5591e3e
  11. 23 Mar, 2011 3 commits
  12. 19 Mar, 2011 3 commits
  13. 18 Mar, 2011 6 commits
  14. 17 Mar, 2011 6 commits
  15. 09 Mar, 2011 2 commits
  16. 08 Mar, 2011 3 commits
    • Sergei Golubchik's avatar
      lp:731229 Different results depending on table access method with TIME column and CURDATE() · 862c42dd
      Sergei Golubchik authored
      issue a warning when a datetime is truncated for storing in a TIME column.
      this automatically prevents optimizer from using indexes when comparing time column to a datetime
      862c42dd
    • Sergei Golubchik's avatar
      lp:731124 Loss of precision on DISTINCT · edad8ed9
      Sergei Golubchik authored
      many changes:
      * NOT_FIXED_DEC now create hires fields, not old ones.
        As a result, temp tables preserve microseconds (on DISTINCT, GROUP BY)
      * I_S tables force decimals=0 on temporal types (backward compatibility)
      * Item_func_coalesce calculates decimals for temporal types
      * no precision for TIME/DATETIME in CAST means 0, not NOT_FIXED_DEC
      * addtime/timediff calculate decimals from arguments (not NOT_FIXED_DEC)
      
      sql/field.h:
        NOT_FIXED_DEC now create hires fields, not old ones
      sql/item.h:
        force decimals=0 for I_S tables
      sql/item_cmpfunc.cc:
        Item_func_coalesce calculates decimals for temporal types
      sql/item_create.cc:
        no precision for TIME/DATETIME in CAST means 0, not NOT_FIXED_DEC
      sql/item_timefunc.cc:
        addtime calculates decimals from arguments (not NOT_FIXED_DEC)
      sql/item_timefunc.h:
        timediff calculates decimals from arguments (not NOT_FIXED_DEC)
      edad8ed9
    • Sergei Golubchik's avatar
      lp:731103 Assertion `maybe_null && item->null_value' failed with ORDER BY LAST_DAY() · 3c110d49
      Sergei Golubchik authored
      Item_func_last_day did not set mayby_null=1
      3c110d49
  17. 07 Mar, 2011 2 commits
    • Sergei Golubchik's avatar
      followup for lp:730637 · dc72037a
      Sergei Golubchik authored
      mysql-test/t/func_time.test:
        fixed wrong test case
      sql-common/my_time.c:
        negative datetime is invalid.
        fix check_date() to reflect that.
      dc72037a
    • Sergei Golubchik's avatar
      lp:730637 - Valgrind warnings in 5.1-micro · 5c8cbba3
      Sergei Golubchik authored
      sql/field.cc:
        initialize ltime completely
      sql/filesort.cc:
        don't pack MYSQL_TIME if it's not initialized
        (safe here, but valgrind complains)
      sql/item_cmpfunc.cc:
        don't pack MYSQL_TIME if it's not initialized
        (safe here, but valgrind complains)
      sql/item_timefunc.cc:
        don't check MYSQL_TIME members if it's uninitialized
        (safe here, but valgrind complains)
      sql/time.cc:
        use c_ptr_safe() instead of c_ptr()
        (make valgrind happy)
      5c8cbba3