1. 20 Sep, 2006 4 commits
    • marko's avatar
      branches/zip: Instrument the buffer pool allocator and deallocator · ff0acd76
      marko authored
      for more accurate Valgrind debugging.
      
      univ.i: Introduce UNIV_DEBUG_VALGRIND, UNIV_MEM_VALID, and UNIV_MEM_INVALID.
      
      buf_LRU_block_free_non_file_page(): Invalidate the buffer frame
      with UNIV_MEM_INVALID().
      
      buf_LRU_get_free_block(): Declare the buffer frame valid
      with UNIV_MEM_VALID().
      
      Other memory is allocated and deallocated via malloc() and free(),
      which are already overridden by Valgrind.  Without the added
      instrumentation, accesses to free pages in the buffer pool cannot
      be caught.
      
      The diagnostics could probably be improved further by declaring all
      non-latched buffer frames invalid.
      ff0acd76
    • marko's avatar
      branches/zip: Fix bugs #ifdef UNIV_DEBUG. · 3b03315f
      marko authored
      rec_convert_dtuple_to_rec_old(): Initialize the record in order to avoid
      bogus Valgrind warnings about the ut_ad() in mach_write_to_1() and
      mach_write_to_2().
      
      page_zip_compress(), page_zip_write_rec(), page_zip_write_blob_ptr():
      Replace ut_ad(page_validate(...)) with ut_ad(page_simple_validate_new(...)),
      because otherwise crash recovery would fail.
      3b03315f
    • marko's avatar
      branches/zip: fil_create_new_single_table_tablespace(): · a169d0ec
      marko authored
      Make page_zip->data point to an address different from page,
      to avoid calling memcpy() with overlapping source and destination.
      a169d0ec
    • marko's avatar
      branches/zip: mlog_parse_index(): After merge fix (r841): · 2af802d8
      marko authored
      Identify DB_TRX_ID and DB_ROLL_PTR in the index.
      2af802d8
  2. 19 Sep, 2006 2 commits
  3. 12 Sep, 2006 1 commit
  4. 06 Sep, 2006 2 commits
  5. 05 Sep, 2006 3 commits
  6. 04 Sep, 2006 2 commits
  7. 31 Aug, 2006 2 commits
  8. 29 Aug, 2006 2 commits
  9. 22 Aug, 2006 1 commit
  10. 21 Aug, 2006 6 commits
    • marko's avatar
      branches/zip: Speed up the compression and decompression of leaf pages · 1180ce98
      marko authored
      of non-clustered indexes.  On these pages, only the bytes rec[-5..-1]
      will be omitted from the compressed data stream.  Save time by not looking
      for trx_id or externally stored columns.
      1180ce98
    • marko's avatar
      branches/zip: Assert that only leaf pages of clustered indexes may contain · fb8ce599
      marko authored
      externally stored columns.  Make some use of the fact in compression and
      decompression.
      
      rec_init_offsets(): Add ut_ad(dict_index_is_clust(index)) before flagging
      external columns.
      
      page_zip_get_trailer_len(): Assert ut_ad(!page_zip->n_blobs) unless
      dict_index_is_clust(index).
      
      page_zip_get_n_prev_extern(): Add ut_ad(dict_index_is_clust(index)).
      
      page_zip_compress(), page_zip_decompress_low(): Add dict_index_is_clust()
      assertions.  Allow completely external storage of columns.  Simplify
      the computation of "externs".
      
      page_zip_write_rec(): Store leaf node records of non-clustered indexes
      with one memcpy(), avoiding rec_offs_n_extern() and the for loop.
      
      page_zip_write_blob_ptr(): Add ut_ad(dict_index_is_clust(index)).
      Simplify the computation of "externs".
      
      page_zip_clear_rec(): Only attempt to zero out BLOB pointers when
      the record belongs to a leaf page of a clustered index.
      
      page_zip_dir_delete(): Take a fast path when the record is
      not on a leaf page of a clustered index.
      Simplify the computation of "externs".
      
      page_zip_copy(): Assert that n_blobs is zero on anything else than
      leaf pages of clustered indexes.
      fb8ce599
    • marko's avatar
      branches/zip: page_zip_fields_decode(): Set index->type to DICT_CLUSTERED · 2f08aceb
      marko authored
      if and only if the records on the page contain a trx_id column.
      (Dummy indexes of non-leaf pages will always show up as non-clustered.)
      2f08aceb
    • marko's avatar
    • marko's avatar
      branches/zip: page_zip_decompress(): Initialize page_zip->n_blobs before · 3a27b5c8
      marko authored
      referencing it, to prevent a ut_ad() assertion on page_zip_get_trailer_len()
      from failing.  Promote that assertion to ut_a().
      3a27b5c8
    • marko's avatar
      branches/zip: dtuple_convert_big_rec(): Do not attempt to shorten records · a9e75e63
      marko authored
      of secondary indexes.  (This is just an optimization; the logic in the
      search loop would never store such records externally.)
      a9e75e63
  11. 18 Aug, 2006 3 commits
  12. 17 Aug, 2006 3 commits
  13. 16 Aug, 2006 1 commit
    • marko's avatar
      branches/zip: Clean up debug code. · 41468be9
      marko authored
      struct mtr_struct: Omit unused field "state" unless #ifdef UNIV_DEBUG.
      
      buf_block_buf_fix_inc_debug(): Remove redundant __attribute__((unused))
      and #ifdef UNIV_SYNC_DEBUG.
      41468be9
  14. 15 Aug, 2006 5 commits
  15. 14 Aug, 2006 1 commit
  16. 11 Aug, 2006 1 commit
  17. 10 Aug, 2006 1 commit