1. 05 Apr, 2004 2 commits
  2. 04 Apr, 2004 3 commits
    • unknown's avatar
      Merge paul@bk-internal.mysql.com:/home/bk/mysql-4.1 · f8b790d0
      unknown authored
      into ice.snake.net:/Volumes/ice2/MySQL/bk/mysql-4.1
      
      
      f8b790d0
    • unknown's avatar
      Minor tweaks to help message of obscure script. · 62d516fa
      unknown authored
      62d516fa
    • unknown's avatar
      removed old way to prevent using stack tables for caching Items in PS · 3c01162f
      unknown authored
      fixed error code in union test
      
      
      mysql-test/t/union.test:
        right code worr 4.1 error
      sql/log_event.cc:
        assign non-cachable for Item status for all stack tables for safety
      sql/repl_failsafe.cc:
        assign non-cachable for Item status for all stack tables for safety
      sql/slave.cc:
        assign non-cachable for Item status for all stack tables for safety
      sql/sql_acl.cc:
        assign non-cachable for Item status for all stack tables for safety
      sql/sql_base.cc:
        assign non-cachable for Item status for all stack tables for safety
        non-cachable status processing
      sql/sql_cache.cc:
        assign non-cachable for Item status for all stack tables for safety
      sql/sql_class.cc:
        removed ald way to prevent using stack tables for caching Items in PS
      sql/sql_class.h:
        removed old way to prevent using stack tables for caching Items in PS
      sql/sql_help.cc:
        assign non-cachable for Item status for all stack tables for safety
      sql/sql_insert.cc:
        assign non-cachable for Item status for all stack tables for safety
        removed old way to prevent using stack tables for caching Items in PS
      sql/table.h:
        non-cachable for Item status for tables
      3c01162f
  3. 03 Apr, 2004 5 commits
    • unknown's avatar
      Spanish and Portuguese translation. · 605872d5
      unknown authored
      
      sql/share/portuguese/errmsg.txt:
        Translation from English
      sql/share/spanish/errmsg.txt:
        Translation from English
      605872d5
    • unknown's avatar
      BUG#3328 · 27668046
      unknown authored
      I can't see group_concat_max_len in a list of variables
      
      
      sql/set_var.cc:
        add sys_group_concat_max_len.name
      27668046
    • unknown's avatar
      for Item_param we have to have value set instead of fave item fixed (BUG#3353) · e65aed9c
      unknown authored
      fixed outer joins
      test of different joins included
      
      
      sql/item.cc:
        for Item_param we have to have value set instead of fave item fixed
      sql/sql_base.cc:
        fixed PS with outer joins
      tests/client_test.c:
        test of different types of joins
      e65aed9c
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · d7c25fe2
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-on-4.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/table.h:
        Auto merged
      d7c25fe2
    • unknown's avatar
      fixed brocken of client_test · 8c8dffb6
      unknown authored
      fixed aggregate functions in PS (BUG#3360)
      
      
      mysql-test/r/union.result:
        4.1 more correct error
      sql/item_cmpfunc.h:
        and_conds do not make fix fields
      sql/item_sum.cc:
        storing/restoring argument of aggregate function for prepared statements
        restoring order list of group_concat for safety
      sql/item_sum.h:
        storing/restoring argument of aggregate function for prepared statements
        layout fix
      sql/mysql_priv.h:
        just declaration
      sql/sql_base.cc:
        fix_fields() have to be called with temporary memory pool active
      sql/sql_parse.cc:
        removed hack with item pointer storing
      sql/sql_prepare.cc:
        debug output added
        removed hack with item pointer storing
      sql/sql_select.cc:
        fix_fields now should be called separately
      sql/sql_union.cc:
        removed wrong merged check from 4.0 (4.1 have its own protection)
      sql/table.h:
        removed hack with item pointer storing
      tests/client_test.c:
        new test fo PS
      8c8dffb6
  4. 02 Apr, 2004 15 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1/ · 6b433f99
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.1
      
      
      sql/ha_myisam.cc:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/table.h:
        Auto merged
      6b433f99
    • unknown's avatar
      8abda715
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.1 · cdd20d72
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2385/mysql-4.1
      
      
      cdd20d72
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.1 · bf4849e8
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2385/mysql-4.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      bf4849e8
    • unknown's avatar
      made some optimization of last patch for · cee153b8
      unknown authored
      Bug #2385 "CREATE TABLE LIKE lacks locking on source and destination table" 
      (in sql_table.cc and mysql-test/t/synchronization.test)
      
      
      mysql-test/t/synchronization.test:
        added sleep to more reliable work
      sql/sql_table.cc:
        made some optimization of last patch for 
        Bug #2385 "CREATE TABLE LIKE lacks locking on source and destination table" 
        in mysql_create_like_table
      cee153b8
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.1 · 7a56a9a0
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_2397/mysql-4.1
      
      
      7a56a9a0
    • unknown's avatar
      correct test in trigger · b2cf48ab
      unknown authored
      b2cf48ab
    • unknown's avatar
      trying pre-delta trigger · 8c465501
      unknown authored
      8c465501
    • unknown's avatar
      a66fe8dc
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 69942b13
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_system_db_test/mysql-4.1
      
      
      69942b13
    • unknown's avatar
      remove obsolete (hopefully) files from Docs/ · 7c27065c
      unknown authored
      
      BitKeeper/deleted/.del-manual_toc.html~f483f2d33d9acb41:
        Delete: Docs/manual_toc.html
      BitKeeper/deleted/.del-manual.ja.texi~bdf63728a7b03acf:
        Delete: Docs/manual.ja.texi
      BitKeeper/deleted/.del-section.Infolinks.texi~c237f2f9:
        Delete: Docs/section.Infolinks.texi
      BitKeeper/deleted/.del-section.Testimonials.texi~418f3f63:
        Delete: Docs/section.Testimonials.texi
      BitKeeper/deleted/.del-section.Users.texi~41da5f4c:
        Delete: Docs/section.Users.texi
      7c27065c
    • unknown's avatar
      added newline to the end of mysql-test/t/system_mysql_db_fix-master.opt · dfe03f40
      unknown authored
      for working on aix and so on..
      
      
      mysql-test/t/system_mysql_db_fix-master.opt:
        added newline for working aix and so on..
      dfe03f40
    • unknown's avatar
      Merge miguel@bk-internal.mysql.com:/home/bk/mysql-4.1 · 6608ee4f
      unknown authored
      into hegel.local:/home/miguel/bk/mysql-4.1
      
      
      sql/mysqld.cc:
        Auto merged
      6608ee4f
    • unknown's avatar
      Added missing error message and corrected another one. · 619c2666
      unknown authored
      
      sql/share/swedish/errmsg.txt:
        Added missing error message swedish/errmsg.txt and corrected another one.
      619c2666
    • unknown's avatar
      WL#1266 "Separate auto-set logic from TIMESTAMP type." · 32b28f92
      unknown authored
      Final version of patch.
      
      Adds support for specifying of DEFAULT NOW() and/or ON UPDATE NOW()
      clauses for TIMESTAMP field definition.
      Current implementation allows only one such field per table and
      uses several unireg types for storing info about this properties of
      field. It should be replaced with better implementation when new
      .frm format is introduced.
      
      
      include/mysqld_error.h:
        Added error codes for case when we have more than one column with NOW()
        in DEFAULT or ON UPDATE clauses and for case when we are using ON UPDATE
        clause with wrong type.
      mysql-test/r/create.result:
        Added tests for using of DEFAULT NOW() and ON UPDATE NOW() with
        non-TIMESTAMP fields.
      mysql-test/r/show_check.result:
        Updated test results to reflect new default look of TIMESTAMP fields
        in SHOW CREATE TABLE.
      mysql-test/r/system_mysql_db.result:
        Updated test results to reflect new default look of TIMESTAMP fields
        in SHOW CREATE TABLE.
      mysql-test/r/type_ranges.result:
        Updated test results to reflect new default look of TIMESTAMP fields
        in SHOW COLUMNS.
      mysql-test/r/type_timestamp.result:
        Added tests for various DEFAULT and ON UPDATE clauses for TIMESTAMP
        fields definitions.
      mysql-test/t/create.test:
        Added tests for using of DEFAULT NOW() and ON UPDATE NOW() with
        non-TIMESTAMP fields.
      mysql-test/t/type_timestamp.test:
        Added tests for various DEFAULT and ON UPDATE clauses for TIMESTAMP
        fields definitions.
      sql/field.cc:
        Added support for various combinations of DEFAULT and ON UPDATE clauses
        for TIMESTAMP field. 
        
        Setting TABLE::timestamp* members for TIMESTAMP fields with auto-set 
        option taking into account their unireg type (which corresponds to 
        various DEFAULT/ON UPDATE values combinations). Replaced 
        TABLE::time_stamp with TABLE::timestamp_default_now/on_update_now
        couple moved their setup to separate method set_timestamp_offsets(),
        which now is called from  open_table instead of Field_timestamp cons.
      sql/field.h:
        Added more unireg types for handling of DEFAULT NOW() and ON UPDATE
        NOW() for TIMESTAMP fields.
        Fixed value corresponding to DEFAULT item for TIMESTAMP field.
      sql/ha_berkeley.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/ha_heap.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/ha_innodb.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/ha_isam.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/ha_isammrg.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/ha_myisam.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/ha_myisammrg.cc:
        Now TIMESTAMP column with auto-set property could be updated during
        INSERT or/and UPDATE independently.
      sql/item_func.h:
        We need to distinguish NOW() from other function for using in 
        DEFAULT and in ON UPDATE clauses.
      sql/item_timefunc.h:
        We need to distinguish NOW() from other function for using in 
        DEFAULT and in ON UPDATE clauses.
      sql/mysql_priv.h:
        Added parameter for ON UPDATE value to add_field_to_list() function.
      sql/share/czech/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/danish/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/dutch/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/english/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/estonian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/french/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/german/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/greek/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/hungarian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/italian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/japanese/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/korean/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/norwegian-ny/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/norwegian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/polish/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/portuguese/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/romanian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/russian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/serbian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/slovak/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/spanish/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/swedish/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/share/ukrainian/errmsg.txt:
        Added error messages for case when we have more than one column with
        NOW() (CURRENT_TIMESTAMP is just more standard alias) in DEFAULT or 
        ON UPDATE clauses and for case when we are using ON UPDATE clause with
        wrong type.
      sql/sql_base.cc:
        Added setup of TABLE::timestamp_default_now/on_update_now pair
        for each statement to open_table().
      sql/sql_insert.cc:
        Using TABLE::timestamp_default_now/on_update_now pair instead of
        old TABLE::time_stamp. Added check for case then REPLACE could not
        be converted to UPDATE because of different DEFAULT/ON UPDATE values
        for TIMESTAMP field.
      sql/sql_lex.h:
        Added member for value used in ON UPDATE clause to st_lex.
      sql/sql_load.cc:
        Using TABLE::timestamp_default_now/on_update_now pair instead of
        old TABLE::time_stamp. We don't need to restore these members
        since they are set up for each statement in open_table().
      sql/sql_parse.cc:
        Added handling of DEFAULT NOW() and ON UPDATE NOW() clauses for
        TIMESTAMP fields to add_field_to_list() function.
      sql/sql_show.cc:
        Added support for DEFAULT CURRENT_TIMESTAMP (aka NOW() ) and 
        ON UPDATE CURRENT_TIMESTAMP to SHOW CREATE TABLE and SHOW COLUMNS.
      sql/sql_table.cc:
        mysql_create_table() function - added check for number of TIMESTAMP 
          fields with auto-set values and replacing of old style TIMESTAMPs
          with their newer analogs.
        mysql_alter_table(): Using TABLE::timestamp_default_now/on_update_now 
          pair instead of old TABLE::time_stamp. We don't need to restore these
          members since they are set up for each statement in open_table().
      sql/sql_update.cc:
        Left only setting of TABLE::timestamp_default_now/on_update_now
        to 0 since they should be already set up in open_table().
      sql/sql_yacc.yy:
        Added support for DEFAULT NOW() and ON UPDATE NOW() in field
        definitions.
      sql/table.h:
        Replaced TABLE::time_stamp withTABLE::timestamp_default_now/timestamp_on_update_now
        pair which allows to distinguish TIMESTAMP's with various DEFAULT/ON UPDATE
        clauses and optimize checks if TIMESTAMP field should be set to NOW()
        in handlers.
      sql/unireg.cc:
        Now we are marking only TIMESTAMP fields with NOW() as default or
        as on update value as special field for unireg.
      32b28f92
  5. 01 Apr, 2004 9 commits
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · a62a5fc9
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-on-4.1
      
      
      a62a5fc9
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 382ece83
      unknown authored
      into jabberwock.localdomain:/home/dlenev/src/mysql-4.1-775
      
      
      382ece83
    • unknown's avatar
      WL#775 "Add status variable identifying binlog_cache_size shortage" · a58b351e
      unknown authored
      Added two status variables: 
        binlog_cache_use - counts number of transactions that used somehow
          transaction temporary binary log.
        binlog_cache_disk_use - counts number of transactions that required
          disk I/O for storing info in this this binary log.
      
      
      include/my_sys.h:
        Added disk_writes member to the IO_CACHE structure for counting number
        of times when IO_CACHE was forced to write to disk.
      mysql-test/r/rpl_relayrotate.result:
        Fixed test result since added test for binlog_cache_use and 
        binlog_cache_disk_use status variables.
      mysql-test/t/rpl_relayrotate.test:
        Added test for binlog_cache_use and binlog_cache_disk_use status 
        variables.
        Now dropping t1 table on master too.
      mysys/mf_iocache.c:
        Added disk_writes member to the IO_CACHE structure for counting number
        of times when IO_CACHE was forced to write to disk.
      sql/handler.cc:
        Added support for binlog_cache_use and binlog_cache_disk_use status
        variable. First one is incremented if transaction used somehow 
        transaction temporary binary log (doesn't matter in memory only or 
        with writes to disk), the second one is incremented if this binary 
        log was flushed to disk at some point.
      sql/mysql_priv.h:
        Added declaration of status variables binlog_cache_use and 
        binlog_cache_disk_use.
      sql/mysqld.cc:
        Added status variables binlog_cache_use and binlog_cache_disk_use.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      a58b351e
    • unknown's avatar
      removed unused field · d4074bbe
      unknown authored
      layout fised
      debug information added
      
      
      sql/item.cc:
        layout fix
        debug info
      sql/sql_class.h:
        removed unused field
      d4074bbe
    • unknown's avatar
      Fix for bug #3359. Bad named pipe name. · 987cd628
      unknown authored
      
      sql/mysqld.cc:
        Fix for bug #3359. Bad named pipe name
      987cd628
    • unknown's avatar
      added synchronization in mysql_create_like_table · f2116615
      unknown authored
      (
      fixed BUG #2385 CREATE TABLE LIKE lacks locking on source and destination table
      and added tests for it
      )
      
      
      sql/mysql_priv.h:
        added code TEST_SYNCHRONIZATION for --exit-info option
      sql/mysqld.cc:
        fixed -debug prefix
      sql/sql_table.cc:
        added synchronization in mysql_create_like_table
        (fixed BUG #2385 CREATE TABLE LIKE lacks locking on source and destination table)
      f2116615
    • unknown's avatar
      fixed · 9be599fc
      unknown authored
      BUG #2397 "RENAME TABLES is not blocked by FLUSH TABLES WITH READ LOCK"
      (added waiting for global_read_lock in mysql_rename_tables)
      
      
      mysql-test/r/rename.result:
        added test for 
        BUG #2397 "RENAME TABLES is not blocked by FLUSH TABLES WITH READ LOCK"
      mysql-test/t/rename.test:
        added test for 
        BUG #2397 "RENAME TABLES is not blocked by FLUSH TABLES WITH READ LOCK"
      sql/sql_rename.cc:
        fixed 
        BUG #2397 "RENAME TABLES is not blocked by FLUSH TABLES WITH READ LOCK"
        (added waiting for global_read_lock)
      9be599fc
    • unknown's avatar
      - install all *.sql files into the "shared" directory for the binary tar.gz · 0aa510bb
      unknown authored
         distribution (this is more in line with how "make install" would install
         them) - this should also fix a test failure in the "system_mysql_db_fix"
         test.
      
      
      BitKeeper/etc/ignore:
        Added cmd-line-utils/libedit/makelist to the ignore list
      0aa510bb
    • unknown's avatar
      fix for table/field caching mechanism · 54a8eb62
      unknown authored
      save moving ON/USING tables conditions to WHERE clause (BUG#2794)
      
      
      sql/sql_base.cc:
        fix for table/field caching mechanism (global lock of it and right table passed as parameter)
        save moving ON/USING tables conditions to WHERE clause (BUG#2794)
      sql/sql_class.cc:
        lock for using field/table cache in Item name resolution
      sql/sql_class.h:
        lock for using field/table cache in Item name resolution
      sql/sql_insert.cc:
        lock for using field/table cache in Item name resolution
      tests/client_test.c:
        Test of PS queries with ON condition
      54a8eb62
  6. 31 Mar, 2004 6 commits
    • unknown's avatar
      dead6301
    • unknown's avatar
      Merge of fix for bug #2050 and bug #3307 · e6d76615
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Manual merge
      e6d76615
    • unknown's avatar
      Fix for Bug #3307 "FLUSH TABLES sometimes breaks prepared statement · d2906f0e
      unknown authored
      table resolution".
      Added members to Item_ident for storing original db, table and field
      names since those that set later from Field have shorter life-time 
      than required by prep. stmt. So we need to restore original names in 
      Item_ident::cleanup(). Also now using special construnctor for creation
      of Item_field from Field object that ensures that table and field name 
      have big enough life-time.
      
      "Fix" for bug #2050 "10 to 1 performance drop with server 4.1.1"
      Clean ups in implementation of caching of field number in table.
      Added caching of table in which field is found in find_field_in_tables(). 
      
      
      sql/item.cc:
        Added members to Item_ident for storing original db, table and field
        names since those that set later from Field have shorter life-time 
        than required by prep. stmt. So we need to restore original names in 
        Item_ident::cleanup().
        Added Item_ident::cached_table for caching table there we found 
        our field.
        Added special constructor for creation of Item_field from Field object
        that ensures that table and field name have big enough life-time.
      sql/item.h:
        Added members to Item_ident for storing original db, table and field
        names since those that set later from Field have shorter life-time 
        than required by prep. stmt. So we need to restore original names in 
        Item_ident::cleanup().
        Changed type of Item_ident::cached_field_index from int to uint
        (and so NO_CACHED_FIELD_INDEX is UINT_MAX now) because we want to
        save one comparison in find_field_in_table().
        Added Item_ident::cached_table for caching table there we found 
        our field.
        Added special constructor for creation of Item_field from Field object
        that ensures that table and field name have big enough life-time.
      sql/mysql_priv.h:
        Changed type of cached_field_index_ptr from int* to uint*
        (and so NO_CACHED_FIELD_INDEX is UINT_MAX now) because we want to
        save one comparison in find_field_in_table().
      sql/sql_acl.cc:
        Changed type of find_field_in_table() paremeter to make it 
        faster.
      sql/sql_base.cc:
        find_field_in_table(): small optimization and soime clean ups in 
         caching of field index.
        find_field_in_tables(): added aggresive caching of table in which
         field is found in Item_ident::cached_table.
        insert_fields():
         using special construnctor for creation of Item_field from Field 
         object that ensures that table and field name have big enough life-time.
      d2906f0e
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0dd6f77d
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/Bugs/mysql-4.1
      
      
      0dd6f77d
    • unknown's avatar
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 9c2e4b03
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-qc-4.1
      
      
      9c2e4b03