Commit dbf128b7 authored by Julien Muchembled's avatar Julien Muchembled

Update comments

parent 910d1e91
...@@ -117,10 +117,11 @@ class Transaction(object): ...@@ -117,10 +117,11 @@ class Transaction(object):
return return
if lockless: if lockless:
if lockless != serial: # late lockless write if lockless != serial: # late lockless write
# Oops! We shouldn't have executed the above 'remove'. Readd.
assert lockless < serial, (lockless, serial) assert lockless < serial, (lockless, serial)
uuid_list.append(uuid) uuid_list.append(uuid)
return return
# It's safe to do this after the above excepts: either the cell is # It's safe to do this after the above except: either the cell is
# already marked as lockless or the node will be reported as failed. # already marked as lockless or the node will be reported as failed.
lockless = self.lockless_dict lockless = self.lockless_dict
if not lockless: if not lockless:
......
...@@ -345,7 +345,6 @@ class Test(NEOThreadedTest): ...@@ -345,7 +345,6 @@ class Test(NEOThreadedTest):
[DelayEvent, DelayEvent, ConflictError, ConflictError]) [DelayEvent, DelayEvent, ConflictError, ConflictError])
def testDeadlockAvoidance(self): def testDeadlockAvoidance(self):
# This test fail because deadlock avoidance is not fully implemented.
# 0: C1 -> S1 # 0: C1 -> S1
# 1: C2 -> S1, S2 (delayed) # 1: C2 -> S1, S2 (delayed)
# 2: C1 -> S2 (deadlock) # 2: C1 -> S2 (deadlock)
...@@ -2653,7 +2652,7 @@ class Test(NEOThreadedTest): ...@@ -2653,7 +2652,7 @@ class Test(NEOThreadedTest):
work in itself, the code was hazardous and the client can't easily work in itself, the code was hazardous and the client can't easily
discard such "positive" answers, or process them early enough. discard such "positive" answers, or process them early enough.
The scenario focuses on transaction t1 (storing object A) The scenario focuses on transaction t1 (storing oid 1)
and node s1 (initially replicating the only partition): and node s1 (initially replicating the only partition):
1. t1 stores: conflict on s0, lockless write on s1 1. t1 stores: conflict on s0, lockless write on s1
2. t2 stores: locked on s0, lockless write on s1 2. t2 stores: locked on s0, lockless write on s1
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment