Stop daemonizing

Run pim-dm in foreground

README.md

@@ -41,7 +41,7 @@ To interact with the protocol you need to execute the `pim-dm` command. You may
 
 #### Start protocol process
 
-In order to start the protocol you first need to explicitly start it. This will start a daemon process, which will be running in the background. The command is the following:
+In order to start the protocol you first need to explicitly start it. This will start pim-dm process, which will be running in foreground. The command is the following:
   ```
   sudo pim-dm -start [-mvrf MULTICAST_TABLE_ID] [-uvrf UNICAST_TABLE_ID]
   ```
@@ -57,6 +57,14 @@ If `-uvrf` is not defined, the default unicast table id will be used (table id 2
 After starting the protocol process, if the default multicast table is not used, the following commands (for adding interfaces and listing state) need to have the argument `-mvrf` defined to specify the corresponding daemon process.
 
 
+#### Run in background
+
+To start pim-dm process in background, one can use
+  ```
+  sudo setsid pim-dm -start [-mvrf MULTICAST_TABLE_ID] [-uvrf UNICAST_TABLE_ID] &
+  ```
+or run it with a daemonizing tool (systemd, supervisord, OpenRC ...).
+
 
 #### Multi daemon support
 

pimdm/daemon/Daemon.py

-"""Generic linux daemon base class for python 3.x."""
-
-import sys, os, time, atexit, signal
-from pimdm.tree import pim_globals
-
-
-class Daemon:
-    """A generic Daemon class.
-
-    Usage: subclass the Daemon class and override the run() method."""
-
-    def __init__(self, pidfile): self.pidfile = pidfile
-
-    def daemonize(self):
-        """Deamonize class. UNIX double fork mechanism."""
-
-        try:
-            pid = os.fork()
-            if pid > 0:
-                # exit first parent
-                sys.exit(0)
-        except OSError as err:
-            sys.stderr.write('fork #1 failed: {0}\n'.format(err))
-            sys.exit(1)
-
-        # decouple from parent environment
-        os.makedirs('/var/log/pimdm/', exist_ok=True)
-        os.chdir('/var/log/pimdm/')
-        os.setsid()
-        os.umask(0)
-
-        # do second fork
-        try:
-            pid = os.fork()
-            if pid > 0:
-
-                # exit from second parent
-                sys.exit(0)
-        except OSError as err:
-            sys.stderr.write('fork #2 failed: {0}\n'.format(err))
-            sys.exit(1)
-
-        # redirect standard file descriptors
-
-        sys.stdout.flush()
-        sys.stderr.flush()
-        si = open(os.devnull, 'r')
-        so = open('stdout' + str(pim_globals.MULTICAST_TABLE_ID), 'a+')
-        se = open('stderror' + str(pim_globals.MULTICAST_TABLE_ID), 'a+')
-
-        os.dup2(si.fileno(), sys.stdin.fileno())
-        os.dup2(so.fileno(), sys.stdout.fileno())
-        os.dup2(se.fileno(), sys.stderr.fileno())
-
-        # write pidfile
-        atexit.register(self.delpid)
-
-        pid = str(os.getpid())
-        with open(self.pidfile, 'w+') as f:
-            f.write(pid + '\n')
-
-    def delpid(self):
-        os.remove(self.pidfile)
-
-    def start(self):
-        """Start the Daemon."""
-
-        # Check for a pidfile to see if the Daemon already runs
-        if self.is_running():
-            message = "pidfile {0} already exist. " + \
-                    "Daemon already running?\n"
-            sys.stderr.write(message.format(self.pidfile))
-            sys.exit(1)
-
-        # Start the Daemon
-        self.daemonize()
-        self.run()
-
-    def stop(self):
-        """Stop the Daemon."""
-
-        # Get the pid from the pidfile
-        try:
-            with open(self.pidfile, 'r') as pf:
-                pid = int(pf.read().strip())
-        except IOError:
-            pid = None
-
-        if not pid:
-            message = "pidfile {0} does not exist. " + \
-                    "Daemon not running?\n"
-            sys.stderr.write(message.format(self.pidfile))
-            return # not an error in a restart
-
-        # Try killing the Daemon process
-        try:
-            while 1:
-                #os.killpg(os.getpgid(pid), signal.SIGTERM)
-                os.kill(pid, signal.SIGTERM)
-                time.sleep(0.1)
-        except OSError as err:
-            e = str(err.args)
-            if e.find("No such process") > 0:
-                if os.path.exists(self.pidfile):
-                    os.remove(self.pidfile)
-            else:
-                print(str(err.args))
-                sys.exit(1)
-
-    def run(self):
-        """You should override this method when you subclass Daemon.
-
-        It will be called after the process has been daemonized by
-        start() or restart()."""
-
-    def is_running(self):
-        try:
-            with open(self.pidfile, 'r') as pf:
-                pid = int(pf.read().strip())
-        except IOError:
-            return False
-
-        """ Check For the existence of a unix pid. """
-        try:
-            os.kill(pid, 0)
-            return True
-        except:
-            return False

pimdm/tree/pim_globals.py

-# Protocol files
-DAEMON_PROCESS_FILE = '/tmp/Daemon-pim{}.pid'
-DAEMON_SOCKET = '/tmp/pim_uds_socket{}'
-DAEMON_LOG_FOLDER = '/var/log/pimdm/'
-DAEMON_LOG_STDOUT_FILE = DAEMON_LOG_FOLDER + 'stdout{}'
-
 # PIM-DM TIMER VARIABLES
 ASSERT_TIME = 180
 GRAFT_RETRY_PERIOD = 3