handle buildout `allow-picked-version` value

If deployment mode option is not provided, default value is not allow-picked-version.

README.rst

 
 deployment
     If set to ``true``, the version of each gem dependency must be provided in
-    ``gems`` option. Default value is ``false``. 
+    ``gems`` option. Default value is ``not allow-picked-versions``. 
 
 gem-options
     Extra options, that will be passed to gem executable. Example::

rubygems.py

 
 import six.moves.urllib as urllib
 
-from distutils.util import strtobool
 from slapos.recipe.downloadunpacked import Recipe as Download
+from zc.buildout.easy_install import allow_picked_versions
 
 strip = lambda x:x.strip()  # noqa
 
+is_true = ('false', 'true').index
+
 
 class Recipe(object):
     """zc.buildout recipe for compiling and installing software"""
         # Allow to define specific ruby executable. If not, take just 'ruby'
         self.ruby_executable = options.get('ruby-executable', 'ruby')
 
-        deployment = options.get('deployment', 'false')
-        self.deployment = bool(strtobool(deployment))
+        deployment = options.get('deployment')
+        self.deployment = is_true(deployment) if deployment else not allow_picked_versions()
         self.gem_regex = re.compile(r'\s+([\w\-_.]+) \((<|~>|>=) '
                                     r'((\d+\.)*\d+)(, (>=) ((\d+\.)*\d+))?\)')
 

[Léo-Paul Géneau]

@jm @jerome

Does reusing buildout allow-picked-version value seem to be a good idea to set deployment-mode to true only once for all uses of rubygemsrecipe ?

[Thomas Gambier]

Maybe it would even be better to remove the deployment option totally and says that the recipe is now following the allow-picked-version option of buildout.

What do you think ?

[Léo-Paul Géneau]

If there is no objection I will merge this tomorrow.