slapproxy: Add minimal hateoas support for cli (!290) · Merge requests · nexedi / slapos.core · GitLab

slapproxy: Add minimal hateoas support for cli

All threads resolved

Add the minimum hateoas support required to let slapproxy answer the cli commands:

slapos service list
slapos service info <reference>
slapos computer list
slapos computer info <reference>

To enable hateoas, complete the slapos.cfg configuration with:

[slapos]
master_rest_url = <proxyaddr>/hateoas

Also: fix a few small bugs and python3 incompatibilities in slap/hateoas.

Edited 4 years ago by Xavier Thompson

Xavier Thompson @xavier_thompson · 4 years ago

Owner

/cc @tomo @romain @cedric.leninivin @jerome @lu.xu @luke
Xavier Thompson @xavier_thompson · 4 years ago

Owner

Here are some test results for python2 and python3
Jérome Perrin @jerome started a thread on an old version of the diff 4 years ago

Resolved by Jérome Perrin 4 years ago
Jérome Perrin @jerome started a thread on an old version of the diff 4 years ago

Resolved by Xavier Thompson 4 years ago
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

f2dedf53 - slapproxy: Add minimal hatoeas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

ef2d9d13 - slapproxy: Add minimal hatoeas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson resolved all discussions 4 years ago

resolved all discussions
Xavier Thompson @xavier_thompson changed the description 4 years ago

changed the description
Xavier Thompson @xavier_thompson unmarked as a Work In Progress 4 years ago

unmarked as a Work In Progress
Xavier Thompson @xavier_thompson · 4 years ago

Owner

I think this is ready for merge. If there are no objections I will merge tomorrow.
Thomas Gambier 🚴🏼 @tomo · 4 years ago

Owner

Resolved by Xavier Thompson 4 years ago

ALERT: you should replace everywhere hatoeas (bad) by hateoas (good)

Last reply by Xavier Thompson 4 years ago
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

5230137c - slapproxy: Add minimal hateoas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson changed title from slapproxy: Add minimal hatoeas support for cli to slapproxy: Add minimal hateoas support for cli 4 years ago

changed title from slapproxy: Add minimal hatoeas support for cli to slapproxy: Add minimal hateoas support for cli
Xavier Thompson @xavier_thompson changed the description 4 years ago

changed the description
Thomas Gambier 🚴🏼 @tomo started a thread on an old version of the diff 4 years ago

Resolved by Xavier Thompson 4 years ago
Thomas Gambier 🚴🏼 @tomo · 4 years ago

Owner

Thanks @xavier_thompson seems good.
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

fb197781 - slapproxy: Add minimal hateoas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson resolved all discussions 4 years ago

resolved all discussions
Xavier Thompson @xavier_thompson · 4 years ago

Owner

Here are some tests results for python2 and python3 after the latest changes.
Xavier Thompson @xavier_thompson · 4 years ago

Owner

/cc @rafael
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

bb37ab55 - slapproxy: Add minimal hateoas support for cli

Compare with previous version
Cédric Le Ninivin @cedric.leninivin · 4 years ago

Developer

Resolved by Xavier Thompson 4 years ago

As is, there is a difference in behaviour with slapos service list and service info as it shows all instances in the proxy. When working with slapos master, it only shows hosting subscription / root instances: i.e. what has been requested by the user.

Hosting subscriptions are partially implemented in slapproxy by the hackish "requested_by" column. It is used for garbage collect when destroying an instance and is very useful for this. I'm in favor of extending this behaviour to requests and services list. For request this is needed when wanting to have two erp5 instances on a single proxy. For service list, to provide clarity and consistent behaviour with existing slapos service list.

slapos proxy show could be extended in order to actually list all instances and the parameters given to them.

Last reply by Xavier Thompson 4 years ago
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

3ddb52b6 - slapproxy: Add minimal hateoas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson resolved all discussions 4 years ago

resolved all discussions
Xavier Thompson @xavier_thompson · 4 years ago

Owner

If there are no objections or further suggestions, I will merge tomorrow.
Xavier Thompson @xavier_thompson added 12 commits 4 years ago
added 12 commits

3ddb52b6...740021b4 - 11 commits from branch nexedi:master

0631dc9f - slapproxy: Add minimal hateoas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson mentioned in commit xavier_thompson/slapos.core@655fb891 4 years ago

mentioned in commit xavier_thompson/slapos.core@655fb891
Xavier Thompson @xavier_thompson added 1 commit 4 years ago
added 1 commit

655fb891 - slapproxy: Add minimal hateoas support for cli

Compare with previous version
Xavier Thompson @xavier_thompson merged 4 years ago

merged
Xavier Thompson @xavier_thompson mentioned in commit fee2ab1e 3 years ago

mentioned in commit fee2ab1e
You're only seeing other activity in the feed. To add a comment, switch to one of the following options.

Please register or sign in to reply