python3: switch to 3.7

component/python3/buildout.cfg

@@ -20,7 +20,7 @@ parts =
     python3
 
 [python3]
-<= python3.6
+<= python3.7
 
 [python3-common]
 recipe = slapos.recipe.cmmi
@@ -61,12 +61,7 @@ md5sum = 986078f11b39074be22a199e56491d98
 [python3.7]
 <= python3-common
 version = 3.7
-package_version = 3.7.2
-md5sum = df6ec36011808205beda239c72f947cb
+package_version = 3.7.7
+md5sum = 172c650156f7bea68ce31b2fd01fa766
 patch-options =
 patches =
-environment =
-  PATH=${xz-utils:location}/bin:%(PATH)s
-  CPPFLAGS=-I${zlib:location}/include -I${xz-utils:location}/include -I${readline:location}/include -I${libexpat:location}/include -I${libffi:location}/include -I${ncurses:location}/include -I${ncurses:location}/include/ncursesw -I${bzip2:location}/include  -I${gdbm:location}/include -I${openssl:location}/include -I${sqlite3:location}/include -I${gettext:location}/include
-  LDFLAGS=-L${zlib:location}/lib -L${xz-utils:location}/lib -L${readline:location}/lib -L${libexpat:location}/lib -L${libffi:location}/lib -L${ncurses:location}/lib -L${bzip2:location}/lib -L${gdbm:location}/lib -L${openssl:location}/lib -L${sqlite3:location}/lib -Wl,-rpath=${zlib:location}/lib -Wl,-rpath=${xz-utils:location}/lib -Wl,-rpath=${readline:location}/lib -Wl,-rpath=${libexpat:location}/lib -Wl,-rpath=${libffi:location}/lib -Wl,-rpath=${ncurses:location}/lib -Wl,-rpath=${bzip2:location}/lib -Wl,-rpath=${gdbm:location}/lib -Wl,-rpath=${openssl:location}/lib -Wl,-rpath=${sqlite3:location}/lib -L${gettext:location}/lib -Wl,-rpath=${gettext:location}/lib -Wl,-rpath=${file:location}/lib
-#  LD_LIBRARY_PATH=${libpng:location}/lib

[Jérome Perrin]

It seems that since this we have test failures in slapos.rebootstrap and slapos.recipe.template

I believe this is because of a problem in buildout that was fixed in https://github.com/buildout/buildout/commit/978a6af9e78db44b9db25cb08c7f9d98c24bbc03 but that patch does not apply in our fork

[Julien Muchembled]

Still working on this. 2 days ago, I found issues about the install command (buildout install [parts]...): not important because maybe nobody uses it but one of them is that we have extra failures (in buildout.txt) when running the test suite with Python 3. But I've just found that the py2/py3 issue would not be in the install command...

We have several problems about the buildout test suite. With Python 2, it does not run entirely (which explains why we have extra failures with Python 3) and it's like that since November 2018. Compare the following consecutive test results:

• https://nexedi.erp5.net/test_result_module/20181114-89757D78 (372 tests, 539s, 1 failure in buildout.txt)
• https://nexedi.erp5.net/test_result_module/20181115-85A5DE25 (87 tests, 462s, no failure in buildout.txt)

Which is strange in 2 ways:

• The only difference in the code between these 2 results is a commit in the ERP5 SR, which is unrelated.
• There are little difference in the duration (539s vs 462s). Today, the difference between Py2 (89 tests, 364s) and Py3 (376 tests, 1020s) is significantly greater.

[Julien Muchembled]

Looks like a regression in manuel. At that time, we didn't pin The buildout test suite does not pin eggs and there were new versions at that time (14/15 Nov 2018).

[Julien Muchembled]

• 1.10.0 (2018-11-14)

  • Fix DeprecationWarning about ‘U’ mode under Python 3.
  • Drop Python 2.7 and 3.3 support. Add testing and support for Python 3.6 and 3.7.

Pff, that's crazy. 2.7 is a typo. They meant 2.6

The issue is fixed upstream but not released. See https://github.com/benji-york/manuel/pull/21

[Julien Muchembled]

I have fixed the way we run tests. The only remaining difference between Py2 & Py3 is that the latter is much slower.