software/theia: Disable integrated git credentials prompt

software/theia/buildout.hash.cfg

@@ -15,7 +15,7 @@
 
 [instance-theia]
 _update_hash_filename_ = instance-theia.cfg.jinja.in
-md5sum = 562acf69f344fa9f6d03992d696462d0
+md5sum = e39925b69a8bc17d17be54c075ae2f88
 
 [instance]
 _update_hash_filename_ = instance.cfg.in

software/theia/instance-theia.cfg.jinja.in

@@ -594,7 +594,8 @@ template =
       "**/node_modules/**": true,
       "$${directory:runner}/**":true,
       "$${directory:project}/runner/**":true
-    }
+    },
+    "git.terminalAuthentication": false
   }
 
 [runner-link]

[Jérome Perrin]

I have been using before this change and in my experience it was working fine. Is there something not working ?

[Jérome Perrin]

( it was working fine but the user experience was a bit surprising, I guess it's like this in vscode for integration with system keyring )

[Xavier Thompson]

I've received feedback against it from several users, that's why I deactivated it. Some didn't even notice the credential prompt at first, and another issue is that when you type your password it's in the clear.

[Jérome Perrin]

Thanks @xavier_thompson for explanation. I believe you were right making this change. This feature was a bit surprising, when using git commands in the terminal, users expect to have their credential prompted for in the terminal.

For the records, I think was a password input field, not text input when I used it.