Commit bca53d7e authored by Łukasz Nowak's avatar Łukasz Nowak

component/subversion: Use openssl == 1.0

Since default openssl component is 1.1 and is not compatible with this
component, use openssl-1.0.
parent 9fa86069
...@@ -53,9 +53,9 @@ configure-options = ...@@ -53,9 +53,9 @@ configure-options =
make-targets = install -j1 make-targets = install -j1
environment = environment =
PATH=${patch:location}/bin:${perl:location}/bin:${pkgconfig:location}/bin:%(PATH)s PATH=${patch:location}/bin:${perl:location}/bin:${pkgconfig:location}/bin:%(PATH)s
PKG_CONFIG_PATH=${apache:location}/lib/pkgconfig:${sqlite3:location}/lib/pkgconfig:${openssl:location}/lib/pkgconfig:${serf:location}/lib/pkgconfig PKG_CONFIG_PATH=${apache:location}/lib/pkgconfig:${sqlite3:location}/lib/pkgconfig:${openssl-1.0:location}/lib/pkgconfig:${serf:location}/lib/pkgconfig
CPPFLAGS=-I${libexpat:location}/include -I${libuuid:location}/include CPPFLAGS=-I${libexpat:location}/include -I${libuuid:location}/include
LDFLAGS=-L${libexpat:location}/lib -Wl,-rpath=${zlib:location}/lib -Wl,-rpath=${sqlite3:location}/lib -Wl,-rpath=${apache:location}/lib -L${libuuid:location}/lib -Wl,-rpath=${libuuid:location}/lib -Wl,-rpath=${openssl:location}/lib LDFLAGS=-L${libexpat:location}/lib -Wl,-rpath=${zlib:location}/lib -Wl,-rpath=${sqlite3:location}/lib -Wl,-rpath=${apache:location}/lib -L${libuuid:location}/lib -Wl,-rpath=${libuuid:location}/lib -Wl,-rpath=${openssl-1.0:location}/lib
[subversion-1.9] [subversion-1.9]
recipe = hexagonit.recipe.cmmi recipe = hexagonit.recipe.cmmi
...@@ -95,6 +95,6 @@ make-targets = ...@@ -95,6 +95,6 @@ make-targets =
environment = environment =
PATH=${pkgconfig:location}/bin:${neon:location}/bin:%(PATH)s PATH=${pkgconfig:location}/bin:${neon:location}/bin:%(PATH)s
PKG_CONFIG_PATH=${apache:location}/lib/pkgconfig:${sqlite3:location}/lib/pkgconfig:${openssl:location}/lib/pkgconfig:${neon:location}/lib/pkgconfig PKG_CONFIG_PATH=${apache:location}/lib/pkgconfig:${sqlite3:location}/lib/pkgconfig:${openssl-1.0:location}/lib/pkgconfig:${neon:location}/lib/pkgconfig
CPPFLAGS=-I${libexpat:location}/include -I${libuuid:location}/include CPPFLAGS=-I${libexpat:location}/include -I${libuuid:location}/include
LDFLAGS=-L${libexpat:location}/lib -Wl,-rpath=${zlib:location}/lib -Wl,-rpath=${sqlite3:location}/lib -Wl,-rpath=${neon:location}/lib -Wl,-rpath=${apache:location}/lib -L${libuuid:location}/lib -Wl,-rpath=${libuuid:location}/lib LDFLAGS=-L${libexpat:location}/lib -Wl,-rpath=${zlib:location}/lib -Wl,-rpath=${sqlite3:location}/lib -Wl,-rpath=${neon:location}/lib -Wl,-rpath=${apache:location}/lib -L${libuuid:location}/lib -Wl,-rpath=${libuuid:location}/lib -Wl,-rpath=${openssl-1.0:location}/lib
  • What's the problem with subversion ? On my Debian:

    $ ldd /usr/bin/svn |grep ssl
            libssl.so.1.1 => /lib/x86_64-linux-gnu/libssl.so.1.1 (0x00007f009d362000)

    Please look at the future. All your commits are wasted work because at some point, we'll anyway have to spend time on upgrading these components. It's not as if we could freeze them forever. If we don't even update them because of this kind of things, when will we ?

    The transition to ssl 1.1 is quite old now and Debian contributed a lot on the subject.

  • mentioned in merge request !442 (merged)

    Toggle commit list
  • Please look at the future. All your commits are wasted work because at some point, we'll anyway have to spend time on upgrading these components. It's not as if we could freeze them forever. If we don't even update them because of this kind of things, when will we ?

    It is not a waste of time, it is actuallying saving us time to have caucase out w/o require to upgrade old softwares that we need. Linux Distributions is bad to keep multiple versions of a library but they often do (like gcc), so I see nothing wrong on this.

    When we will? When we need or when we have time. Maybe the time we would expend moving on moving svn to openssl-1.1.1 would be a waste, because subversion wouldn't be used anymore (personally, I think nobody uses it and we should remove from ERP5).

    Edited by Rafael Monnerat
  • I don't see how it saved you time, given that increasing a version number is probably enough. Trying was trivial and fast. If it happened it would not have been enough, then I can understand to fallback on doing this.

    It's not only about subversion. For example, we'll never give up openldap because it is required by customers.

    I complain because it happens so often that we spend more time hacking in our side instead of doing the right thing from the beginning, which we'd have to do anyway.

    Now, the resulting recipes are more complex. Someone may even get issues when linking 2 libraries that use different versions of ssl, the worst being if the issue is not immediately understandable.

    Maintenance is important. We always have to do a minimum amount of it before doing the actual work we want to do.

  • Someone may even get issues when linking 2 libraries that use different versions of ssl, the worst being if the issue is not immediately understandable.

    It seems there's already a problem with python-ldap.

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment