- 28 Nov, 2023 8 commits
-
-
Kirill Smelkov authored
We already pushed dnsmasq part, that serves radio units into enb in 9f2b9db5. However we need to push those bits further to ru/ for the following reasons: - DHCP server is used to provide Radio Units with IP address only. - without IP address assigned those RUs cannot be initialized and do not go to radio at all. - in general we will need to initialize and setup radio units not only in eNB - for example UEsim will use the same code library to initialize radio units. Thus the proper place to keep everything required for RU to be operational have to be located inside ru/ and activated by that radio-units library. /cc @jhuge, @xavier_thompson, @Daetalus /reviewed-by @lu.xu /reviewed-on nexedi/slapos!1479
-
Kirill Smelkov authored
The code had check-rx-saturated under `if not ru == "lopcomm"`, but checking RX signal for saturation is implemented on eNB side, not by RU itself, and is RU-independent because eNB only receives raw samples from RU and decides on its own whether those samples are higher than saturation margin or not. As an extra proof that checking for RX saturation is meaningful for Lopcomm too here is how samples.rx data can look like in the case of 2 Lopcomm Radio Units: root@callbox-005:/srv/slapgrid/slappart16/var/log# cat amarisoft-stats.json.log |jq .data.samples.rx [ { "rms": -382.3080749511719, "max": -382.3080749511719, "sat": 0, "count": 1221181440, "rms_dbm": -382.3080749511719 }, { "rms": -382.3080749511719, "max": -382.3080749511719, "sat": 0, "count": 1221179392, "rms_dbm": -382.3080749511719 } ] ... i.e. all the data, that check-rx-saturated promise works on, is there. /cc @jhuge, @xavier_thompson, @Daetalus /reviewed-by @lu.xu /reviewed-on nexedi/slapos!1478
-
Thomas Gambier authored
-
Thomas Gambier authored
-
Thomas Gambier authored
-
Thomas Gambier authored
-
Thomas Gambier authored
On Fedora, the flag -lm is not correctly added so add it manually.
-
Thomas Gambier authored
Those warnings are breaking compilation on Fedora: [ 1280s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I. -I. -I.. -I.. -Iglib -DIN_LIBTEXTSTYLE -DLIBXML_STATIC -I./libcroco -DDEPENDS_ON_LIBICONV=1 -I/home/abuild/rpmbuild/BUILD/sn_1.10.5+1.0.346+1/slapos/build/opt/slapos/parts/libxml2/include -I/home/abuild/rpmbuild/BUILD/sn_1.10.5+1.0.346+1/slapos/build/opt/slapos/parts/zlib/include -I/home/abuild/rpmbuild/BUILD/sn_1.10.5+1.0.346+1/slapos/build/opt/slapos/parts/ncurses/include -fanalyzer -Wall -Warith-conversion -Wcast-align=strict -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wduplicated-branches -Wduplicated-cond -Wextra -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-include-dirs -Wnested-externs -Wnull-dereference -Wopenmp-simd -Woverlength-strings -Wpacked -Wpointer-arith -Wstack-protector -Wstrict-overflow -Wsuggest-attribute=format -Wsuggest-final-methods -Wsuggest-final-types -Wsync-nand -Wsystem-headers -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunsafe-loop-optimizations -Wvariadic-macros -Wvector-operation-performance -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wbidi-chars=any,ucn -Wformat-overflow=2 -Wformat=2 -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wshift-overflow=2 -Wuse-after-free=3 -Wunused-const-variable=2 -Wvla-larger-than=4031 -Wno-analyzer-malloc-leak -Wno-empty-body -Wno-analyzer-double-fclose -Wno-analyzer-double-free -Wno-analyzer-null-argument -Wno-analyzer-null-dereference -Wno-analyzer-use-of-uninitialized-value -Wno-cast-align -Wno-format-nonliteral -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-clobbered -Wshadow=local -Wno-cast-function-type -Wno-duplicated-cond -Wno-format -Wno-implicit-fallthrough -Wno-null-dereference -Wno-suggest-attribute=format -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -c libcroco/cr-additional-sel.c -fPIC -DPIC -o libcroco/.libs/rpl_la-cr-additional-sel.o [ 1280s] cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security] [ 1280s] cc1: some warnings being treated as errors
-
- 27 Nov, 2023 1 commit
-
-
Jérome Perrin authored
Some fixes for gcc12 and for ldd problems when some dev packages are installed See merge request !1482
-
- 25 Nov, 2023 6 commits
-
-
Jérome Perrin authored
to prevent using system package when ncurses-dev is installed
-
Jérome Perrin authored
to prevent from using system packages when libcurses-dev is installed
-
Jérome Perrin authored
This uses rbnacl-sodium which bundle an old version of libsodium that can not be compiled with gcc 12. This is an optional dependency to support ed25519 ssh keys, but we the slapos version of gitlab does not use ssh, only https, so we don't actually need to install this.
-
Jérome Perrin authored
-
Jérome Perrin authored
To prevent linking with system libtirpc if the corresponding system -dev package is installed
-
Jérome Perrin authored
We were using --without-ncurses but this does not prevent the build from using system package when ncurses-dev system package is installed.
-
- 24 Nov, 2023 6 commits
-
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
if only bison exists in PATH, we will get an error: /path/to/bison: m4 subprocess failed: No such file or directory
-
Kazuhiko Shiozaki authored
also copy libperfschema.a in lib directory to build mroonga with MariaDB >= 10.5.
-
Jérome Perrin authored
This was building against system library when ncurses-dev system package is installed
-
Thomas Gambier authored
-
Xavier Thompson authored
This concerns a case of resiliency in Theia: when a resilient Theia requests multiple import clones (by default only one is requested), e.g. when theia0 (export) has two import clones theia1 and theia2. Each clone requests a frontend for their theia service, which allows the Theia editor of the clone to be accessed without doing a takeover. Before this, all the import clones would request a frontend with the same name. This meant that only one frontend was allocated and might randomly redirect to one of the backup clones. See merge request nexedi/slapos!1481
-
- 23 Nov, 2023 4 commits
-
-
Lu Xu authored
accidentally removed [slaplte.jinja2] _update_hash_filename_ = slaplte.jinja2 md5sum = from buildout.hash.cfg
-
Lu Xu authored
The Netconf subscriptions were added twice, causing the RU to reboot because there was no supervision check on the redundant subscription.
-
Lu Xu authored
The Ncclient does not have a timeout for taking notifications, causing it to wait indefinitely. This can result in the connection being lost while the waiting process is still ongoing.
-
Kirill Smelkov authored
software/ors-amarisoft: Start of slaplte package by way of fixing standalone build of enb.cfg and gnb.cfg Please see individual patches for details. /cc @lu.xu, @xavier_thompson, @Daetalus /reviewed-by @jhuge /reviewed-on nexedi/slapos!1480
-
- 21 Nov, 2023 7 commits
-
-
Kirill Smelkov authored
After cell_list problem was fixed in the previous patch, now building enb.cfg in standalone mode fails on mme_addr: slapuser35@vifibcloud-rapidspace-hosting-018:~/srv/project/slapos/software/ors-amarisoft$ ./pythonwitheggs slapos-render-config.py Traceback (most recent call last): File "/srv/slapgrid/slappart35/srv/project/slapos/software/ors-amarisoft/./pythonwitheggs", line 47, in <module> exec(compile(__file__f.read(), __file__, "exec")) File "slapos-render-config.py", line 92, in <module> do('enb', {"tdd_ul_dl_config": "[Configuration 6] 5ms 5UL 3DL (maximum uplink)"}) File "slapos-render-config.py", line 90, in do j2render(cfg, json_params % locals()) File "slapos-render-config.py", line 38, in j2render f.write(r._render().decode()) File "/srv/slapgrid/slappart35/srv/runner/software/0b402c7d1e7c38a4324c836766690bb6/eggs/slapos.recipe.template-5.1-py3.9.egg/slapos/recipe/template/jinja2_template.py", line 215, in _render return template_object.render(**self.context).encode(self.encoding) File "/srv/slapgrid/slappart35/srv/runner/software/0b402c7d1e7c38a4324c836766690bb6/eggs/Jinja2-2.11.3-py3.9.egg/jinja2/environment.py", line 1090, in render self.environment.handle_exception() File "/srv/slapgrid/slappart35/srv/runner/software/0b402c7d1e7c38a4324c836766690bb6/eggs/Jinja2-2.11.3-py3.9.egg/jinja2/environment.py", line 832, in handle_exception reraise(*rewrite_traceback_stack(source=source)) File "/srv/slapgrid/slappart35/srv/runner/software/0b402c7d1e7c38a4324c836766690bb6/eggs/Jinja2-2.11.3-py3.9.egg/jinja2/_compat.py", line 28, in reraise raise value.with_traceback(tb) File "config/enb.jinja2.cfg", line 139, in top-level template code mme_addr: "{{ slap_configuration['configuration.mme_addr'] }}", jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'configuration.mme_addr' -> Fix it by providing both mme_addr in addition to amf_addr. Now both enb.cfg and gnb.cfg render in standalone mode well. /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
-
Kirill Smelkov authored
In b0c37a4a (software/ors-amarisoft: Start to generalize existing lopcomm/multicell into multiRU slowly) I deduplicated cell_list initialization and moved it into single place, but overlooked that enb.cfg build became broken in standalone mode: .../software/ors-amarisoft$ ./pythonwitheggs slapos-render-config.py Traceback (most recent call last): File "/srv/slapgrid/slappart35/srv/project/slapos/software/ors-amarisoft/./pythonwitheggs", line 47, in <module> exec(compile(__file__f.read(), __file__, "exec")) File "slapos-render-config.py", line 88, in <module> do('enb', {"tdd_ul_dl_config": "[Configuration 6] 5ms 5UL 3DL (maximum uplink)"}) File "slapos-render-config.py", line 86, in do j2render(cfg, json_params % locals()) File "slapos-render-config.py", line 34, in j2render f.write(r._render().decode()) File ".../eggs/slapos.recipe.template-5.1-py3.9.egg/slapos/recipe/template/jinja2_template.py", line 215, in _render return template_object.render(**self.context).encode(self.encoding) File ".../eggs/Jinja2-2.11.3-py3.9.egg/jinja2/environment.py", line 1090, in render self.environment.handle_exception() File ".../eggs/Jinja2-2.11.3-py3.9.egg/jinja2/environment.py", line 832, in handle_exception reraise(*rewrite_traceback_stack(source=source)) File ".../eggs/Jinja2-2.11.3-py3.9.egg/jinja2/_compat.py", line 28, in reraise raise value.with_traceback(tb) File "config/enb.jinja2.cfg", line 1, in top-level template code {%- set cell_count = cell_list|length %} jinja2.exceptions.UndefinedError: 'cell_list' is undefined -> Fix it by teaching enb.jinja2.cfg to also load cell list in standalone by itself. Not touching gnb.jinja2.cfg as currently gnb does not support multicell at all, and in the future it will be sole enb.cfg to handle both LTE and NR simultaneously. /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
-
Kirill Smelkov authored
This currently has severl problems which we'll be fixing up one by one in the followup patches. /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
-
Kirill Smelkov authored
Currently which config to render is hardcoded in this program and only of the is rendered - currently gnb. This leads to situation where it is easy to miss breakage of unselected config. -> Factor one config rendering into common routine as the preparatory step to render both enb.cfg and gnb.cfg /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
-
Kirill Smelkov authored
software/ors-amarisoft: Start to put common code to load cells and radio units and handle them into slaplte package We will soon need to use that shared code not only from radio library under ru/ , but also from enb.jinja2.cfg and to fix slapos-render-config. /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
-
Kirill Smelkov authored
After 8c841ce6 slapos-render-config.py got broken: (py3.venv) kirr@deca:~/src/wendelin/slapos/slapos/software/ors-amarisoft$ python slapos-render-config.py Traceback (most recent call last): File "/home/kirr/src/wendelin/slapos/slapos/software/ors-amarisoft/slapos-render-config.py", line 87, in <module> j2render(config, json_params) File "/home/kirr/src/wendelin/slapos/slapos/software/ors-amarisoft/slapos-render-config.py", line 34, in j2render f.write(r._render().decode()) ^^^^^^^^^^^ File "/home/kirr/src/wendelin/slapos/slapos.recipe.template/slapos/recipe/template/jinja2_template.py", line 215, in _render return template_object.render(**self.context).encode(self.encoding) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/kirr/src/wendelin/venv/py3.venv/lib/python3.11/site-packages/jinja2/environment.py", line 1301, in render self.environment.handle_exception() File "/home/kirr/src/wendelin/venv/py3.venv/lib/python3.11/site-packages/jinja2/environment.py", line 936, in handle_exception raise rewrite_traceback_stack(source=source) File "config/gnb.jinja2.cfg", line 586, in top-level template code drb_config: "{{ drb_file }}", ^^^^^^^^^^^^^^^^^^^^^^^^^ jinja2.exceptions.UndefinedError: 'drb_file' is undefined /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
-
Jérome Perrin authored
We had to introduce a web page to bootstrap the web version of devtools because since https://bugs.chromium.org/p/chromium/issues/detail?id=1232509 chrome debugger port no longer serve such a page via HTTP. The URL also changed, /serve_file/@{version_hash}. pattern is no longer used, both the devtools and the websocket endpoint are in /devtools The test was made a bit more complete by actually making requests and trying to connect to websocket endpoints. Some problems were found with incognito and block-new-web-contents options: - they are boolean type, but the software parameter serialisation is XML, which as of today does not support boolean types. This is left TODO for now - When both --incognito and --block-new-web-contents are true, the command line flag was --incognito--block-new-web-contents, which is unknown and was ignored. Some minmal changes are included to fix this.
-
- 17 Nov, 2023 7 commits
-
-
Kirill Smelkov authored
By reusing recently added "split TAP" infrastructure we can adjust dnsmasq configuration to provide unique IPv6 to each RU. - ru_mac_addr becomes per-RU setting and without default. We talked with Lu, and since now all Lopcomm units are shipped from the factory with unique MAC, it both does not make sense to provide the default, and we can rely on all units to have different MACs and configure DHCP replies based on that. - No need to provide /64 network to every RU. We cannot actually do that anyway because normally SlapOS provides /71 address range for its slaptap. In the new configuration everything works with smaller networks just ok. /cc @jhuge, @xavier_thompson, @Daetalus /reviewed-by @lu.xu /reviewed-on nexedi/slapos!1472
-
Kirill Smelkov authored
Those options are not needed, because we need to only provide IPv6 address to RU, and also they are not very meaningful: in the current form we tell RU that DNS addresses sit at RU.addr+1 and RU.addr+2, i.e. in the IP range we give to RU and also at the addresses where no DNS server is actually running. It was probably a thinko to add those options initially. /cc @jhuge, @xavier_thompson, @Daetalus /reviewed-by @lu.xu /reviewed-on nexedi/slapos!1472
-
Kirill Smelkov authored
Core Network and ENB use dnsmasq for completely different purposes: - core network uses it to provide DNS server, while - enb uses dnsmasq to provide DHCP server for Radio Units to be able to access Control & Management channel on the CPRI link. -> Even though both those services are handled via same dnsmasq program, it makes sense to split dnsmasq config for clarity and as preparation for further adjustments of enb part. We also push config rendering down to -core and -enb instances also for clarity, and because in enb case rendering will need to know set of configured Radio Units - information that will become loaded only at instance-enb. /cc @jhuge, @xavier_thompson, @Daetalus /reviewed-by @lu.xu /reviewed-on nexedi/slapos!1472
-
Kirill Smelkov authored
SlapOS provides to each partition dedicated TAP interface, so that an instance could organize internal networking. In practice this is used by KVM software release and here in ors-amarisoft, where we feed to eNB such TAP interface for CPRI-based radio unit so that eNB, in turn, could provide access to CPRI Control and Management channel via provided TAP. However there is a problem: SlapOS provides only one TAP interface per instance, while we need to have one TAP for each Radio Unit. -> Solve this problem by creating TAP "subinterfaces" per each RU ourselves. The interfaces we create are full TAP interfaces, just we name them with prefix based on main interface, and we allocate only part of address space of sole SlapOS TAP to each subtap. For example if SlapOS provided us slaptap16 with 2401:5180:0:66:a200::/71 IPv6 range and we want to split it for 2 radio units, we'll be splitting it into 3 regions as follows: slaptap16: split 2401:5180:0:66:a200::/71 by 2 preserve 2401:5180:0:66:a200::/73 -> slaptap16-1 2401:5180:0:66:a280::/73 -> slaptap16-2 2401:5180:0:66:a300::/73 Here we preserve 2401:5180:0:66:a200::/73 for usage on original slaptap16, and we create slaptap16-1 and slaptap16-2 with correspondingly allocated address range subparts for the RUs. The splitting is done easily but depends on having networking administration capability to be able to work. We solve this with employing /opt/amarisoft/setcap, which we already use for dnsmasq, and with compiled trampoline program because setcap does not really work directly on scripts. To avoid hard dependency on having network capability rights, we fallback to using regular SlapOS slaptap in case there is only one RU. ru/lopcomm/* and enb.cfg are adapted straightforwardly, but dnsmasq adaptation is left to a later step not to mix everything into one pile. NOTE that relying on setcap is not a good in the long term and should be reworked once SlapOS is improved to provide ability for instances to request several TAP interfaces. Please see discussion at nexedi/slapos!1471 (comment 194356) for details. /cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus /reviewed-on nexedi/slapos!1471
-
Kirill Smelkov authored
A preparatory step for multiRU for the same reason as for LTE and also to be able to support Carrier Aggregation in between NR and LTE cells in the future (called Dual Connectivity by 3GPP). /cc @xavier_thompson, @Daetalus /reviewed-by @jhuge, @lu.xu /reviewed-on nexedi/slapos!1473
-
Kirill Smelkov authored
When there will be multiple cells and so multiple DRB files referenced from enb.cfg, eNB will complain with an error that "there are multiple #define" for T_REORDERING. -> Use jinja2 templating instead to handle FDD/TDD conditions. /cc @xavier_thompson, @Daetalus /reviewed-by @jhuge, @lu.xu /reviewed-on !1473
-
Kirill Smelkov authored
This is preparatory step for multiRU: when there will be several LTE cells, each possibly having different RF mode, we'll need to configure DRB per-cell. -> Move DRB configuration to separate jinja2 template to prepare to handle that. This is 99% movement only, without changing the code for DRB profile. We'll adjust the DRB profile a bit as another preparatory step in the next patch. /cc @xavier_thompson, @Daetalus /reviewed-by @jhuge, @lu.xu /reviewed-on nexedi/slapos!1473
-
- 16 Nov, 2023 1 commit
-
-
Kirill Smelkov authored
Lopcomm part of the SR already has some partial support for cell_list: if multiple cells are defined there enb.cfg will have multiple CPRI radio units and multiple cells configured. But so far all promises, except cpri-link, were done only for one RU. -> Fix that by starting to generalize RUlib code to handle multiple radio units, invoking model-specific RU driver for each RU, and adjusting ru/lopcomm instance code to correctly generate and activate different promises for different radio units. After the patch multiRU support is still very incomplete, but it is a step forward. /cc @xavier_thompson, @Daetalus /reviewed-by @lu.xu /partly-reviewed-by @jhuge /reviewed-at !1467
-