GitLab

Since we merged !258 (merged) ERP5 failed to build on 1.0 branch because cloudooo got a new dependency ( cloudooo@0ff799eb ) to pyPdf that was not pinned in versions.

We add a pin for this eggs, and also pin some git repositories which we realized where not pinned either.

mentioned in merge request !314 (closed)

In theory, Cloudooo software release also need this version pin, but we don't test it on 1.0 for now, so I guess it's ok for now.

@rafael tests seems to be running this time.

neoppod-repository repository was supposed to be pinned at https://lab.nexedi.com/nexedi/slapos/blob/1.0/software/neoppod/software.cfg but I think It is a typo there.

In case of slapos cookbook, we use egg and not git clone, since 0cb923ac and it is already pin here:

https://lab.nexedi.com/nexedi/slapos/blob/19a6bd3418b724ecf42fbefbff8dc1ef058bbf35/stack/slapos.cfg#L134

for the scikit, yes we can pin it there (I didn't know we use from git always.)

neoppod-repository repository was supposed to be pinned at https://lab.nexedi.com/nexedi/slapos/blob/1.0/software/neoppod/software.cfg but I think It is a typo there.

Yes, there's a typo, but software/neoppod/software.cfg is not extended by software/erp5/software.cfg, only software/neoppod/software-common.cfg is extended.

In case of slapos cookbook, we use egg and not git clone

Aah you are right. I just checked the output of buildout annotate to see if there were some parts using slapos.recipe.build:gitclone without specifying a revision, but I realize this approach is wrong, because it just flatten all extended profiles, regardless of wether the parts will be installed or not.

slapos.cookbook-repository does not seem to be installed. scikit-learn-repository does not seem to be installed either, so there's no need to set a revision for these parts.

I can continue this tomorrow.

Added 2 commits:

• e327c2af - ERP5: pin neoppod git repository
• 43ae829d - ERP5: pin pyPdf egg (dependency of cloudooo)

@rafael

I updated to remove useless pins on slapos.cookbook-repository and scikit-learn-repository, so for ERP5 SR, only pin on neoppod was missing.

tests seems OK this time.

Status changed to merged

thanks Jerome

@rafael thanks for the careful review

This was merged with "apply patches", so the "post merge" discussions from e46011cb do not appear here.

For the records, this just fixes ERP5. The following problems are still present:

• cloudooo SR on 1.0 probably does not install (I don't see version pin on pyPDF )
• neoppod SR repository is not pinned, because of that typo mentioned above

mentioned in commit e46011cb

mentioned in merge request slapos.recipe.build!2