software/theia: Adjust to Caddy build changes (!935) · Merge Requests · nexedi / slapos

software/theia: Adjust to Caddy build changes

The changes to the caddy build method in 1cfb657f break software/theia because software/theia installs the go language server gopls (see 5a7fffa5) and at some point this required extending the previous caddy build method to make go installs both caddy and gopls (see f56c476a).

See this test result showing the problem

Fix software/theia by removing the now obsolete extension of the caddy build method and dropping gopls (which wasn't quite working anyway) in the same move.

EDIT: instead of dropping gopls, upgrade to gopls@v0.6.6 which can be installed using the standard go install method.

The changes to the `caddy` build method in https://lab.nexedi.com/nexedi/slapos/commit/1cfb657f05e3fd2d9e8b220c0945f8001104205f break `software/theia` because `software/theia` installs the go language server `gopls` (see https://lab.nexedi.com/nexedi/slapos/commit/5a7fffa540fe9ef9c30b2f373fe8ab78e49ce959) and at some point this required extending the previous caddy build method to make go installs both `caddy` and `gopls` (see https://lab.nexedi.com/nexedi/slapos/commit/f56c476a5fe5a9c1baa3547e76a623d5883be95d).

See [this test result](https://erp5js.nexedi.net/#/test_result_module/20210309-4AD9D074/22?uid=2040701155&selection_index=21&query=&list_method_template=https%3A%2F%2Ferp5js.nexedi.net%2Fhateoas%2FERP5Document_getHateoas%3Fmode%3Dsearch%26relative_url%3Dtest_result_module%252F20210309-4AD9D074%26form_relative_url%3Dportal_skins%2Ferp5_test_result%2FTestResult_view%2Flistbox%26list_method%3DcontentValues%26extra_param_json%3DeyJmb3JtX2lkIjogIlRlc3RSZXN1bHRfdmlldyJ9%26default_param_json%3DeyJwb3J0YWxfdHlwZSI6IFsiVGVzdCBSZXN1bHQgTGluZSJdLCAiaWdub3JlX3Vua25vd25fY29sdW1ucyI6IHRydWV9%7B%26query%2Cselect_list*%2Climit*%2Cgroup_by*%2Csort_on*%2Clocal_roles*%2Cselection_domain*%7D&sort_list%3Ajson=%5B%5B%22simulation_state%22%2C%22descending%22%5D%2C%5B%22string_index%22%2C%22ascending%22%5D%2C%5B%22errors%22%2C%22descending%22%5D%2C%5B%22failures%22%2C%22descending%22%5D%2C%5B%22title%22%2C%22ascending%22%5D%5D&editable=true&selection=6283c6f2e72ed289504e082ebff7b849e0f486b8&history=260380aaca7f199e2f7884b1035a228075074db4&page=form&view=view) showing the problem

Fix `software/theia` by removing the now obsolete extension of the `caddy` build method and dropping `gopls` (which wasn't quite working anyway) in the same move.

EDIT: instead of dropping `gopls`, upgrade to `gopls@v0.6.6` which can be installed using the standard `go install` method.

Edited Mar 15, 2021 by Xavier Thompson

software/theia: Adjust to Caddy build changes

Check out, review, and merge locally

Revert this commit

Cherry-pick this commit