Enable coding style test on erp5_hal_hjson_style, erp5_web_renderjs_ui_test and erp5_ui_test

This uses a different approach that what I was using in the past. I'm no longer trying to rename skins that does not match our naming conventions, but just adding them the the "ignore list".

This would still allow to detect when new wrongly named scripts are introduced without risking regressions when we rename a script that was used from some places we did not change (like project customisations).

/reviewed-on nexedi/erp5!1041

bt5/erp5_hal_json_style/TestTemplateItem/portal_components/test.erp5.testHalJsonStyle.py

@@ -16,7 +16,7 @@ import json
 import re
 import urllib
 
-from zope.globalrequest import setRequest
+from zope.globalrequest import setRequest #  pylint: disable=no-name-in-module, import-error
 from Acquisition import aq_base
 from Products.ERP5Form.Selection import Selection, DomainSelection
 

bt5/erp5_hal_json_style/bt/skip_coding_style_test

-1
\ No newline at end of file

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/AccessTabZuite_setPreference.py

@@ -7,6 +7,6 @@ if preference is None:
                                               portal_type="Preference")
 
 if preference.getPreferenceState() != "enabled":
-   preference.enable()
+  preference.enable()
 
 return 'Set Preference Successfully.'

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Base_directWorkflowAction.py

-request = context.REQUEST
 context.portal_workflow.doActionFor(context , workflow_action, comment='', **kw)
 message = 'direct workflow action done.'
 return context.Base_redirect('view', keep_items={'portal_status_message': message})

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_checkFormBoxDialog.py

+# this script has a parameter named `id`
+# pylint: disable=redefined-builtin
 """Redirect to Foo_viewFormBox"""
 msg = "%s %s %s %s" % (id, title, quantity, description)
 

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_getListBoxInReportModeSectionList.py

@@ -8,4 +8,4 @@ kw = {
 #  'selection_params': {},
   'temporary_selection': False,
 }
-return [ReportSection(**kw) for x in xrange(3)]
+return [ReportSection(**kw) for _ in xrange(3)]

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxDialogModeZuite_reset.py

@@ -13,7 +13,7 @@ default_columns = '\n'.join(( 'id | ID'
                             , 'title | Title'
                             , 'quantity | Quantity'
                             ))
-result = form.listbox.ListBox_setPropertyList( 
+form.listbox.ListBox_setPropertyList(
     field_title            = 'Bars'
   , field_columns          = default_columns
   , field_sort             = 'id'

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxZuite_reset.py

@@ -8,7 +8,7 @@ for name in ('foo_module', 'bar_module', 'foo_bar_module'):
 
 # Reset the foo module listbox
 form = context.FooModule_viewFooList
-result = form.listbox.ListBox_setPropertyList()
+form.listbox.ListBox_setPropertyList()
 
 #form.listbox.manage_edit(dict(
 #  lines = 3, all_columns = [], search_columns = [], sort_columns = [],
@@ -22,7 +22,7 @@ default_columns = '\n'.join(( 'id | ID'
                             , 'title | Title'
                             , 'quantity | Quantity'
                             ))
-result = form.listbox.ListBox_setPropertyList( 
+form.listbox.ListBox_setPropertyList( 
     field_title            = 'Foo Lines'
   , field_columns          = default_columns
   , field_sort             = 'id'

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_addAction.py

+# this script has a parameter named `id`
+# pylint: disable=redefined-builtin
 """Add or replace an action on a type informations from types tool.
 """
 assert context.meta_type in ('ERP5 Type Information', 'ERP5 Base Type'), context.meta_type

bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_deleteAction.py

+# this script has a parameter named `id`
+# pylint: disable=redefined-builtin
 """Delete an action on a type informations from types tool.
 """
 assert context.meta_type in ('ERP5 Type Information', 'ERP5 Base Type'), context.meta_type

bt5/erp5_ui_test/bt/skip_coding_style_test

-1
\ No newline at end of file

bt5/erp5_web_renderjs_ui_test/bt/skip_coding_style_test

-1
\ No newline at end of file

product/ERP5Type/CodingStyle.py

@@ -82,6 +82,7 @@ def getSkinPrefixList(self):
 
     'DCWorkflow', # some workflow script use this, not sure it's correct.
     'SkinsTool',
+    'MailHost',
 
     'Entity', # A base class for Person / Organisation
     'Zuite', # Products.Zelenium test suites
@@ -97,10 +98,32 @@ def getSkinPrefixList(self):
 
 
 # Some skin names that does not respect our conventions but are ignored, for example
-# when this naming is used by zope.
+# when this naming is used by zope or scripts that changing would be too hard.
 ignored_skin_id_set = {
   'twiddleAuthCookie',
   'setAuthCookie',
+  'ERP5Document_getHateoas',
+  'Script_getParams',
+  'AccessTabZuite_disablePreference',
+  'AccessTabZuite_setPreference',
+  'BTZuite_CommonTemplate',
+  'BTZuite_reset',
+  'FooViewDummyMultiListFieldDialog_setFieldPropertyList',
+  'FooView_setFieldsProperties',
+  'ListBoxDialogModeZuite_CommonTemplate',
+  'ListBoxDialogModeZuite_reset',
+  'ListBoxZuite_CommonTemplate',
+  'ListBoxZuite_getSelectionCheckedUidsAsHtml',
+  'ListBoxZuite_reset',
+  'ListBoxZuite_resetReportSelections',
+  'ListBoxZuite_setPreferredListboxViewModeLineCount',
+  'MatrixBoxZuite_CommonTemplate',
+  'OOoImportZuite_importFile',
+  'OOoImportZuite_reset',
+  'PTZuite_CommonTemplate',
+  'PortalType_addAction',
+  'PortalType_deleteAction',
+  'RelationFieldZuite_CommonTemplate',
 }
 
 # Generic method to check consistency of a skin item