An error slipped in 92da569e (slapos_jio: Drop Handlebars, 2022-06-08)

See merge request nexedi/slapos.core!488

  Most liketly a copy and paste mistake

    Whenever you define a slave, the option_index inst the software-type but the property of the dict/object.

See merge request nexedi/slapos.core!487

  This category is used whenever the user wants disallow allocation for the time been. It do not intend to re-open again after a procedure or do not intend to terminate the machine, just dont want anything be allocated on it.

See merge request nexedi/slapos.core!486

   category close and not closed, and do not auto cancel upgrades for computers for termination.

   This should be handled by setting never on upgrade scope.

   Those actions were dropped from ancient site and forgotten to be removed.

   Only Monitor Scope should be taken into account.

   Whenever allocation scope changes, the capacity is close, and the proper alarm will re-open it later a moment after. This prevents when you change from close to open, to get a miss-updated window, and something is allocated before it capacity is calculated.

     Do not touch on monitor scope, except when it is None or allocation is "Close Forever", this allow the user to keep monitoring closed computers (Maintenance, termination...), since ONLY allocation is closed, and the computer is supposed to work normally with whatever is inside.

  ... to decide which computers to select for check for upgrades

It's very useful in some deployments to control maximum time of
partition processing. This parmater can end up in slapos.cfg configuration
file or command line.

See merge request nexedi/slapos.core!480

See merge request nexedi/slapos.core!485

  ... to make publication_url happy

   Since the accounting workflow introduced Guard on start transition, it is required
   assignee or assignor to change the state (before Modify Portal content was enough).

   The script is invoke as Shadow user, and since destination section is set, the User
   automatically become Auditor (rather them Assignee) so it would imply a deeper
   change to relax security for the shadow user (not shadow person) just to invoke start.
   Not to mention HUGE security update to be done.

   Use Manager proxy role is not ideal, but it doesn't introduce a security issue while
   solve the problem until a deeper review on the roles for Shadow users takes place.

   Export last workflow state for Business Processes

See merge request nexedi/slapos.core!481

   Since instances typically only access master once a day, double the cache duration to ensure it wasnt flushed between the runs.

   The verification is somehow duplicated with the ComputeNode_checkSoftwareInstallationState.

   The script to check Software Installations already expose problems whenever a
   new software is requested and not built properly, which is the focus of the
   verification removed by this commit.

  Update script to handle also stalled cases

See merge request nexedi/slapos.core!477