slapos_crm: do not create event if the ticket exists

- drop Base_getSupportRequestInProgress
- drop SupportRequest_getLastEvent

master/bt5/slapos_cloud/SkinTemplateItem/portal_skins/slapos_cloud/Base_getSupportRequestInProgress.py

-portal = context.getPortalObject()
-
-return portal.portal_catalog.getResultValue(
-  portal_type='Support Request',
-  title={'query': title, 'key': 'ExactMatch'},
-  simulation_state=["validated", "submitted", "suspended"],
-  causality__uid=context.getUid(),
-)

master/bt5/slapos_cloud/SkinTemplateItem/portal_skins/slapos_cloud/Base_getSupportRequestInProgress.xml

-<?xml version="1.0"?>
-<ZopeData>
-  <record id="1" aka="AAAAAAAAAAE=">
-    <pickle>
-      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
-    </pickle>
-    <pickle>
-      <dictionary>
-        <item>
-            <key> <string>_bind_names</string> </key>
-            <value>
-              <object>
-                <klass>
-                  <global name="_reconstructor" module="copy_reg"/>
-                </klass>
-                <tuple>
-                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
-                  <global name="object" module="__builtin__"/>
-                  <none/>
-                </tuple>
-                <state>
-                  <dictionary>
-                    <item>
-                        <key> <string>_asgns</string> </key>
-                        <value>
-                          <dictionary>
-                            <item>
-                                <key> <string>name_container</string> </key>
-                                <value> <string>container</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_context</string> </key>
-                                <value> <string>context</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_m_self</string> </key>
-                                <value> <string>script</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_subpath</string> </key>
-                                <value> <string>traverse_subpath</string> </value>
-                            </item>
-                          </dictionary>
-                        </value>
-                    </item>
-                  </dictionary>
-                </state>
-              </object>
-            </value>
-        </item>
-        <item>
-            <key> <string>_params</string> </key>
-            <value> <string>title</string> </value>
-        </item>
-        <item>
-            <key> <string>id</string> </key>
-            <value> <string>Base_getSupportRequestInProgress</string> </value>
-        </item>
-      </dictionary>
-    </pickle>
-  </record>
-</ZopeData>

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/ComputeNode_checkSoftwareInstallationState.py

@@ -65,21 +65,19 @@ for software_installation in software_installation_list:
       return
 
     notification_message_reference = 'slapos-crm-compute_node_software_installation_state.notification'
-    event = support_request.SupportRequest_getLastEvent(ticket_title)
-    if event is None:
-      support_request.Ticket_createProjectEvent(
-        ticket_title, 'outgoing', 'Web Message',
-        portal.service_module.slapos_crm_information.getRelativeUrl(),
-        text_content=description,
-        content_type='text/plain',
-        notification_message=notification_message_reference,
-        #language=XXX,
-        substitution_method_parameter_dict={
-          'compute_node_title':context.getTitle(),
-          'compute_node_id':reference,
-          'last_contact':last_contact
-        }
-      )
+    support_request.Ticket_createProjectEvent(
+      ticket_title, 'outgoing', 'Web Message',
+      portal.service_module.slapos_crm_information.getRelativeUrl(),
+      text_content=description,
+      content_type='text/plain',
+      notification_message=notification_message_reference,
+      #language=XXX,
+      substitution_method_parameter_dict={
+        'compute_node_title':context.getTitle(),
+        'compute_node_id':reference,
+        'last_contact':last_contact
+      }
+    )
 
     support_request_list.append(support_request)
 

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/ComputeNode_checkState.py

@@ -76,36 +76,31 @@ if not should_notify:
         context.getTitle(), context.getReference(), last_contact)
 
 if should_notify:
-  support_request = context.Base_getSupportRequestInProgress(
-      title=node_ticket_title)
 
-  if support_request is None:
-    project = context.getFollowUpValue()
-    support_request = project.Project_createSupportRequestWithCausality(
-      ticket_title,
-      description,
-      causality=context.getRelativeUrl(),
-      destination_decision=project.getDestination()
-    )
+  project = context.getFollowUpValue()
+  support_request = project.Project_createSupportRequestWithCausality(
+    ticket_title,
+    description,
+    causality=context.getRelativeUrl(),
+    destination_decision=project.getDestination()
+  )
 
   if support_request is None:
     return
 
-  event = support_request.SupportRequest_getLastEvent(ticket_title)
-  if event is None:
-    support_request.Ticket_createProjectEvent(
-      ticket_title, 'outgoing', 'Web Message',
-      portal.service_module.slapos_crm_information.getRelativeUrl(),
-      text_content=description,
-      content_type='text/plain',
-      notification_message=notification_message_reference,
-      #language=XXX,
-      substitution_method_parameter_dict={
-        'compute_node_title':context.getTitle(),
-        'compute_node_id':reference,
-        'last_contact':last_contact,
-        'issue_document_reference': issue_document_reference
-      }
-    )
+  support_request.Ticket_createProjectEvent(
+    ticket_title, 'outgoing', 'Web Message',
+    portal.service_module.slapos_crm_information.getRelativeUrl(),
+    text_content=description,
+    content_type='text/plain',
+    notification_message=notification_message_reference,
+    #language=XXX,
+    substitution_method_parameter_dict={
+      'compute_node_title':context.getTitle(),
+      'compute_node_id':reference,
+      'last_contact':last_contact,
+      'issue_document_reference': issue_document_reference
+    }
+  )
 
   return support_request

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/InstanceTree_checkSoftwareInstanceState.py

@@ -58,19 +58,17 @@ for instance in software_instance_list:
     if support_request is None:
       return
 
-    event = support_request.SupportRequest_getLastEvent(ticket_title)
-    if event is None:
-      support_request.Ticket_createProjectEvent(
-        ticket_title, 'outgoing', 'Web Message',
-        portal.service_module.slapos_crm_information.getRelativeUrl(),
-        text_content=description,
-        content_type='text/plain',
-        notification_message=notification_message_reference,
-        #language=XXX,
-        substitution_method_parameter_dict={
-          'instance_tree_title':context.getTitle(),
-          'instance': instance.getTitle(),
-          'error_text': error_message
-        }
-      )
+    support_request.Ticket_createProjectEvent(
+      ticket_title, 'outgoing', 'Web Message',
+      portal.service_module.slapos_crm_information.getRelativeUrl(),
+      text_content=description,
+      content_type='text/plain',
+      notification_message=notification_message_reference,
+      #language=XXX,
+      substitution_method_parameter_dict={
+        'instance_tree_title':context.getTitle(),
+        'instance': instance.getTitle(),
+        'error_text': error_message
+      }
+    )
     return

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/Project_createSupportRequestWithCausality.py

@@ -3,7 +3,12 @@ project = context
 
 causality_value = portal.restrictedTraverse(causality)
 
-if causality_value.Base_getSupportRequestInProgress(title=title) is not None:
+if portal.portal_catalog.getResultValue(
+  portal_type='Support Request',
+  title={'query': title, 'key': 'ExactMatch'},
+  simulation_state=["validated", "submitted", "suspended"],
+  causality__uid=causality_value.getUid(),
+) is not None:
   return
 
 destination_decision_value = portal.restrictedTraverse(destination_decision)

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_getLastEvent.py

-portal = context.getPortalObject()
-return portal.portal_catalog.getResultValue(
-             title={'query': title, 'key': 'ExactMatch'},
-             follow_up__uid=context.getUid(),
-             portal_type=portal.getPortalEventTypeList(),
-             sort_on=[('delivery.start_date', 'DESC')])

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_getLastEvent.xml

-<?xml version="1.0"?>
-<ZopeData>
-  <record id="1" aka="AAAAAAAAAAE=">
-    <pickle>
-      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
-    </pickle>
-    <pickle>
-      <dictionary>
-        <item>
-            <key> <string>_bind_names</string> </key>
-            <value>
-              <object>
-                <klass>
-                  <global name="_reconstructor" module="copy_reg"/>
-                </klass>
-                <tuple>
-                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
-                  <global name="object" module="__builtin__"/>
-                  <none/>
-                </tuple>
-                <state>
-                  <dictionary>
-                    <item>
-                        <key> <string>_asgns</string> </key>
-                        <value>
-                          <dictionary>
-                            <item>
-                                <key> <string>name_container</string> </key>
-                                <value> <string>container</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_context</string> </key>
-                                <value> <string>context</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_m_self</string> </key>
-                                <value> <string>script</string> </value>
-                            </item>
-                            <item>
-                                <key> <string>name_subpath</string> </key>
-                                <value> <string>traverse_subpath</string> </value>
-                            </item>
-                          </dictionary>
-                        </value>
-                    </item>
-                  </dictionary>
-                </state>
-              </object>
-            </value>
-        </item>
-        <item>
-            <key> <string>_params</string> </key>
-            <value> <string>title</string> </value>
-        </item>
-        <item>
-            <key> <string>id</string> </key>
-            <value> <string>SupportRequest_getLastEvent</string> </value>
-        </item>
-      </dictionary>
-    </pickle>
-  </record>
-</ZopeData>

master/bt5/slapos_crm/SkinTemplateItem/portal_skins/slapos_crm_monitoring/SupportRequest_updateMonitoringState.py

@@ -16,19 +16,17 @@ if document.getSlapState() == "destroy_requested":
   """
 
   ticket_title = "Instance Tree was destroyed was destroyed by the user"
-  event = context.SupportRequest_getLastEvent(ticket_title)
-  if event is None:
-    context.Ticket_createProjectEvent(
-      ticket_title, 'outgoing', 'Web Message',
-      portal.service_module.slapos_crm_information.getRelativeUrl(),
-      text_content=message,
-      content_type='text/plain',
-      notification_message="slapos-crm-support-request-close-destroyed-notification",
-      #language=XXX,
-      substitution_method_parameter_dict={
-        'instance_tree_title': document.getTitle()
-      }
-    )
+  event = context.Ticket_createProjectEvent(
+    ticket_title, 'outgoing', 'Web Message',
+    portal.service_module.slapos_crm_information.getRelativeUrl(),
+    text_content=message,
+    content_type='text/plain',
+    notification_message="slapos-crm-support-request-close-destroyed-notification",
+    #language=XXX,
+    substitution_method_parameter_dict={
+      'instance_tree_title': document.getTitle()
+    }
+  )
 
   try:
     context.validate()

master/bt5/slapos_erp5/TestTemplateItem/portal_components/test.erp5.testSlapOSCodingStyle.py

@@ -113,7 +113,6 @@ def makeTestSlapOSCodingStyleTestCase(tested_business_template):
         'slapos_cloud/SoftwareRelease_getRelatedNetworkList',
         'slapos_cloud/SoftwareRelease_getUsableComputeNodeList',
         'slapos_cloud/SoftwareInstance_viewRenameAndRequestDestroyAction',
-        'slapos_cloud/Base_getSupportRequestInProgress',
         'slapos_cloud/SoftwareInstance_checkDuplicationOnInstanceTreeConsistency',
         'slapos_cloud/ComputerNetwork_getRelatedSoftwareReleaseList',
         'slapos_crm_monitoring/ComputeNode_checkInstanceOnCloseAllocation',
@@ -125,7 +124,6 @@ def makeTestSlapOSCodingStyleTestCase(tested_business_template):
         'slapos_crm_monitoring/SupportRequest_getMonitorUrl',
         'slapos_crm_monitoring/SupportRequest_recheckMonitoring',
         'slapos_crm_monitoring/Event_checkCustomerAsSourceOrDestinationConsistency',
-        'slapos_crm_monitoring/SupportRequest_getLastEvent',
         'slapos_crm_monitoring/Project_createSupportRequestWithCausality',
         'slapos_crm/RegularisationRequest_afterClone',
         'slapos_crm/RegularisationRequest_getResourceItemList',