Commit bcc96031 authored by Rafael Monnerat's avatar Rafael Monnerat

slapos_accounting: invoke startBuilding after include a Sale Transaction Line.

parent b7796935
......@@ -65,9 +65,7 @@
</item>
<item>
<key> <string>delivery_after_generation_script_id</string> </key>
<value>
<none/>
</value>
<value> <string>SaleInvoiceTransaction_postSlapOSSaleInvoiceTransactionLineGeneration</string> </value>
</item>
<item>
<key> <string>delivery_cell_collect_order</string> </key>
......
from Products.ERP5Type.Message import translateString
comment = translateString('Initialised by Delivery Builder.')
isTransitionPossible = context.getPortalObject().portal_workflow.isTransitionPossible
if isTransitionPossible(context, 'startBuilding'):
  • isTransitionPossible is in my experience causing problems, it's a bit like try: except: pass. If there's a reason why the transition should not be available, it might be better to check for that reason instead and fail early if something is not what expect.

    That's just my personal preference, after having to debug problems hidden behind a isTransitionPossible. If that's properly covered by test, the end result might be same.

Please register or sign in to reply
context.startBuilding(comment=comment)
<?xml version="1.0"?>
<ZopeData>
<record id="1" aka="AAAAAAAAAAE=">
<pickle>
<global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>Script_magic</string> </key>
<value> <int>3</int> </value>
</item>
<item>
<key> <string>_bind_names</string> </key>
<value>
<object>
<klass>
<global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
</klass>
<tuple/>
<state>
<dictionary>
<item>
<key> <string>_asgns</string> </key>
<value>
<dictionary>
<item>
<key> <string>name_container</string> </key>
<value> <string>container</string> </value>
</item>
<item>
<key> <string>name_context</string> </key>
<value> <string>context</string> </value>
</item>
<item>
<key> <string>name_m_self</string> </key>
<value> <string>script</string> </value>
</item>
<item>
<key> <string>name_subpath</string> </key>
<value> <string>traverse_subpath</string> </value>
</item>
</dictionary>
</value>
</item>
</dictionary>
</state>
</object>
</value>
</item>
<item>
<key> <string>_params</string> </key>
<value> <string>related_simulation_movement_path_list=None, **kw</string> </value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>SaleInvoiceTransaction_postSlapOSSaleInvoiceTransactionLineGeneration</string> </value>
</item>
</dictionary>
</pickle>
</record>
</ZopeData>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment