- 06 Sep, 2018 7 commits
-
-
Vincent Pelletier authored
For some reason, unit tests all broke while testing this revision. The relation between both is not clear to me (this code has worked for me). In doubt, I revert it for now. This reverts commit 0057272c.
-
Vincent Pelletier authored
getRelativeUrl and restrictedTraverse are expensive operations. Do not involve them pointlessly. Also, boolean evaluation of lists is a thing.
-
Vincent Pelletier authored
A pprofile run shows DateTime_or_None costing 3ms per value (including all callees). While this may seem low, it is common to receive hundreds of such values in single query results (ex: web mode document & webpage lookups), so the total time spent parting dates per query can become significantly larger than the time to execute the query itself. In the case of this measure setup, 504 dates were processed for a total of 1.5 seconds. DateTime is slow to parse strings because it cannot rely on a pre-known format. With MySQL/MariaDB, the format is know for those column types, so implement specific parsing to get better performance. On the same setup, pprofile run shows a parsing time of 72µs per value in DATETIME_to_DateTime_or_None, or 39ms total. DATE_to_DateTime_or_None should not deviate significantly from this.
-
Jérome Perrin authored
CategoryTool.getCategoryList dynamically returns categories as member of themselves, but there were cases (for example after changing id) where the membership happens to be saved in `categories` attribute and later caused problems after clones or renames. To prevent these problems, CategoryTool._setCategoryList detects the membership to self and does not save it as part of .categories Remove no longer needed after clone script. Remove tests which no longer makes sense now that setCategoryList does not add membership to self.
-
Jérome Perrin authored
Add a warning about the doubt regarding the example in comment, to me this does not depend on category being member of self. One reason for the membership to self - in my understanding - is to make inventory API work the same with movement to meta node categories or movement to nodes member of this category when using getInventory(node_category=(the meta node category)) Also remove comment about what's said to be a "mistake" ( the svn url should be equivalent to git commit eedb2b29 ) because this was never reverted and does not seem to be a mistake, the purpose of the change is to prevent having categories member of themselves twice.
-
Jérome Perrin authored
This was partially convered by test_13b_RenameCategoryUsingCutAndPaste and test_13_RenameCategory but not for the edge case where category membership to self is set in .categories
-
Jérome Perrin authored
Add a few assertions and comment to make it clearer what is the expected behavior on related documents and on the category itself when categories are renamed or moved.
-
- 27 Aug, 2018 2 commits
-
-
Vincent Bechu authored
-
Richard authored
/reviewed-on nexedi/erp5!728
-
- 24 Aug, 2018 3 commits
-
-
Julien Muchembled authored
With commit babbf56f, some objects that were not indexed are now indexed, and this fails when these objects can't be indexed. An exemple is when a PythonScript is stored inside a Web Site: Traceback (innermost last): Module Products.CMFActivity.ActivityTool, line 1360, in invokeGroup traverse(method_id)(expanded_object_list) Module Products.ERP5Catalog.CatalogTool, line 939, in catalogObjectList super(CatalogTool, self).catalogObjectList(tmp_object_list, **m.kw) Module Products.ZSQLCatalog.ZSQLCatalog, line 828, in catalogObjectList catalog_value=catalog, Module Products.ERP5Catalog.CatalogTool, line 875, in wrapObjectList - __traceback_info__: (<PythonScript at /erp5/web_site_module/...>,) and document_object._getAcquireLocalRoles(): AttributeError: _getAcquireLocalRoles Before, such object was skipped because it does not have recursiveReindexObject.
-
Sven Franck authored
/reviewed-on nexedi/erp5!725
-
Vincent Bechu authored
-
- 23 Aug, 2018 14 commits
-
-
Vincent Bechu authored
-
Richard authored
-
Richard authored
[erp5_notebook]: add workflow to notebook, add erp5_dms as dependency, load iodide notebook in notebook module, change indentation of gadget_officejs_jio_notebook.js, update security settings
-
Richard authored
-
Richard authored
-
Richard authored
-
Richard authored
-
Laurent S authored
-
Laurent S authored
-
Laurent S authored
-
Laurent S authored
-
Laurent S authored
-
Yusei Tahara authored
-
Yusei Tahara authored
-
- 22 Aug, 2018 1 commit
-
-
Xiaowu Zhang authored
this commit should fix random plus button not present issue when open sort editor the reason is sort editor is opened before launcher call editor_panel.close() so wait for page loaded before open sort editor
-
- 21 Aug, 2018 6 commits
-
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Sebastien Robin authored
This hopefully fix the random issue of having test results not linked to a project. Indeed, distributor/createTestResult was called in two different times: - by the testnode, with the project title - by the runTestSuiteCommand, without the project title. This was not an issue most of the time, since the test result is already created. But if it was not there (like due to a cancelled test), a test result without project was created
-
Yusei Tahara authored
-
Yusei Tahara authored
-
- 20 Aug, 2018 2 commits
-
-
Yusei Tahara authored
erp5/tests/testERP5TestNode.py: Fix test_scalability_04_constructProfile. repository option is required for scalability test profile and it was added on commit 58d92a84.
-
Yusei Tahara authored
erp5/tests/testERP5TestNode.py: Fix test_zzzz_scalability_19_xxxx. prepareFrontendMasterInstance was removed on commit 4048ab39.
-
- 17 Aug, 2018 5 commits
-
-
Yusei Tahara authored
-
Yusei Tahara authored
erp5/util/testnode, scalability_test: Stop using a dummy frontend master and use host.vifib.net frontend with a valid SSL certificate instead. Always use https.
-
Yusei Tahara authored
erp5/util/testnode: hosting subscription url was not updated once it was set. As a result, since testnode watched an old destroyed instance, the next test never started. Thus don't store hosting subscription url. It changes from time to time.
-
Yusei Tahara authored
-
Yusei Tahara authored
-