Skip to content

erp5
erp5
Commit 7b9c2be7 authored by Vincent Pelletier's avatar Vincent Pelletier
Browse files
Options

erp5_base: Do not explicitly set accounts on movement. 

The resource-to-account relationship is intended to be declared by
predicates (which are used here), but should only be explicitely set on
movements when they *differ* from these rules, as special overrides.
So, setting default accounts on movement is unnecessary work:
- predicate lookup is expensive, and business-model-specific shortcuts may
  be available which such generic implementation cannot implement
- multiplying unneeded relationships increases category table size, which
  is generally detrimental to performances
parent 003e34c7
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 193 deletions
bt5/erp5_base/WorkflowTemplateItem/portal_workflow/movement_resource_interaction_workflow/interactions/setSourceDestinationAccount.xml deleted 100644 → 0
View file @ 003e34c7
<?xml version="1.0"?>
<ZopeData>
<record id="1" aka="AAAAAAAAAAE=">
<pickle>
<global name="InteractionDefinition" module="Products.ERP5.Interaction"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>actbox_category</string> </key>
<value> <string>workflow</string> </value>
</item>
<item>
<key> <string>actbox_name</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>actbox_url</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>activate_script_name</string> </key>
<value>
<tuple/>
</value>
</item>
<item>
<key> <string>after_script_name</string> </key>
<value>
<list>
<string>Movement_copyAccountFromPath</string>
</list>
</value>
</item>
<item>
<key> <string>before_commit_script_name</string> </key>
<value>
<tuple/>
</value>
</item>
<item>
<key> <string>description</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>guard</string> </key>
<value>
<none/>
</value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>setSourceDestinationAccount</string> </value>
</item>
<item>
<key> <string>method_id</string> </key>
<value>
<list>
<string>_setResource.*</string>
</list>
</value>
</item>
<item>
<key> <string>once_per_transaction</string> </key>
<value> <int>1</int> </value>
</item>
<item>
<key> <string>portal_type_filter</string> </key>
<value>
<none/>
</value>
</item>
<item>
<key> <string>portal_type_group_filter</string> </key>
<value>
<none/>
</value>
</item>
<item>
<key> <string>script_name</string> </key>
<value>
<tuple/>
</value>
</item>
<item>
<key> <string>temporary_document_disallowed</string> </key>
<value> <int>0</int> </value>
</item>
<item>
<key> <string>title</string> </key>
<value> <string></string> </value>
</item>
<item>
<key> <string>trigger_type</string> </key>
<value> <int>2</int> </value>
</item>
</dictionary>
</pickle>
</record>
</ZopeData>
bt5/erp5_base/WorkflowTemplateItem/portal_workflow/movement_resource_interaction_workflow/scripts/Movement_copyAccountFromPath.py deleted 100644 → 0
View file @ 003e34c7
'''Lookup source account & destination account from applicable paths and copy
them on this movement.
'''
movement = state_change['object']
searchPredicateList = movement.getPortalObject().portal_domains.searchPredicateList
resource = movement.getResourceValue()
if resource is not None:
if not movement.getDestinationAccount():
for predicate in searchPredicateList(
context=movement, portal_type='Purchase Supply Line'):
if predicate.getDestinationAccount():
movement.setDestinationAccount(predicate.getDestinationAccount())
break
if not movement.getSourceAccount():
for predicate in searchPredicateList(
context=movement, portal_type='Sale Supply Line'):
if predicate.getSourceAccount():
movement.setSourceAccount(predicate.getSourceAccount())
break
else:
movement.setSourceAccount(None)
movement.setDestinationAccount(None)
bt5/erp5_base/WorkflowTemplateItem/portal_workflow/movement_resource_interaction_workflow/scripts/Movement_copyAccountFromPath.xml deleted 100644 → 0
View file @ 003e34c7
<?xml version="1.0"?>
<ZopeData>
<record id="1" aka="AAAAAAAAAAE=">
<pickle>
<global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>Script_magic</string> </key>
<value> <int>3</int> </value>
</item>
<item>
<key> <string>_bind_names</string> </key>
<value>
<object>
<klass>
<global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
</klass>
<tuple/>
<state>
<dictionary>
<item>
<key> <string>_asgns</string> </key>
<value>
<dictionary>
<item>
<key> <string>name_container</string> </key>
<value> <string>container</string> </value>
</item>
<item>
<key> <string>name_context</string> </key>
<value> <string>context</string> </value>
</item>
<item>
<key> <string>name_m_self</string> </key>
<value> <string>script</string> </value>
</item>
<item>
<key> <string>name_subpath</string> </key>
<value> <string>traverse_subpath</string> </value>
</item>
</dictionary>
</value>
</item>
</dictionary>
</state>
</object>
</value>
</item>
<item>
<key> <string>_params</string> </key>
<value> <string>state_change</string> </value>
</item>
<item>
<key> <string>_proxy_roles</string> </key>
<value>
<tuple>
<string>Manager</string>
</tuple>
</value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>Movement_copyAccountFromPath</string> </value>
</item>
</dictionary>
</pickle>
</record>
</ZopeData>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7