See merge request nexedi/erp5!1835

See merge request nexedi/erp5!1841

See merge request nexedi/erp5!1831

See !1850

Pause to make sure the server has time to process the request.
This is of course not a good fix, but the future of this code is really
uncertain, so this should at least fix the failing test.

When account number method is set to account reference and the
transaction line has a node acquired from the invoice source or
destination organisation or person and when this node has a reference,
then this was displayed as an account reference.

We set a reference on Client 1 organisation to reproduce the problem.

Make it part of the caching method id so that changing the preference
immediately show new accounts.

This also moves the "user_name" argument that was an artificial parameter
not used only here to make the cache vary to the cache id, for
consistency and clarity.

This fixes dict formatting which was formatted like this with too long
values:

  {
    "a":
    "b"
  }

after we updated cloudooo.erp5.net with cloudooo!32

See merge request !1785

This method raises the same error as jwt's claim validator, as it was intended to be
called from the same exception handling block. So move it from "else" blocks into
the corresponding "try" block.

  We must ensure that some Web Section (under a website with must-revalidate caching policy) can have a session that isn't stored.

  Different from no-cache (that is similar to must-revalidate + max-age=0), no-store tells the client (and frontends) that it must not cache the content ever.

  Since we issue an no-store and no 304s, the Last-Modified could confuse the frontend if If-Modified-Since header is present on the request.

  If-Modified-Since is sent, the ERP5 wont return with 304, so we don't expect that the frontend does it (but it does), so since we don't expect that user stores the last request it makes no sense to return with Last-Modified.

A Telephone type object is defined by its number, and it's country (ie: country code). See Telephone portal type and property sheet.
So here, having only the number is incomplete.

using pdfjs-3.11.174-legacy-dist.zip

Note: viewer.js is modified to do nothing in webViewerLoad (one line
with return "ERP5 patch: disable here" is added at the top of this
function) because we do the initialization in the gadget.
I think something similar was also done with the previous version.

The tests were extended to cover:

 - opening an empty or broken PDF: this should not crash
 - clicking save: this should not crash and the updated document should
   render properly. The save action replaces the ERP5 document content
   with the content from the editor, so if user for example added
   annotations or draw on the PDF, the modified version is saved.
   We don't use this feature and it's not so easy to test, so for now
   the test only covers the "it should not crash and it should not
   break the document".
 - entering wrong password for encrypted PDFs should not crash

This was working fine (although not python3 ready), but was not tested

Messages are translated when displayed, Base_translateString translates
once and for all with the current language.

Introduce another assertImageMatchSnapshot which stops on failure,
following the behavior of other selenium assertions.

Also output more details when the dimensions are different.

See merge request nexedi/erp5!1838

See merge request nexedi/erp5!1833

This would catch potential problems only occuring when the location has
been granted.

Without this field, sync does not work when location was granted.

Fixes error in console:

Refused to load manifest from <URL> because it violates the following
Content Security Policy directive: "default-src 'none'".
Note that 'manifest-src' was not explicitly set, so 'default-src' is
used as a fallback.

Use the new KeyboardEvent instead of deprecated KeyEvent and
initKeyEvent, see
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/initKeyEvent#specifications
and
nexedi/slapos!800 (comment 115488)

In old firefox dispatching a fake keydown event with keycode 13 (enter)
on an input field was enough to submit the corresponding form, like in
a real browser and like in webdriver, but in modern browsers this no
longer submits the form. Adjust the logic to submit the form to mimic
real browser behavior.
Co-authored-by: Romain Courteaud <romain@nexedi.com>

When I run this test on chrome, the div has two classes, spreadsheet
and jexcel_tab, this fixes a failure that the element is not found in
erp5_officejs_ui_test:testFunctionalOfficeJSWebTable

We were setting the value to a string with seconds like
`2010-01-01T00:00:00` and all the tests were testing that the value of
the input element was exactly the same (ie. with seconds), but [the spec]
mentions that value is:

 - A valid date string representing the date.
 - A U+0054 LATIN CAPITAL LETTER T character (T).
 - A valid time string representing the time, expressed as the shortest
  possible string for the given time (e.g. omitting the seconds
  component entirely if the given time is zero seconds past the minute).

The test works fine when running on firefox 68 (the one from testnodes),
because this version does not implements datetime-local and such field
behave like text inputs, but when running with a modern browser
implementing the spec, the test fails because the value from the fields
`.value` does not have seconds.

While the change to rjs_gadget_erp5_datetimefield_js is not strictly
necessary, because when setting the value on a datetime-local the value
will be normalized and having 00 seconds or omitting the seconds is same,
this is done to keep the test passing on old browsers without support
for datetime-local fields.

[the spec]: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#concept-datetime-local

so that we can see them on testnode.

Because they depend on the browser version, the window size, the
available fonts and maybe other things, snapshot tests basically only
work when running on testnode and fail when we run the tests from our
browsers locally. With this option, the difference of snapshot are not
considered a failure.

Also adjust snapshots, because this adds a checkbox in the upper frame,
the viewport of the test frame is now a little bit taller.

nexedi/erp5@3ea8d425 (comment 193284)

See merge request nexedi/erp5!1837

This fixes a regression from 3ea8d425 (core: don't show list of items
in initial business template install, 2023-10-10), this dialog was also
used for business template update and it was never showing the list of
item.

This code seems to have been pushed accidentally as part of 6e5e8e8c
(fixup! test: follow recent ImageMagick spec., 2023-10-11)

This reverts commit 14831fae.

As discussed in 14831fae (comment 188678)
this change breaks test and it seems more natural to implement this with
listbox's sort parameter.

This change will be pushed again, probably as part of
!1305