Follow nexedi/erp5@a659b01c

Same behaviour than File/Image

It is needed if a module contains multiple object's portal types.

- this reverts commit d8119beb.
- risk of allowing JS injection

Fix po_import behavior in Python 2.

Newer versions of polib accept only unicode strings in the
`pofile` function (because they check if they start by the decoded
version of the BOM).
I changed the `data` that is passed to `pofile` to be a unicode
string in Python 2 too. This seems to work locally in my old
version of polib, so that at least the old behavior should be
kept the same.
Co-authored-by: Carlos Ramos Carreño <carlos.ramos@nexedi.com>
Co-authored-by: Jérome Perrin <jerome@nexedi.com>

See merge request nexedi/erp5!1953

Because the librairies used here were never ported to python3.

Notable changes:

  - ERP5Site_createGoogleUserToOAuth is dropped
  - internal API changed radically, so customizations made by overriding
    scripts are broken.
  - the core logic is now implemented in a connector class (still in
    portal_oauth for simplicity, but it would be simpler to move it to
    portal_web_services)

No changes required in the google console, the redirect uri is still
ERP5Site_receiveGoogleCallback

See merge request nexedi/erp5!1949

to make sure test terminates in case of problems with webdav server

When a test needs to login as manager again, the best way is to use
${manager_username} and ${manager_password} set in cookies before
running tests.

This is continuation of 445e8fa8 (ERP5TypeTestCase: rework default
manager password generation, 2024-05-27)

form_dialog was different from form_render (that is used in form_view
and form_list) regarding the <legend> element for form groups:

 - the element was unconditionally present, unlike form_render where it
 is only displayed if non empty
 - the text was not translated

See merge request nexedi/erp5!1950

as it is done in other places of this file

When pasting an image in CKEditor, the image was displayed twice.
This behaviour is due to the new paste-as-base64 feature implemented in CKE,
which conflict with existing plugins implementing the same feature.

To solve it, add `clipboard_handleImages` option to the CKE configuration object,
which disables its own image-pasting feature.

See https://github.com/ckeditor/ckeditor4/issues/4874 for the corresponding issue on CKEditor’s repository.

/cc @jerome @romain @tomo
/reviewed-by @jerome
/reviewed-on nexedi/erp5!1951

Otherwise, we may get error if we have special characters

fix convertToERP5Workflow() for the case where permission_roles is not yet configured.

if acquire_permission is not yet set in a Workflow State, we should consider it as 'acquire all permissions', like DCWorkflow implementation.

If state_permission_role_list_dict is not yet set in a Workflow State, the UI displays permission/role table with all unchecked.
Once we save it in Permissions tab without checking anything, state_permission_role_list_dict will become like
  {'Access contents information': (),
   'Add portal content': (),
   'Modify portal content': (),
   'View': ()}
This commit will make the behaviour same for these 'before save' and 'after save' cases as the UI displays exactly same.

See merge request nexedi/erp5!1941

In Check Source Code report on business template and CodingStyle tests,
the lines were off by 1 and column off by 2 for python scripts.

The default manager user (ERP5TypeTestCase) now have a random password
generated at the beginning of test. The password is stored as a class
attribute of the test case instance.
Many tests have been updated to not generate manager user and use the
existing one instead. When tests need to create users (for example
users in the root acl_users), we try to give them a random password and
to delete the users afterward.

For functional tests, the approach is that ERP5TypeFunctionalTestCase
sets cookies with manager username and password before running zelenium
tests, so that in case tests want to log in again as manager, they can
read the username and password from cookies.

Another significant changes is that we no longer have the same user in
ERP5/acl_users and /acl_users, some tests were logging in as the root
user in ways that never seemed intentional.

This also revealed (through test_manager_actions_on_portal from
testERP5Core) that some tests were running with a user without all the
expected permissions and the "Manager Components" actions was not
visible for the default manager user. Fixing this also revealed that
two actions ("Manage Components" and "Manage Callables") had the same
priority, so the later was modified to use a different priority.

pycrypto is unmaintained and the python3 version no longer work with
buildout 3 (it uses a tricky way to run 2to3 in setup.py that no longer
happens with pip based buildout3)

Also make the rest of this file python3 compatible.

There is no fallback on group id, if no group title, no legend is
displayed

This is same as "xhtml_style: display form groups legends", but applied
to ERP5JS.

The returned type of `group_list` changed in the API, it use to be a
list of lists with 2 elements: group id (str) and field list (list),
it is now a list with 3 elements: group id (str), field list (list)
and group title (str).

There's now a new `legend` element in the DOM, only when the group has a
title.

For erp5_web it is possible to define form groups following a naming
rule "group_id (Group Title)" and "Group Title" is displayed in a legend,
according to this comment in form_render.zpt:

> It is possible to specify a group id and a group title by naming a group following the
>   "group id (Group Title)" pattern. In this case the group id will be used as fieldset css
>   class and as tag id. The group title will be used as a legend for the fieldset. If no group
>   title is found, we use group id as title.

For historical reasons, the legend was hidden, this feature was only
used in erp5_web, but this does not seem bad to enable it in
erp5_xhtml_style as well.

At the moment, this is not used much, this script

```py
for sf in context.getPortalObject().portal_skins.objectValues():
  for f in sf.objectValues():
    if not hasattr(f, 'get_groups'):
      continue
    for group in f.get_groups():
      if '(' in group:
        print('/'.join(f.getPhysicalPath()[1:]), group)

return printed
```

when running on a site with many business template installed yields

```
erp5/portal_skins/erp5_base/EmbeddedFile_view left (Document Reference)
erp5/portal_skins/erp5_base/EmbeddedFile_view right (Publication Information)
erp5/portal_skins/erp5_base/NotificationMessage_viewEditor left (Page Properties)
erp5/portal_skins/erp5_knowledge_pad/Base_viewKnowledgePadFieldLibrary right column (Toolbox)
erp5/portal_skins/erp5_web/StaticWebSite_viewRedirectAssistConfiguration left (Style)
erp5/portal_skins/erp5_web/WebPage_view left (Page Properties)
erp5/portal_skins/erp5_web/WebPage_view right (Publication)
erp5/portal_skins/erp5_web/WebPage_view bottom (Content)
erp5/portal_skins/erp5_web/WebPage_viewEditor left (Page Properties)
erp5/portal_skins/erp5_web/WebPage_viewFieldLibrary left (Page Properties)
erp5/portal_skins/erp5_web/WebPage_viewFieldLibrary right (Publication)
erp5/portal_skins/erp5_web/WebPage_viewFieldLibrary bottom (Content)
erp5/portal_skins/erp5_web/WebSection_view left (Content)
erp5/portal_skins/erp5_web/WebSection_view right (Layout)
erp5/portal_skins/erp5_web/WebSection_view center (Description)
erp5/portal_skins/erp5_web/WebSection_view bottom (Subsections)
erp5/portal_skins/erp5_web/WebSection_viewDefaultThemeConfiguration left (Style)
erp5/portal_skins/erp5_web/WebSection_viewDefaultThemeConfiguration right (Widgets)
erp5/portal_skins/erp5_web/WebSite_view left (Content)
erp5/portal_skins/erp5_web/WebSite_view right (Layout)
erp5/portal_skins/erp5_web/WebSite_view center (Description)
erp5/portal_skins/erp5_web/WebSite_view bottom (Subsections)
erp5/portal_skins/erp5_web/WebSite_viewRegistrationDialog left (User Login)
erp5/portal_skins/erp5_web/WebSite_viewRegistrationDialog right (User Identity)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout left column transparent (Logo)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout left column (Navigation)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout left column (Sections)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout left column (Contents)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout left column (Search)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout left column (Debug)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout right column (News)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout right column (Toolbox)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_content_layout right column (Highlight)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout left column transparent (Logo)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout left column (Navigation)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout left column (Sections)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout left column (Contents)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout left column (Search)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout left column (Debug)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout right column (News)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout right column (Toolbox)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout right column (Highlight)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_layout right column (Action)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout left column transparent (Logo)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout left column (Navigation)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout left column (Sections)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout left column (Contents)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout left column (Search)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout left column (Debug)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout right column (News)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout right column (Toolbox)
erp5/portal_skins/erp5_web_minimal_theme/erp5_web_section_layout right column (Highlight)
erp5/portal_skins/erp5_dms/Document_viewFieldLibrary left (Document Reference)
erp5/portal_skins/erp5_dms/Document_viewFieldLibrary right (Publication Information)
erp5/portal_skins/erp5_dms/ExternalSource_view left (Document Reference)
erp5/portal_skins/erp5_dms/ExternalSource_view right (Publication Information)
erp5/portal_skins/erp5_dms/OOoDocument_view left (Document Reference)
erp5/portal_skins/erp5_dms/OOoDocument_view right (Publication Information)
erp5/portal_skins/erp5_dms_base/File_view left (Document Reference)
erp5/portal_skins/erp5_dms_base/File_view right (Publication Information)
erp5/portal_skins/erp5_dms_base/Image_view left (Document Reference)
erp5/portal_skins/erp5_dms_base/Image_view right (Publication Information)
erp5/portal_skins/erp5_dms_web/WebIllustration_view left (Document Reference)
erp5/portal_skins/erp5_dms_web/WebIllustration_view right (Publication Information)
erp5/portal_skins/erp5_dms_web/WebIllustration_view bottom (Preview)
erp5/portal_skins/erp5_dms_web/WebPage_view left (Document Reference)
erp5/portal_skins/erp5_dms_web/WebPage_view right (Publication Information)
erp5/portal_skins/erp5_dms_web/WebPage_view bottom (Preview)
erp5/portal_skins/erp5_multimedia/Sound_view left (Document Reference)
erp5/portal_skins/erp5_multimedia/Sound_view right (Publication Information)
erp5/portal_skins/erp5_run_my_doc/Review_view left (Document Reference)
erp5/portal_skins/erp5_run_my_doc/Review_view right (Publication Information)
erp5/portal_skins/erp5_run_my_doc/TestPage_view left (Document Reference)
erp5/portal_skins/erp5_run_my_doc/TestPage_view right (Publication Information)
erp5/portal_skins/erp5_run_my_doc/TestPage_view bottom (Preview)
erp5/portal_skins/erp5_run_my_doc/TestPage_viewFieldLibrary left (Page Properties)
erp5/portal_skins/erp5_run_my_doc/TestPage_viewFieldLibrary right (Publication)
erp5/portal_skins/erp5_run_my_doc/TestPage_viewFieldLibrary bottom (Content)
erp5/portal_skins/erp5_run_my_doc/TestPage_viewTestReport bottom (Content)
erp5/portal_skins/erp5_officejs_slideshow_editor/WebPage_viewForSlideshowEditor bottom (Preview)
erp5/portal_skins/erp5_credential/CredentialRequest_view left (Personal Information)
erp5/portal_skins/erp5_credential/CredentialRequest_view left (Organisation Information)
erp5/portal_skins/erp5_credential/CredentialRequest_view right (Login Information)
erp5/portal_skins/erp5_credential/CredentialUpdate_view left (Personal Information)
erp5/portal_skins/erp5_credential/CredentialUpdate_view left (Organisation Information)
erp5/portal_skins/erp5_credential/CredentialUpdate_view right (Login Information)
erp5/portal_skins/erp5_km/WebSection_viewKMMinimalThemeConfiguration left (Colors)
erp5/portal_skins/erp5_km/WebSection_viewKMMinimalThemeConfiguration right (Static Content)
erp5/portal_skins/erp5_km/WebSection_viewKMMinimalThemeConfiguration left (Navigation)
erp5/portal_skins/erp5_km/WebSection_viewKMMinimalThemeConfiguration right (Gadgets)
erp5/portal_skins/erp5_km_theme/Base_viewKMFieldLibrary right column (Toolbox)
erp5/portal_skins/erp5_km_theme/WebSection_viewMinimalKMWidgetFieldLibrary bottom gadget (Bottom Gadget)
erp5/portal_skins/erp5_km_theme/WebSection_viewMinimalKMWidgetFieldLibrary right column gadget (Right Gadget)
erp5/portal_skins/erp5_km_theme/erp5_km_minimal_content_layout bottom gadget (Bottom Gadget)
erp5/portal_skins/erp5_km_theme/erp5_km_minimal_content_layout right column gadget (Right Gadget)
erp5/portal_skins/erp5_km_theme/erp5_km_minimal_layout bottom gadget (Bottom Gadget)
erp5/portal_skins/erp5_km_theme/erp5_km_minimal_layout right column gadget (Right Gadget)
erp5/portal_skins/erp5_km_theme/login_form left registration (Login)
erp5/portal_skins/erp5_km_theme/login_form right registration (New User Registration)
```

and this does not look bad when viewing the forms.