- 02 Feb, 2022 4 commits
-
-
Cédric Le Ninivin authored
-
Cédric Le Ninivin authored
-
Cédric Le Ninivin authored
-
Cédric Le Ninivin authored
* Add basic property sheets * Add init script to set Constraint and Type * Validator can return the list of errors * Provide field library
-
- 01 Feb, 2022 1 commit
-
-
Jérome Perrin authored
-
- 31 Jan, 2022 1 commit
-
-
Vincent Pelletier authored
When EmptyCriterionValid property is true, this method is expected to return a query which does not match any document. This only happens when query_list is empty, but because of category membership checking, query_list is never empty: it at least contains two ComplexQueries which themselves may contain an empty query list, and which match all documents. Calling getCategoryParameterDict with an empty list is dubious, but changing its behaviour in ZSQLCatalog may affect more than just predicates, so change the behaviour in Predicate class directly by checking whether there is any category being matched to begin with.
-
- 28 Jan, 2022 1 commit
-
-
Kirill Smelkov authored
Pygolang installs import hooks for pytest and ipython, to add exception-chaining support into them(*) _iff_ (if and only if) those modules are actually used. This works via Importing[1] which pre-installs artificial modules into sys.modules that catch __getattribute__ and try to import corresponding module for real on first access. Usually everything is fine. But with pylint/astroid, if the checker code happens to run with those LazyModules installed, and the checked code has `import sys` somewhere, astroid eventually delves into processing sys, then sys.modules and wants to represent that sys.modules dict as dict of constant. Then, when e.g. sys.modules['_pytest'] is processed, corresponding module object is checked for .__class__, which raises ImportError if pytest is not actually available: ( https://erp5js.nexedi.net/#/test_result_module/20220127-129289AE2/33 ) ... File ".../eggs/astroid-1.3.8-py2.7.egg/astroid/node_classes.py", line 553, in __init__ for k, v in items.items()] File ".../eggs/astroid-1.3.8-py2.7.egg/astroid/node_classes.py", line 962, in const_factory return CONST_CLS[value.__class__](value) File ".../eggs/Importing-1.10-py2.7.egg/peak/util/imports.py", line 254, in __getattribute__ _loadModule(self) File ".../eggs/Importing-1.10-py2.7.egg/peak/util/imports.py", line 222, in _loadModule reload(module) ImportError: No module named _pytest -> Fix it by detecting those lazy modules and not letting them go through normal const_factory not to crash. /cc @jerome, @arnau /reviewed-by @rafael /reviewed-on nexedi/erp5!1546 and nexedi/slapos!1117 [1] https://pypi.org/project/Importing/ (*) see: https://lab.nexedi.com/nexedi/pygolang/blob/pygolang-0.1-0-g7b72d41/golang/_patch/__init__.py https://lab.nexedi.com/nexedi/pygolang/blob/pygolang-0.1-0-g7b72d41/golang/_patch/pytest_py2.py#L48-51 https://lab.nexedi.com/nexedi/pygolang/blob/pygolang-0.1-0-g7b72d41/golang/_patch/ipython_py2.py#L45-48
-
- 27 Jan, 2022 1 commit
-
-
Xiaowu Zhang authored
See merge request nexedi/erp5!1517
-
- 26 Jan, 2022 4 commits
-
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
erp5_base: add constraint and action to make sure Employee Number is unique instead of manually setting
-
- 24 Jan, 2022 3 commits
-
-
Vincent Pelletier authored
-
Jérome Perrin authored
We make it possible to define function the same way it's currently possible to define accounts. The idea is similar: to be able to use this information in accounting generation rules. The typical accounting generation configuration using this will use the function defined on the supply line if any is defined and with a fallback to the function defined on business process' trade model path. For now we don't introduce such configuration by default, but this may become part of the configuration generated by configurator some day.
-
Jérome Perrin authored
The view of accounting transactions have dynamic columns so that all the information that matters the most is displayed directly on the "main" view. This extends the columns to add a column for all the items attached to accounting movements.
-
- 21 Jan, 2022 1 commit
-
-
Jérome Perrin authored
Without these accessors, we have to use constructs like: resource.edit( default_purchase_supply_line_destination_account='account_module/123' ) with the accessors, we can use: resource.edit( default_purchase_supply_line_destination_account_value=account, ) The former is a bit error prone, because typos in the property name silently create a local propery and typos in the relative URL make a "broken" relation.
-
- 20 Jan, 2022 1 commit
-
-
Xiaowu Zhang authored
-
- 18 Jan, 2022 1 commit
-
-
Jérome Perrin authored
odt_style comes with "Print" global actions which allows getting the default form as ODT and convert it to selected format and DMS comes with "Print" actions which return a PDF of the document content. As a result, when user try to use Print, they have the same action twice with no way to know which one is which. This is detected by CodingStyleTestCase.test_DuplicateActions, but only for configurations where both erp5_odt_style and erp5_dms are installed, which is not the case in coding style test suite which only install the miminmal dependent business templates.
-
- 17 Jan, 2022 3 commits
-
-
Jérome Perrin authored
Fixes after !1451 With the RAM implementation it was possible to use in session: - list or dict of temp documents - temp documents created with `newTempBase` ( not just `newContent(temp_object=True, ...)` ) This repairs these two use cases. See merge request !1533
-
Jérome Perrin authored
See merge request !1532
-
Jérome Perrin authored
This is a step to be able to run ERP5 on zope4, where servers are no longer started by ZConfig. This will be used by nexedi/slapos!1114 See merge request nexedi/erp5!1529
-
- 14 Jan, 2022 6 commits
-
-
Jérome Perrin authored
The new workflow implementation from df85ef46 (ERP5Workflow: DC Workflows are now ERP5 objects (!1378)., 2020-11-18) had a different behavior in the implementation of _executeTransition, it was setting all kwargs from the transition in REQUEST. The reasons for this are unclear, it seem to come from the first Workflow implementation, 81784db4 (Initial Import of ERP5Workflow porduct., 2010-10-15) The side effects are that calling a workflow method, for example: document.edit(key=value) would also alter the global request to set key=value in REQUEST, for the rest of the current request. It was causing subtle issues, especially in tests where the REQUEST lifetime is long.
-
Jérome Perrin authored
This was redirecting with the full list of updated documents URLs, causing too long URLs. This also simplifies code a bit, change the wording of messages and use translation.
-
Yusei Tahara authored
-
Jérome Perrin authored
Now that TemporaryDocumentMixin and TempBase implementation details have been made consistent, there's no reason to duplicate code. This also make TempBase uses TemporaryDocumentMixin of __setstate__, so TempBase have more sane behaviour when being pickled.
-
Jérome Perrin authored
Products.ERP5Type.mixin.temporary.TemporaryDocumentMixin and Products.ERP5Type.Base.TempBase implementations were a bit different: - getTitle was acquiring title in TemporaryDocumentMixin, although this was probably never acquiring in practice because most documents have a title. - isIndexable was an int and not a PropertyConstantGetter like it is supposed to be. Change TemporaryDocumentMixin to behave like TempBase here. =
-
Jérome Perrin authored
Before f359f267 (Use Distributed Cache for Session, 2021-07-19) when we were using RAM cache for sessions, it was possible to store collections (eg. dicts or lists) with reference to ERP5 documents in session, but after this change, using such collections was refused with error: TypeError: Can't pickle objects in acquisition wrappers. This change restore the possibility of using collections, by being more clever when we store and retrieve collections
-
- 13 Jan, 2022 9 commits
-
-
Jérome Perrin authored
no need to create temp objects because anyway the transaction is aborted at the end of each test. This solve a problem that some APIs behave differently on temp objects and we don't really have use cases where we use actions on temp objects. For reference, the case which fail is an action with a TALES condition using a related accessor, the exact condition was: python: object.getAggregateRelated(portal_type="Implicit Item Movement") is not None
-
Jérome Perrin authored
This was not patching the right place (I should have used mock ...)
-
Jérome Perrin authored
See merge request nexedi/erp5!1531
-
Jérome Perrin authored
-
Jérome Perrin authored
The portal types using this form are all PresencePeriod or subclasses, so use PresencePeriod as a prefix.
-
Jérome Perrin authored
TaskMovement_getSimulationStateColorText was same content and calendar depends on project
-
Jérome Perrin authored
Rename Orgnaisation_generatePlanningDomain to Organisation_generatePlanningDomain
-
Jérome Perrin authored
also rewrite a sorted to use key instead of cmp
-
Jérome Perrin authored
by calling proxy_field.checkConsistency(fixit=True) on them
-
- 12 Jan, 2022 2 commits
-
-
Vincent Pelletier authored
This tic call has a lot of activities to process. Checking test result history over the last 2 months, the whole test runtime is mostly under 800s, but with a handful of spikes around 1600s, with one at 2300s. So pick just slightly more than the worst over 2 months.
-
Vincent Pelletier authored
-
- 11 Jan, 2022 1 commit
-
-
Jérome Perrin authored
-
- 07 Jan, 2022 1 commit
-
-
Xiaowu Zhang authored
-