- 26 Dec, 2019 3 commits
-
-
Jérome Perrin authored
It was failing decoding unicode
-
Jérome Perrin authored
-
Jérome Perrin authored
Otherwise we cannot use this feature on a website/websection using a different skin selection.
-
- 25 Dec, 2019 7 commits
-
-
Jérome Perrin authored
With the current architecture of cache manifest, it was required that developpers change the cache manifests referencing a web page every time they change a web page. In practice, developers were never doing this, so we sometimes had issues where client keep using old version of website even though a new version has been deployed, when after deployment we did not change the cache manifest. To automate the scenario of modifying the cache manifest, introduce a post-upgrade constraint that will check that the manifest is newer than all of the referenced pages. If that's the case, the constraint can fix by modifying the manifest content, which also changes the modification date of the manifest, which might be used in "if-modified-since" negociations. According to spec [1], cache manifest is updated if the HTTP responses is not "304 not modified" and if the manifest content is not byte-for-byte identical to the previously cached version. [1] https://www.w3.org/TR/2008/WD-html5-20080122/#updating1 /reviewed-on nexedi/erp5!1009
-
Jérome Perrin authored
Post upgrader constraint to automatically fix modification date and an upgrader bug-fix for an issue that's revealed in this new test. /reviewed-on !1013
-
Jérome Perrin authored
This tests had a test instance URL hardcoded and was working only on this instance.
-
Thomas Gambier authored
-
Jérome Perrin authored
The default size of iframe is too small for CKEditor to display dialogs properly. Increase the height so that CKEditor display dialog boxes correctly. /reviewed-on nexedi/erp5!1010
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: Followup of 47b14fd4 making sure that there is only one Delivery to update (as it was before that commit).
-
- 24 Dec, 2019 6 commits
-
-
Roque authored
-
Roque authored
-
Roque authored
-
Roque authored
-
Jérome Perrin authored
Web sections or web sites displaying a default page should have modification date after the modification date of their default page, so that the "if-modified-since" requests can be replied with a 304 not modified responses.
-
Jérome Perrin authored
Upgrader detects that if some type have constraints and their container type also have constraint, it's not needed to check again this type because since checkConsistency is recursive when the container is checked they will also be checked. This fails when we have situtations like: X is allowed in Y X is allowed in Z and there are constraints for by X, Y and Z. This was raising a KeyError when pop'ing Z : Module script, line 50, in Base_getConstraintTypeListPerPortalType - <PythonScript at /erp5/Base_getConstraintTypeListPerPortalType used for /erp5/portal_alarms/upgrader_check_pre_upgrade> - Line 50 type_list = constraint_type_per_type.pop(allowed_content_type) Module AccessControl.ZopeGuards, line 104, in guarded_pop v = guarded_getitem(d, key) Module AccessControl.ZopeGuards, line 83, in guarded_getitem v = object[index] KeyError: 'Z' In fact, this code is wrong, because if Z is also allowed in W and W does not have constraint, then Zs inside Ws will not be migrated. In practice, that's probably OK for now, because we don't use migration constraints on documents so much, most of the time we only do one script that checks the constraint globally.
-
- 23 Dec, 2019 1 commit
-
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!1003
-
- 20 Dec, 2019 5 commits
-
-
Romain Courteaud authored
Many typos in: a9d81b09
-
Romain Courteaud authored
-
Boxiang Sun authored
-
Boxiang Sun authored
-
Ivan Tyagov authored
-
- 19 Dec, 2019 16 commits
-
-
Ivan Tyagov authored
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint unbalanced-tuple-unpacking warning.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint unused-import and unused-variable warnings.
-
Ivan Tyagov authored
-
Ivan Tyagov authored
New workflow actions added in 67f58b5b and b3dc32f5 thus adjust accordingly.
-
Ivan Tyagov authored
-
Jérome Perrin authored
and re-enable coding style test
-
Jérome Perrin authored
Rename AccountingZuite_CommonTemplate to ERP5Site_viewAccountingZuiteCommonTemplate Rename AccountingZuite_createAccountingTransactionList to AccountingTransactionModule_createAccountingTransactionList Rename AccountingZuite_createAccountingTransactionListSalesAndPayments to AccountingTransactionModule_createAccountingTransactionListSalesAndPayments Rename AccountingZuite_createAccountingTransactionListWithPersons to AccountingTransactionModule_createAccountingTransactionListWithPersons Rename AccountingZuite_createDocument to AccountingTransactionModule_createAccountingTestDocument Rename AccountingZuite_createReportDataset to AccountingTransactionModule_createAccountingTestReportDataset Rename AccountingZuite_createReportJournalDataset to AccountingTransactionModule_createAccountingTestReportJournalDataset Rename AccountingZuite_deleteAccountingTransactionTemplate to ERP5Site_deleteAccountingTransactionTemplate Rename AccountingZuite_initializeAccountingTransactionReportTest to AccountingTransactionModule_initializeAccountingTransactionReportTest Rename AccountingZuite_initializeAccountingTransactionTemplateTest to AccountingTransactionModule_initializeAccountingTransactionTemplateTest Rename AccountingZuite_markChanged to AccountingTransactionModule_markAccountingTestDataChanged Rename AccountingZuite_reportMacros to Zuite_viewAccountingTestReportMacros Rename AccountingZuite_reset to ERP5Site_resetConfigurationForAccountingTest Rename AccountingZuite_setAccountReferencePreference to PreferenceTool_setAccountingTestAccountReferencePreference Rename AccountingZuite_setDocumentSectionPreference to PreferenceTool_setAccountingTestDocumentSectionPreference Rename AccountingZuite_unsetDocumentSectionPreference to PreferenceTool_resetAccountingTestDocumentSectionPreference
-
Jérome Perrin authored
/reviewed-on nexedi/erp5!996
-
Jérome Perrin authored
Folder_getDeleteObjectList could do an extra paranaoïa check that the caller did not pass an empty list of uids, because this would cause the script to iterate on the full catalog table.
-
Jérome Perrin authored
We now have getRelationCountForDeletion API for this.
-
Jérome Perrin authored
The general approach is: - replace deprecated lambdas with list comprehensions - remove unused variables/imports - replace dangerous arguments [] with () - replace dangerous arguments {} with None and "if None -> {}" - replace builtin names with something similar Now that all problems reported by pylint are fixed, enable coding style test.
-
Jérome Perrin authored
This was not valid HTML5: AssertionError: Using nu validator to parse the view "SQLMethod_view" (from erp5_core bt) with warnings displayed : Error: line 782 column 23 : Element “style” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.): </script> <style type="text/css"> .cm Error: line 822 column 23 : Element “style” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.): script> <style type="text/css"> .max
-
Jérome Perrin authored
This fix a regression from 920655a2 : when item has no tracking, uid was passed an empty list and this fetched all catalog. Also call getObject explicitly only once instead of having it called implicitly twice.
-
- 18 Dec, 2019 2 commits
-
-
Thomas Gambier authored
/reviewed-on nexedi/erp5!988
-