- 13 Feb, 2024 27 commits
-
-
Kirill Smelkov authored
Similarly with cell_list, organize a loop in under nr_cell_list and emit configuration for each NR cell we have. Tests will be added later as full tests for generic MultiRU. Only trivial space and comments changes in rendered gnb.cfg Backward compatibility: no change for ORS and everything else.
-
Kirill Smelkov authored
So far CA was setup only for lte case and it is possible to simplify generation of all pair of cells to be done without extra loop and state. Tests will be added later as full tests for generic MultiRU. Backward compatibility: no change for ORS, which has only one cell, and rendered enb.cfg and gnb.cfg stay the same.
-
Kirill Smelkov authored
For uniformity with LTE where it already is. We do not expose it in ORS schema because it will be exposed only in generic LTE and NR schemas, but for ORS schemas I prefer to keep them intact myself. Tests will be added later as full tests for generic MultiRU. Backward compatibility: no change for ORS and everything else. Diff for rendered configs: $ ./pythonwitheggs slapos-render-config.py && git diff -w --no-index config/{old,out} diff --git a/config/old/gnb.cfg b/config/out/gnb.cfg index 5849bb924..b8a385a71 100644 --- a/config/old/gnb.cfg +++ b/config/out/gnb.cfg @@ -56,6 +56,7 @@ subcarrier_spacing: 30, ssb_pos_bitmap: "10000000", + root_sequence_index: 1, inactivity_timer: 10000, // Handover @@ -176,7 +176,6 @@ intra_freq_reselection: true, q_rx_lev_min: -70, q_qual_min: -20, - root_sequence_index: 1, sr_period: 40, dmrs_type_a_pos: 2, prach: {
-
Kirill Smelkov authored
As with Radio Units organize a registry of cells and start to handle that registry generally everywhere. Make parameters that configure cells, for example tdd_ul_dl_config, dl_earfcn, bandwidth, pci, etc to be per-cell. Cell registry is still populated from cell_list and slapparameter_dict. Tests will be added later as full tests for generic MultiRU. Rendered enb.cfg and gnb.cfg stay practically the same. Backward compatibility: no change for ORS; For everything else cell parameters stop to be global and are moved to cell_list. -------- Appendix. Diff for rendered enb.cfg and gnb.cfg before and after this patch: ``` $ ./pythonwitheggs slapos-render-config.py && xdiff -w config/{old,out} ``` ```diff diff --git a/config/old/enb.cfg b/config/out/enb.cfg index 5c6743c21..1b39f7044 100644 --- a/config/old/enb.cfg +++ b/config/out/enb.cfg @@ -1,6 +1,3 @@ - - - { log_options: "all.level=error,all.max_size=0,nas.level=debug,nas.max_size=1,s1ap.level=debug,s1ap.max_size=1,x2ap.level=debug,x2ap.max_size=1,rrc.level=debug,rrc.max_size=1,ngap.level=debug,ngap.max_size=1,xnap.level=debug,xnap.max_size=1,phy.level=info,file.rotate=1G,file.path=/dev/null", log_filename: "log/enb.log", @@ -93,11 +90,11 @@ srs_hopping_bandwidth: 0, }, - drb_config: "drb", + drb_config: "default-drb.cfg", sib_sched_list: [ { - filename: "sib", + filename: "default-sib23.asn", si_periodicity: 16, }, ], diff --git a/config/old/gnb.cfg b/config/out/gnb.cfg index 6b04559c6..1fa637925 100644 --- a/config/old/gnb.cfg +++ b/config/out/gnb.cfg @@ -1,6 +1,3 @@ - - - { log_options: "all.level=error,all.max_size=0,nas.level=debug,nas.max_size=1,s1ap.level=debug,s1ap.max_size=1,x2ap.level=debug,x2ap.max_size=1,rrc.level=debug,rrc.max_size=1,ngap.level=debug,ngap.max_size=1,xnap.level=debug,xnap.max_size=1,phy.level=info,file.rotate=1G,file.path=/dev/null", log_filename: "log/enb.log", @@ -77,7 +74,6 @@ manual_ref_signal_power: true, ss_pbch_block_power: 8, - tdd_ul_dl_config: { pattern1: { period: 5, /* in ms */ @@ -148,7 +144,7 @@ ], }, - drb_config: "drb", + drb_config: "default-drb.cfg", }, ], nr_cell_default: { ```
-
Kirill Smelkov authored
Most were already so, but sdr_number and cpri_mult were not. We need to be able to use different SDR boards and with different CPRI speed, so make those parameters to be per-RU as well. Backward compatibility: no change for ORS; For CPRI-based cases sdr_number and cpri_mult become per-RU.
-
Kirill Smelkov authored
Like e.g. txa0cc00_center_frequency, rxa0cc00_center_frequency_earfcn, etc - because different units needs to use different parameters. cron_schedule is renamed to -> reset_schedule to better reflect its meaning. user-authorized-key remains to be global as this is per-eNB nor per-RU property, but is likely unneded in the future. Corresponding FIXME is added to highlight this. Backward compatibility: no change for ORS; lopcomm parameters become per-cell and need adaptation.
-
Kirill Smelkov authored
Add code to organize a registry of Radio Units and handle that registry generally everywhere. RU registry is still populated from cell_list and in practice there still can be radio units only of the same type, but besides slaplte.load_ru_and_cell which is aware of that, the rest of the code tries to do everything as if RUs of different type could be present simultaneously. Now it is not only lopcomm who can do multiCELL, but also sunwave and SDR as well. gNB also starts to gain support for cell_list, because cell_list loading is uniformly applied to both eNB and gNB. However, since enb.cfg is not yet prepared to handle multiple NR cells yet, there is an assert that in case of NR there is only one RU/cell present there. We will remove this limitation in a follow-up patch. Later we will also change the loading to load RU descriptions from shared instances and they won't be constrained to be Radio Units of the same type. But we need to prepare a lot to be able to do that. One more step forward towards MultiRU. Tests will be added later as full tests for generic MultiRU. Backward compatibility: no change for ORS and practically no breaking change for everything else. -------- Appendix. Diff for rendered enb.cfg and gnb.cfg before and after this patch: ``` $ ./pythonwitheggs slapos-render-config.py && git diff -w --no-index config/{old,out} ``` ```diff diff --git a/config/old/enb.cfg b/config/out/enb.cfg index 884483b0a..cafdf42be 100644 --- a/config/old/enb.cfg +++ b/config/out/enb.cfg @@ -1,24 +1,22 @@ - { log_options: "all.level=error,all.max_size=0,nas.level=debug,nas.max_size=1,s1ap.level=debug,s1ap.max_size=1,x2ap.level=debug,x2ap.max_size=1,rrc.level=debug,rrc.max_size=1,ngap.level=debug,ngap.max_size=1,xnap.level=debug,xnap.max_size=1,phy.level=info,file.rotate=1G,file.path=/dev/null", log_filename: "log/enb.log", - + // Radio Units rf_driver: { + // default-RU 2T2R (ors) name: "sdr", args: "dev0=/dev/sdr0", - rx_antenna:"tx_rx", tdd_tx_mod: 1, }, - tx_gain: 62, - rx_gain: 43, - + tx_gain: [62, 62], + rx_gain: [43, 43], com_addr: "127.0.1.2:9001", // LTE core network mme_list: [ @@ -36,6 +34,8 @@ // LTE cells cell_list: [ + + // default (default-RU) { rf_port: 0, n_antenna_dl: 2, diff --git a/config/old/gnb.cfg b/config/out/gnb.cfg index fd57ca3dc..7818b4ea8 100644 --- a/config/old/gnb.cfg +++ b/config/out/gnb.cfg @@ -1,24 +1,22 @@ - { log_options: "all.level=error,all.max_size=0,nas.level=debug,nas.max_size=1,s1ap.level=debug,s1ap.max_size=1,x2ap.level=debug,x2ap.max_size=1,rrc.level=debug,rrc.max_size=1,ngap.level=debug,ngap.max_size=1,xnap.level=debug,xnap.max_size=1,phy.level=info,file.rotate=1G,file.path=/dev/null", log_filename: "log/enb.log", - + // Radio Units rf_driver: { + // default-RU 2T2R (ors) name: "sdr", args: "dev0=/dev/sdr0", - rx_antenna:"tx_rx", tdd_tx_mod: 1, }, - tx_gain: 62, - rx_gain: 43, - + tx_gain: [62, 62], + rx_gain: [43, 43], com_addr: "127.0.1.2:9001", // NR core network amf_list: [ ```
-
Kirill Smelkov authored
For LTE tdd_ul_dl_config is enum [ "[Configuration 2] 5ms 2UL 6DL (default)", "[Configuration 6] 5ms 5UL 3DL (maximum uplink)" ], but default was outside of that enum. The code in enb.jinja2.cfg actually uses the first option from the enum as the default. -> Fix default in schema. tdd_ul_dl_config in NR seems to be already correct.
-
Kirill Smelkov authored
There is cell_list.*.cpri_port_number that is used insted from the beginning. -> Remove unused cpri_port from scheamas.
-
Kirill Smelkov authored
Previously type of emulated UE was static parameter of particular software release - it was possible to simulate UE and attach to cells only of the RAT of particular template. In MultiRU it will be possible to generally emulate all kind of UEs - both LTE and NR all at the same time, and attach them to LTE and NR cells simultaneously. -> Switch type of UE to be runtime parameter as a preparatory step for that. URLs of software releases changes (we remove lte and nr in names), but here we do not care about backward compatibility because currently there are just a few UEsim deployments and migration should be easy.
-
Kirill Smelkov authored
Less code duplication
-
Kirill Smelkov authored
SIM card object is useful to have not only for Core Network - we will also use it for UE configutation. Move SIM schema into common place as a preparatory step.
-
Kirill Smelkov authored
K and IMSI are orthogonal to RAT and, similarly to how we keep default n_antenna_dl/ul independent of RAT we can do so with this default UE parameters.
-
Kirill Smelkov authored
ORS does not support UEsim as indicated by `if bbu != ors` in software.cfg.json.jinja2. Amends f3f1cb46 (software/ors-amarisoft: Start to introduce ORS mode) because that patch started to really reject instantiating ue-* on ORS.
-
Kirill Smelkov authored
Those were unused because software.cfg.json.jinja2 explicitly enables UEsim only for bbu != 'ors'.
-
Kirill Smelkov authored
Soon we are going to make rf_mode a runtime parameter and so there won't be TDD and FDD in software names anymore. Prepare to that and make --delete to remove the exact set of files that render-template actually generates instead of becoming a noop after "runtime rf_mode" restructuring.
-
Kirill Smelkov authored
We are currently querying it in instance.cfg and later, once again, in e.g. instance-enb.jinja2.cfg . However ORS mode will need to adjust slapparameter_dict with ORS defaults and pass it further to generic enb. So it won't work if we use slapparameter_dict obtained the second time because the second query will return unadjusted original slapparameter_dict. In this patch we are only doing preparatory step - redo the code not query the master from instance-{enb,ue}.jinja2.cfg and work with slapparameter_dict and slap_configuration already queried by instance.cfg For UE the change is trivial. For eNB instance-enb.jinja2.cfg used to set the defaults for com, mme, amf and gtp in the same section used for the second query. We rework those defaults to be applied to slapparameter_dict via jinja2 - via the same way we are going to later use in ORS mode. Handling defaults for everything besides gtp_addr is straightforward. For gtp_addr it has the semantic difference when explicitly given, and given only implicitly. In the latter case the intent of original code is to autodetect whether to use an address on loopback, or externally-visible address. Original code used the check for emptiness of mme_list/amf_list as the condition for "use loopback". Since now those lists, after applying their defaults, are never empty we rework the code to see if core address is on the loopback or not, and use auto-GTP-on-loopback only if core is also on loopback. This should, hopefully, be more convenient as it also works ok out of the box if core is on loopback, but its address was explicitly specified. Previously for such cases gtp_addr was also needed to be specified, and now it should work without that. No change to rendered enb.cfg and gnb.cfg besides whitespace. Adjust ipv6-random usage in core-network for consistency with enb as well.
-
Kirill Smelkov authored
For example it is the port that is setup in ru/dnsmasq.jinja2.cfg that is used, not :port and there it is 5354, i.e. different. :ip is also not used anywhere. -> Remove them to avoid confusion.
-
Kirill Smelkov authored
That data structure is really a dict, not list. It is more clear to name it appropriately. -> Do the renaming but keep cell_list intact as described in JSON schemas so that external interface remains unchanged. Rendered enb.cfg and gnb.cfg remain the same.
-
Kirill Smelkov authored
Not only inside rendered enb.jinja2.cfg and ue.jinja2.cfg because we will need that information in slaplte and slaplte is imported by instance-enb and instance-ue.
-
Kirill Smelkov authored
instance-enb and instance-ue currently setup that slap_configuration with LTE/NR defaults to be accessible from enb.jinja2.cfg and ue.jinja2.cfg. But we will soon need to have access to those defaults from slaplte.jinja2 as well, and it will break if left as is because when slaplte is imported from e.g. enb.jinja2 - it will work, but when slaplte is imported from instance-enb it will break because parent of instance-enb (instance.cfg) does not setup defaults in slap_configuration at that level. The fix is to either duplicate slap_configuration at instance.cfg level, or to switch access to the defaults to go via original default_* parameters. We go the second way for simplicity.
-
Kirill Smelkov authored
software/ors-amarisoft: enb.jinja2.cfg: Switch internal ru.ru_type to be 'sunwave' for Sunwave M2RU Radio Unit ru/libinstance and everything inside there already refer to that unit as 'sunwave'. Do the same for uniformity in enb.cfg and because we already refer to Lopcomm ORAN Radio Unit as just 'lopcomm'. In the future, if we will need to distinguish different models of one manufacturer, we could extend ru type to be e.g. manufacturer/model or do something similar. Template rendering is still done with ru='m2ru' coming from outside but internally it is now ru.ru_type='sunwave' instead of ru.ru_type='m2ru'.
-
Kirill Smelkov authored
Even though I introduced cell object in 79370ebf (software/ors-amarisoft: enb.jinja2.cfg: Stop using C Preprocessor and switch to Jinja2 completely) it is currently only cell.bandwidth that is living there, while all other cell parameters are still fetched from slapparameter_dict directly. We will soon introduce cell variable - that will iterate over cell_dict, and also keeping global cell won't work due to name shadowing. On the other hand we are not yet ready to start migrating all cell parameters to be accessible via cell object. -> So inline code for lte bandwidth parameter until the time comes to rework all cell parameters to be accessible via cell object. Rendered enb.cfg and gnb.cfg stay the same.
-
Kirill Smelkov authored
To handle multiple radio units we will need to rework this code significantly. Move this to a dedicated routine as a preparatory step. The code moves out of enb.cfg because later it will be also used in UEsim to configure simulator radio units as well. No non-whitespace changes in rendered enb.cfg and gnb.cfg . /cc @jhuge, @lu.xu, @tomo, @xavier_thompson, @Daetalus
-
Kirill Smelkov authored
In f3f1cb46 I've made a mistake in "inject ORS defaults" code - there it should be RF.dl_earfcn and RF.dl_nr_arfcn instead of RF.earfcn and RF.nr_arfcn.
-
Lu Xu authored
-
Ivan Tyagov authored
(irrelevant for the coupler application).
-
- 09 Feb, 2024 1 commit
-
-
Jérome Perrin authored
-
- 08 Feb, 2024 1 commit
-
-
Thomas Gambier authored
(cherry picked from commit d1ec306a)
-
- 07 Feb, 2024 3 commits
-
-
Lu Xu authored
-
Lu Xu authored
-
Jérome Perrin authored
-
- 05 Feb, 2024 2 commits
-
-
Jérome Perrin authored
See merge request !1531
-
Jérome Perrin authored
See merge request nexedi/slapos!1529
-
- 03 Feb, 2024 1 commit
-
-
Jérome Perrin authored
-
- 01 Feb, 2024 4 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
These are already defined in stack/slapos.cfg
-
Jérome Perrin authored
jupyter-py2 used an old version not py3 compatible pygolang/test used the same version as in stack/slapos.cfg
-
Jérome Perrin authored
-
- 31 Jan, 2024 1 commit
-
-
Jérome Perrin authored
-