When updating ghostscript, the rendering of images seems slightly different, as we can observe on the logos.

Changing state directly in Base_contribute was only functional for the case
where metadata was discovered asynchronously. In the case of synchronous
discovery, the state was first changed state, and Document_convertToBaseFormatAndDiscoverMetadata
was executed - but this this was causing Unauthorized like this:

      Module script, line 10, in Document_convertToBaseFormatAndDiscoverMetadata
      - <PythonScript at /erp5/Document_convertToBaseFormatAndDiscoverMetadata used for /erp5/document_module/163>
      - Line 10
        return context.discoverMetadata(filename=filename,
    Unauthorized: You are not allowed to access 'discoverMetadata' in this context

because once we have already changed state, regular user no longer have
permission to access discoverMetadata, because that method needs ModifyPortalContent
permission.

Instead, of handling publication_state only in Base_contribute, treat it
like others user input parameter and change state during discovery.

Tests were also re-organised to move Base_contribute related test in testIngestion
and also to run Base_contribute tests as a non-manager user.

This was never supported, we support only [state in $workflow_id]

See also:

  https://erp5js.nexedi.net/#/bug_module/1740

  b6dcbc19 (l10n_fr,l10n_jp: Fix translation of "Open", 2021-04-30)

Generated from this script:

    #!/srv/slapgrid/slappart3/srv/runner/software/cc0326f0dcb093f56c01291c300c8481/parts/erp5/venv/bin/python

    import polib
    import sys
    import re

    pofile = polib.pofile(sys.argv[1])

    msgs = dict()
    for entry in pofile:
      msgs[entry.msgid] = entry.msgstr

    transition_re = re.compile(r'(.*) \[transition in .*\]')

    fixed_messages = dict()
    for entry in pofile:
      match = transition_re.match(entry.msgid)
      if match:
        # in erp5_l10n_de some msgstr also have the [transition in ...], we drop them
        if transition_re.match(entry.msgstr):
          continue
        short = match.groups()[0]
        if short.endswith('Action'):
          continue
        if short not in msgs:
          print(f"🤔  {short} not translated ( from {entry.msgid} )")
          fixed_messages[short] = entry.msgstr
      else:
        fixed_messages[entry.msgid] = entry.msgstr

    pofile.clear()
    for k, v in fixed_messages.items():
      pofile.append(polib.POEntry(msgid=k, msgstr=v))

    pofile.save(sys.argv[1])

    import subprocess
    subprocess.check_output(
      [
        '/opt/slapos-shared/gettext/4df93a547efd86e0eb70495b88a5d3b1/bin/msgattrib',
        sys.argv[1],
        "--no-fuzzy",
        "--translated",
        "-s",
        "--no-wrap",
        "-o",
        sys.argv[1]

      ]
    )

using:

    msgattrib translation.po --no-fuzzy --translated -s --no-wrap -o translation.po

translated_title is used in listbox search columns, so it's very confusing
for users if they can not use the usual % character for partial matches.

This changes the behaviour of translated_title to autodetect the presence of
% and use LIKE comparison operator in such case.

this field did not use a (my_ / your_) prefix

See merge request nexedi/erp5!1419

with previous implementation, categories_list=[...] could be included
and it would delete existing categories not included in it

So use getPropertyAndCategoryList instead of propertyIds,
that should return a cleaner list for input_parameter_dict here

2 letters code as reference, 3 letters codes as codifications

When viewing the worklist page, a request is made to traverse portal_workflow,
which translate global worklist actions including the document count.

The non regression test was failing with:

    [u'Draft To Validate (1)'] != ['Draft To Validate']

and in real usage, several messages were added to Localizer.

We should not show a link to jump to workflow configuration to end users, these
are not relevant to them and can only cause confusion.

Some erp5 view action use a TALES expression to be visible only in draft state.
When validation a workflow transition dialog, ERP5JS tries to go back to the previous view which is now hidden.

In such case, switch back to the default document view.

Do not return wrong content type

fixup e21968ba

Because we were backing up to trash documents in the wrong order (in the example
from the test, portal_categories/test_category/removed_container/removed_document
first and then portal_categories/test_category/removed_container), first the
document was backed-up and some intermediate trash folders were created to
keep the hierarchy. Then when backing up the container, there was an error like:

    BadRequest: The id "removed_container" is invalid - it is already in use.

Similar error happens when upgrading erp5_configurator_standard, it was failing with:

    BadRequest: The id "officejs_sdk_workflow" is invalid - it is already in use.

The fix is to backup in reverse order, to back up first the containers and then
the document in containers.

This makes it a little bit easier to understand quantity and
quantity unit issues.

Since 405ee70e (SelectionTool/Listbox: Fix in calculating the start of last page in selection, 2018-10-17)
we have total_size in selection params. We don't want this to be propagated to
catalog search, otherwise it cause a warning that this is an unknown catalog key.

fixup! ERP5Workflow: testPerformance: Object creation is slower so increase maximum acceptable value.

0.0062 was still too much, we had test run taking 0.0064, set the threshold
to 0.0066 to be safe.

Sequence produce lots of useless output, which makes it slow to display test
result pages for tests using sequences, like testBusinesTemplate.
It must also be taking a lot of disk space on the server and is generally
not useful, when a test fail we have the log of the failing test.

Let's be consistent and use "Permissions" everywhere.

See merge request nexedi/erp5!1405

In English, "Open" means both the action of openning and the state when something
is open. Several workflows have the problem that the "Open" transition is
translated to something that does not describe the action, but the state.

We have a mechanism to override the translation for a state, by translating
`Word [{state_title} state in {workflow_id}]`, but we don't have such mechanism
for transitions, so when "Word" exist both as a transition and a state, "Word"
should be the translation of the transition and we should have translations in
context for all the workflow states.

Starting from PAS 1.10.0, assignRoleToPrincipal is private, only
manage_assignRoleToPrincipals can be used from restricted python.

We do nothing on these methods, but we comply to the interface.