git_access_spec.rb 11.9 KB
Newer Older
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1 2
require 'spec_helper'

Douwe Maan's avatar
Douwe Maan committed
3
describe Gitlab::GitAccess, lib: true do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
4
  let(:access) { Gitlab::GitAccess.new(actor, project, 'web', capabilities: capabilities) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
5 6
  let(:project) { create(:project) }
  let(:user) { create(:user) }
7
  let(:actor) { user }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
8 9 10 11 12 13 14
  let(:capabilities) do
    [
      :read_project,
      :download_code,
      :push_code
    ]
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
15

16 17 18
  describe '#check with single protocols allowed' do
    def disable_protocol(protocol)
      settings = ::ApplicationSetting.create_from_defaults
19
      settings.update_attribute(:enabled_git_access_protocol, protocol)
20 21 22 23 24 25 26 27 28
    end

    context 'ssh disabled' do
      before do
        disable_protocol('ssh')
        @acc = Gitlab::GitAccess.new(actor, project, 'ssh')
      end

      it 'blocks ssh git push' do
29
        expect(@acc.check('git-receive-pack', '_any').allowed?).to be_falsey
30 31 32
      end

      it 'blocks ssh git pull' do
33
        expect(@acc.check('git-upload-pack', '_any').allowed?).to be_falsey
34 35 36 37 38 39 40 41 42 43
      end
    end

    context 'http disabled' do
      before do
        disable_protocol('http')
        @acc = Gitlab::GitAccess.new(actor, project, 'http')
      end

      it 'blocks http push' do
44
        expect(@acc.check('git-receive-pack', '_any').allowed?).to be_falsey
45 46 47
      end

      it 'blocks http git pull' do
48
        expect(@acc.check('git-upload-pack', '_any').allowed?).to be_falsey
49 50 51 52
      end
    end
  end

53
  describe 'download_access_check' do
54
    subject { access.check('git-upload-pack', '_any') }
55

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
56 57 58 59
    describe 'master permissions' do
      before { project.team << [user, :master] }

      context 'pull code' do
60
        it { expect(subject.allowed?).to be_truthy }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
61 62 63 64 65 66 67
      end
    end

    describe 'guest permissions' do
      before { project.team << [user, :guest] }

      context 'pull code' do
68
        it { expect(subject.allowed?).to be_falsey }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
69 70 71 72 73 74 75 76 77 78
      end
    end

    describe 'blocked user' do
      before do
        project.team << [user, :master]
        user.block
      end

      context 'pull code' do
79
        it { expect(subject.allowed?).to be_falsey }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
80 81 82 83 84
      end
    end

    describe 'without acccess to project' do
      context 'pull code' do
85
        it { expect(subject.allowed?).to be_falsey }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
86 87
      end
    end
88 89 90

    describe 'deploy key permissions' do
      let(:key) { create(:deploy_key) }
91
      let(:actor) { key }
92 93

      context 'pull code' do
94 95
        context 'when project is authorized' do
          before { key.projects << project }
96

97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
          it { expect(subject).to be_allowed }
        end

        context 'when unauthorized' do
          context 'from public project' do
            let(:project) { create(:project, :public) }

            it { expect(subject).to be_allowed }
          end

          context 'from internal project' do
            let(:project) { create(:project, :internal) }

            it { expect(subject).not_to be_allowed }
          end

          context 'from private project' do
            let(:project) { create(:project, :internal) }

            it { expect(subject).not_to be_allowed }
          end
        end
119 120
      end
    end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150

    describe 'build capabilities permissions' do
      let(:capabilities) { build_capabilities }

      describe 'reporter user' do
        before { project.team << [user, :reporter] }

        context 'pull code' do
          it { expect(subject).to be_allowed }
        end
      end

      describe 'admin user' do
        let(:user) { create(:admin) }

        context 'when member of the project' do
          before { project.team << [user, :reporter] }

          context 'pull code' do
            it { expect(subject).to be_allowed }
          end
        end

        context 'when is not member of the project' do
          context 'pull code' do
            it { expect(subject).not_to be_allowed }
          end
        end
      end
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
151 152
  end

153
  describe 'push_access_check' do
154 155
    before { merge_into_protected_branch }
    let(:unprotected_branch) { FFaker::Internet.user_name }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
156

157 158
    let(:changes) do
      { push_new_branch: "#{Gitlab::Git::BLANK_SHA} 570e7b2ab refs/heads/wow",
159 160
        push_master: '6f6d7e7ed 570e7b2ab refs/heads/master',
        push_protected_branch: '6f6d7e7ed 570e7b2ab refs/heads/feature',
161 162
        push_remove_protected_branch: "570e7b2ab #{Gitlab::Git::BLANK_SHA} "\
                                      'refs/heads/feature',
163
        push_tag: '6f6d7e7ed 570e7b2ab refs/tags/v1.0.0',
164
        push_new_tag: "#{Gitlab::Git::BLANK_SHA} 570e7b2ab refs/tags/v7.8.9",
165 166
        push_all: ['6f6d7e7ed 570e7b2ab refs/heads/master', '6f6d7e7ed 570e7b2ab refs/heads/feature'],
        merge_into_protected_branch: "0b4bc9a #{merge_into_protected_branch} refs/heads/feature" }
167
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
168

169 170 171
    def stub_git_hooks
      # Running the `pre-receive` hook is expensive, and not necessary for this test.
      allow_any_instance_of(GitHooksService).to receive(:execute).and_yield
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
172
    end
173

174 175 176 177 178 179 180 181
    def merge_into_protected_branch
      @protected_branch_merge_commit ||= begin
        stub_git_hooks
        project.repository.add_branch(user, unprotected_branch, 'feature')
        target_branch = project.repository.lookup('feature')
        source_branch = project.repository.commit_file(user, FFaker::InternetSE.login_user_name, FFaker::HipsterIpsum.paragraph, FFaker::HipsterIpsum.sentence, unprotected_branch, false)
        rugged = project.repository.rugged
        author = { email: "email@example.com", time: Time.now, name: "Example Git User" }
182

183 184
        merge_index = rugged.merge_commits(target_branch, source_branch)
        Rugged::Commit.create(rugged, author: author, committer: author, message: "commit message", parents: [target_branch, source_branch], tree: merge_index.write_tree(rugged))
185 186
      end
    end
187

188 189
    def self.run_permission_checks(permissions_matrix)
      permissions_matrix.keys.each do |role|
190
        describe "#{role} access" do
191 192 193 194 195 196 197
          before do
            if role == :admin
              user.update_attribute(:admin, true)
            else
              project.team << [user, role]
            end
          end
198

199
          permissions_matrix[role].each do |action, allowed|
200 201
            context action do
              subject { access.push_access_check(changes[action]) }
202

203
              it { expect(subject.allowed?).to allowed ? be_truthy : be_falsey }
204 205 206 207 208
            end
          end
        end
      end
    end
209 210

    permissions_matrix = {
211 212 213 214 215 216 217 218 219 220 221
      admin: {
        push_new_branch: true,
        push_master: true,
        push_protected_branch: true,
        push_remove_protected_branch: false,
        push_tag: true,
        push_new_tag: true,
        push_all: true,
        merge_into_protected_branch: true
      },

222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
      master: {
        push_new_branch: true,
        push_master: true,
        push_protected_branch: true,
        push_remove_protected_branch: false,
        push_tag: true,
        push_new_tag: true,
        push_all: true,
        merge_into_protected_branch: true
      },

      developer: {
        push_new_branch: true,
        push_master: true,
        push_protected_branch: false,
        push_remove_protected_branch: false,
        push_tag: false,
        push_new_tag: true,
        push_all: false,
        merge_into_protected_branch: false
      },

      reporter: {
        push_new_branch: false,
        push_master: false,
        push_protected_branch: false,
        push_remove_protected_branch: false,
        push_tag: false,
        push_new_tag: false,
        push_all: false,
        merge_into_protected_branch: false
      },

      guest: {
        push_new_branch: false,
        push_master: false,
        push_protected_branch: false,
        push_remove_protected_branch: false,
        push_tag: false,
        push_new_tag: false,
        push_all: false,
        merge_into_protected_branch: false
      }
    }

    [['feature', 'exact'], ['feat*', 'wildcard']].each do |protected_branch_name, protected_branch_type|
      context do
        before { create(:protected_branch, name: protected_branch_name, project: project) }

        run_permission_checks(permissions_matrix)
      end

274 275
      context "when developers are allowed to push into the #{protected_branch_type} protected branch" do
        before { create(:protected_branch, :developers_can_push, name: protected_branch_name, project: project) }
276 277 278 279

        run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true }))
      end

280 281
      context "developers are allowed to merge into the #{protected_branch_type} protected branch" do
        before { create(:protected_branch, :developers_can_merge, name: protected_branch_name, project: project) }
282 283 284 285

        context "when a merge request exists for the given source/target branch" do
          context "when the merge request is in progress" do
            before do
286
              create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature',
287
                                     state: 'locked', in_progress_merge_commit_sha: merge_into_protected_branch)
288 289
            end

290 291
            run_permission_checks(permissions_matrix.deep_merge(developer: { merge_into_protected_branch: true }))
          end
292

293 294 295
          context "when the merge request is not in progress" do
            before do
              create(:merge_request, source_project: project, source_branch: unprotected_branch, target_branch: 'feature', in_progress_merge_commit_sha: nil)
296
            end
297 298

            run_permission_checks(permissions_matrix.deep_merge(developer: { merge_into_protected_branch: false }))
299
          end
300

301
          context "when a merge request does not exist for the given source/target branch" do
302 303 304 305 306
            run_permission_checks(permissions_matrix.deep_merge(developer: { merge_into_protected_branch: false }))
          end
        end
      end

307 308
      context "when developers are allowed to push and merge into the #{protected_branch_type} protected branch" do
        before { create(:protected_branch, :developers_can_merge, :developers_can_push, name: protected_branch_name, project: project) }
309 310 311

        run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: true, push_all: true, merge_into_protected_branch: true }))
      end
312

313 314
      context "when no one is allowed to push to the #{protected_branch_name} protected branch" do
        before { create(:protected_branch, :no_one_can_push, name: protected_branch_name, project: project) }
315

316 317 318 319
        run_permission_checks(permissions_matrix.deep_merge(developer: { push_protected_branch: false, push_all: false, merge_into_protected_branch: false },
                                                            master: { push_protected_branch: false, push_all: false, merge_into_protected_branch: false },
                                                            admin: { push_protected_branch: false, push_all: false, merge_into_protected_branch: false }))
      end
320
    end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
321

322
  end
323

Kamil Trzcinski's avatar
Kamil Trzcinski committed
324 325
  shared_examples 'can not push code' do
    subject { access.check('git-receive-pack', '_any') }
326

Kamil Trzcinski's avatar
Kamil Trzcinski committed
327 328
    context 'when project is authorized' do
      before { key.projects << project }
329

Kamil Trzcinski's avatar
Kamil Trzcinski committed
330 331 332 333 334 335
      it { expect(subject).not_to be_allowed }
    end

    context 'when unauthorized' do
      context 'to public project' do
        let(:project) { create(:project, :public) }
336

337 338
        it { expect(subject).not_to be_allowed }
      end
339

Kamil Trzcinski's avatar
Kamil Trzcinski committed
340 341
      context 'to internal project' do
        let(:project) { create(:project, :internal) }
342

Kamil Trzcinski's avatar
Kamil Trzcinski committed
343 344
        it { expect(subject).not_to be_allowed }
      end
345

Kamil Trzcinski's avatar
Kamil Trzcinski committed
346 347
      context 'to private project' do
        let(:project) { create(:project, :internal) }
348

Kamil Trzcinski's avatar
Kamil Trzcinski committed
349
        it { expect(subject).not_to be_allowed }
350 351
      end
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
352
  end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374

  describe 'build capabilities permissions' do
    let(:capabilities) { build_capabilities }

    it_behaves_like 'cannot push code'
  end

  describe 'deploy key permissions' do
    let(:key) { create(:deploy_key) }
    let(:actor) { key }

    it_behaves_like 'cannot push code'
  end

  private

  def build_capabilities
    [
      :read_project,
      :build_download_code
    ]
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
375
end