Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
087e8328
Commit
087e8328
authored
Apr 06, 2017
by
Annabel Dunstone Gray
Committed by
Jacob Schatz
Apr 06, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix positioning of note icons
parent
f3a39afc
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
113 additions
and
104 deletions
+113
-104
app/assets/stylesheets/framework/timeline.scss
app/assets/stylesheets/framework/timeline.scss
+5
-2
app/assets/stylesheets/pages/notes.scss
app/assets/stylesheets/pages/notes.scss
+107
-101
app/helpers/system_note_helper.rb
app/helpers/system_note_helper.rb
+1
-1
app/views/shared/icons/_icon_clock_o.svg
app/views/shared/icons/_icon_clock_o.svg
+0
-0
No files found.
app/assets/stylesheets/framework/timeline.scss
View file @
087e8328
.timeline
{
@include
basic-list
;
margin
:
0
;
padding
:
0
;
.timeline-entry
{
padding
:
$gl-padding
$gl-btn-padding
1
1
px
;
padding
:
$gl-padding
$gl-btn-padding
1
4
px
;
border-color
:
$white-normal
;
color
:
$gl-text-color
;
border-bottom
:
1px
solid
$border-white-light
;
.timeline-entry-inner
{
position
:
relative
;
}
&
:target
{
background
:
$line-target-blue
;
}
...
...
app/assets/stylesheets/pages/notes.scss
View file @
087e8328
...
...
@@ -18,9 +18,12 @@ ul.notes {
float
:
left
;
svg
{
width
:
20px
;
height
:
auto
;
fill
:
$gl-text-color-secondary
;
height
:
18px
;
width
:
auto
;
fill
:
$gray-darkest
;
position
:
absolute
;
left
:
30px
;
top
:
15px
;
}
}
...
...
@@ -39,6 +42,103 @@ ul.notes {
white-space
:
nowrap
;
}
.discussion-body
{
padding-top
:
15px
;
}
.discussion
{
overflow
:
hidden
;
display
:
block
;
position
:
relative
;
}
.note
{
display
:
block
;
position
:
relative
;
border-bottom
:
1px
solid
$white-normal
;
&
.note-discussion
{
&
.timeline-entry
{
padding
:
14px
10px
;
}
.system-note
{
padding
:
0
;
}
}
&
.is-editting
{
.note-header
,
.note-text
,
.edited-text
{
display
:
none
;
}
.note-edit-form
{
display
:
block
;
&
.current-note-edit-form
+
.note-awards
{
display
:
none
;
}
}
}
.note-body
{
overflow-x
:
auto
;
overflow-y
:
hidden
;
.note-text
{
word-wrap
:
break-word
;
@include
md-typography
;
// Reset ul style types since we're nested inside a ul already
@include
bulleted-list
;
ul
.task-list
{
ul
:not
(
.task-list
)
{
padding-left
:
1
.3em
;
}
}
}
}
.note-awards
{
.js-awards-block
{
padding
:
2px
;
margin-top
:
10px
;
}
}
.note-header
{
padding-bottom
:
3px
;
padding-right
:
20px
;
@media
(
min-width
:
$screen-sm-min
)
{
padding-right
:
0
;
}
@media
(
max-width
:
$screen-xs-min
)
{
.inline
{
display
:
block
;
}
}
}
.note-emoji-button
{
.fa-spinner
{
display
:
none
;
}
&
.is-loading
{
.fa-smile-o
{
display
:
none
;
}
.fa-spinner
{
display
:
inline-block
;
}
}
}
}
.system-note
{
font-size
:
14px
;
padding
:
0
;
...
...
@@ -74,6 +174,10 @@ ul.notes {
padding
:
14px
10px
;
}
.note-header
{
padding-bottom
:
0
;
}
.note-body
{
overflow
:
hidden
;
...
...
@@ -137,104 +241,6 @@ ul.notes {
}
}
}
.discussion-body
{
padding-top
:
15px
;
}
.discussion
{
overflow
:
hidden
;
display
:
block
;
position
:
relative
;
}
.note
{
display
:
block
;
position
:
relative
;
border-bottom
:
1px
solid
$white-normal
;
&
.note-discussion
{
&
.timeline-entry
{
padding
:
14px
10px
;
}
.system-note
{
padding
:
0
;
}
}
&
.is-editting
{
.note-header
,
.note-text
,
.edited-text
{
display
:
none
;
}
.note-edit-form
{
display
:
block
;
&
.current-note-edit-form
+
.note-awards
{
display
:
none
;
}
}
}
.note-body
{
overflow-x
:
auto
;
overflow-y
:
hidden
;
.note-text
{
word-wrap
:
break-word
;
@include
md-typography
;
// Reset ul style types since we're nested inside a ul already
@include
bulleted-list
;
ul
.task-list
{
ul
:not
(
.task-list
)
{
padding-left
:
1
.3em
;
}
}
}
}
.note-awards
{
.js-awards-block
{
padding
:
2px
;
margin-top
:
10px
;
}
}
.note-header
{
padding-bottom
:
3px
;
padding-right
:
20px
;
@media
(
min-width
:
$screen-sm-min
)
{
padding-right
:
0
;
}
@media
(
max-width
:
$screen-xs-min
)
{
.inline
{
display
:
block
;
}
}
}
.note-emoji-button
{
.fa-spinner
{
display
:
none
;
}
&
.is-loading
{
.fa-smile-o
{
display
:
none
;
}
.fa-spinner
{
display
:
inline-block
;
}
}
}
}
}
// Diff code in discussion view
...
...
app/helpers/system_note_helper.rb
View file @
087e8328
...
...
@@ -14,7 +14,7 @@ module SystemNoteHelper
when
'closed'
'icon_status_closed'
when
'time_tracking'
'icon_
timer
'
'icon_
stopwatch
'
when
'assignee'
'icon_user'
when
'title'
...
...
app/views/shared/icons/icon_clock_o.svg
→
app/views/shared/icons/
_
icon_clock_o.svg
View file @
087e8328
File moved
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment