Cache the selectors

3d41a44d · Phil Hughes · dc87499e · 3d41a44d
Commit 3d41a44d authored Aug 01, 2016 by Phil Hughes
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

app/assets/javascripts/gl_dropdown.js.coffee app/assets/javascripts/gl_dropdown.js.coffee +5 -3

No files found.
--- a/app/assets/javascripts/gl_dropdown.js.coffee
+++ b/app/assets/javascripts/gl_dropdown.js.coffee
@@ -565,11 +565,13 @@ class GitLabDropdown
    if $el.length and currentIndex > -1
      e.preventDefault()
      e.stopImmediatePropagation()
+      $first = $el.first()
+      $firstEl = $first.get(0)

-      if $el.first().get(0).click
-        $el.first().get(0).click()
+      if $firstEl.click
+        $firstEl.click()
      else
-        $el.first().trigger('click')
+        $first.trigger('click')

  addArrowKeyEvent: ->
    ARROW_KEY_CODES = [38, 40]