Commit a4827ee2 authored by Z.J. van de Weg's avatar Z.J. van de Weg Committed by Z.J. van de Weg

Be able to POST subscriptions for system hooks

parent 76690017
...@@ -19,10 +19,14 @@ module API ...@@ -19,10 +19,14 @@ module API
success Entities::Hook success Entities::Hook
end end
params do params do
requires :url, type: String, desc: 'The URL for the system hook' requires :url, type: String, desc: "The URL to send the request to"
optional :token, type: String, desc: 'The token used to validate payloads'
optional :push_events, type: Boolean, desc: "Trigger hook on push events"
optional :tag_push_events, type: Boolean, desc: "Trigger hook on tag push events"
optional :enable_ssl_verification, type: Boolean, desc: "Do SSL verification when triggering the hook"
end end
post do post do
hook = SystemHook.new declared(params).to_h hook = SystemHook.new declared(params, include_missing: false).to_h
if hook.save if hook.save
present hook, with: Entities::Hook present hook, with: Entities::Hook
......
...@@ -13,6 +13,7 @@ describe API::API, api: true do ...@@ -13,6 +13,7 @@ describe API::API, api: true do
context "when no user" do context "when no user" do
it "returns authentication error" do it "returns authentication error" do
get api("/hooks") get api("/hooks")
expect(response).to have_http_status(401) expect(response).to have_http_status(401)
end end
end end
...@@ -20,6 +21,7 @@ describe API::API, api: true do ...@@ -20,6 +21,7 @@ describe API::API, api: true do
context "when not an admin" do context "when not an admin" do
it "returns forbidden error" do it "returns forbidden error" do
get api("/hooks", user) get api("/hooks", user)
expect(response).to have_http_status(403) expect(response).to have_http_status(403)
end end
end end
...@@ -27,9 +29,13 @@ describe API::API, api: true do ...@@ -27,9 +29,13 @@ describe API::API, api: true do
context "when authenticated as admin" do context "when authenticated as admin" do
it "returns an array of hooks" do it "returns an array of hooks" do
get api("/hooks", admin) get api("/hooks", admin)
byebug
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
expect(json_response).to be_an Array expect(json_response).to be_an Array
expect(json_response.first['url']).to eq(hook.url) expect(json_response.first['url']).to eq(hook.url)
expect(json_response.first['push_events']).to be true
expect(json_response.first['tag_push_events']).to be false
end end
end end
end end
...@@ -51,6 +57,14 @@ describe API::API, api: true do ...@@ -51,6 +57,14 @@ describe API::API, api: true do
post api("/hooks", admin) post api("/hooks", admin)
end.not_to change { SystemHook.count } end.not_to change { SystemHook.count }
end end
it 'allows the events to be selected' do
post api('/hooks', admin), url: 'http://mep.mep', enable_ssl_verification: true
expect(response).to have_http_status(201)
expect(json_response['enable_ssl_verification']).to be true
expect(json_response['tag_push_events']).to be false
end
end end
describe "GET /hooks/:id" do describe "GET /hooks/:id" do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment