Merge branch 'eslint' into 'master'

Add ESLint

## What does this MR do?

- create `package.json`
- add ESLint dependencies to `package.json`
- add JavaScript linting to CI
- add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`)

## Are there points in the code the reviewer needs to double check?

Probably not.

## Why was this MR needed?

My hovercraft was full of eels.

## What are the relevant issue numbers?

- https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658


See merge request !5445

.eslintignore

+/public/
+/tmp/
+/vendor/
+

.eslintrc

+{
+  "extends": "airbnb",
+  "globals": {
+    "$": false,
+    "_": false,
+    "beforeEach": false,
+    "d3": false,
+    "define": false,
+    "describe": false,
+    "document": false,
+    "expect": false,
+    "fixture": false,
+    "gl": false,
+    "it": false,
+    "jQuery": false,
+    "Mousetrap": false,
+    "spyOn": false,
+    "spyOnEvent": false,
+    "Turbolinks": false,
+    "window": false
+  }
+}
+

.gitignore

@@ -37,6 +37,7 @@
 /doc/code/*
 /dump.rdb
 /log/*.log*
+/node_modules/
 /nohup.out
 /public/assets/
 /public/uploads.*

.gitlab-ci.yml

@@ -311,6 +311,14 @@ coverage:
     - coverage/index.html
     - coverage/assets/
 
+lint-javascript:
+  stage: test
+  image: "node:latest"
+  before_script:
+    - npm install
+  script:
+    - npm run eslint
+
 # Trigger docs build
 # https://gitlab.com/gitlab-com/doc-gitlab-com/blob/master/README.md#deployment-process
 trigger_docs:

app/assets/javascripts/abuse_reports.js.es6

+/* eslint-disable */
 ((global) => {
   const MAX_MESSAGE_LENGTH = 500;
   const MESSAGE_CELL_SELECTOR = '.abuse-reports .message';

app/assets/javascripts/activities.js

+/* eslint-disable */
 (function() {
   this.Activities = (function() {
     function Activities() {

app/assets/javascripts/admin.js

+/* eslint-disable */
 (function() {
   this.Admin = (function() {
     function Admin() {

app/assets/javascripts/api.js

+/* eslint-disable */
 (function() {
   this.Api = {
     groupsPath: "/api/:version/groups.json",

app/assets/javascripts/application.js

+/* eslint-disable */
 // This is a manifest file that'll be compiled into including all the files listed below.
 // Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
 // be included in the compiled file accessible from http://example.com/assets/application.js

app/assets/javascripts/aside.js

+/* eslint-disable */
 (function() {
   this.Aside = (function() {
     function Aside() {

app/assets/javascripts/autosave.js

+/* eslint-disable */
 (function() {
   this.Autosave = (function() {
     function Autosave(field, key) {

app/assets/javascripts/awards_handler.js

+/* eslint-disable */
 (function() {
   this.AwardsHandler = (function() {
     const FROM_SENTENCE_REGEX = /(?:, and | and |, )/; //For separating lists produced by ruby's Array#toSentence

app/assets/javascripts/behaviors/autosize.js

+/* eslint-disable */
 
 /*= require jquery.ba-resize */
 /*= require autosize */

app/assets/javascripts/behaviors/details_behavior.js

+/* eslint-disable */
 (function() {
   $(function() {
     $("body").on("click", ".js-details-target", function() {

app/assets/javascripts/behaviors/quick_submit.js

+/* eslint-disable */
 // Quick Submit behavior
 //
 // When a child field of a form with a `js-quick-submit` class receives a

app/assets/javascripts/behaviors/requires_input.js

+/* eslint-disable */
 // Requires Input behavior
 //
 // When called on a form with input fields with the `required` attribute, the

app/assets/javascripts/behaviors/toggler_behavior.js

+/* eslint-disable */
 (function(w) {
   $(function() {
     // Toggle button. Show/hide content inside parent container.

app/assets/javascripts/blob/blob_ci_yaml.js.es6

+/* eslint-disable */
 /*= require blob/template_selector */
 ((global) => {
 

app/assets/javascripts/blob/blob_file_dropzone.js

+/* eslint-disable */
 (function() {
   this.BlobFileDropzone = (function() {
     function BlobFileDropzone(form, method) {

app/assets/javascripts/blob/blob_gitignore_selector.js

+/* eslint-disable */
 
 /*= require blob/template_selector */
 

app/assets/javascripts/blob/blob_gitignore_selectors.js

+/* eslint-disable */
 (function() {
   this.BlobGitignoreSelectors = (function() {
     function BlobGitignoreSelectors(opts) {

app/assets/javascripts/blob/blob_license_selector.js

+/* eslint-disable */
 
 /*= require blob/template_selector */
 

app/assets/javascripts/blob/blob_license_selectors.js.es6

+/* eslint-disable */
 ((global) => {
   class BlobLicenseSelectors {
     constructor({ $dropdowns, editor }) {

app/assets/javascripts/blob/template_selector.js.es6

+/* eslint-disable */
 ((global) => {
     class TemplateSelector {
       constructor({ dropdown, data, pattern, wrapper, editor, fileEndpoint, $input } = {}) {

app/assets/javascripts/blob_edit/blob_edit_bundle.js

+/* eslint-disable */
 /*= require_tree . */
 
 (function() {

app/assets/javascripts/blob_edit/edit_blob.js

+/* eslint-disable */
 (function() {
   var bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 

app/assets/javascripts/boards/boards_bundle.js.es6

+/* eslint-disable */
 //= require vue
 //= require vue-resource
 //= require Sortable

app/assets/javascripts/boards/components/board.js.es6

+/* eslint-disable */
 //= require ./board_blank_state
 //= require ./board_delete
 //= require ./board_list

app/assets/javascripts/boards/components/board_blank_state.js.es6

+/* eslint-disable */
 (() => {
   const Store = gl.issueBoards.BoardsStore;
 

app/assets/javascripts/boards/components/board_card.js.es6

+/* eslint-disable */
 (() => {
   const Store = gl.issueBoards.BoardsStore;
 

app/assets/javascripts/boards/components/board_delete.js.es6

+/* eslint-disable */
 (() => {
   window.gl = window.gl || {};
   window.gl.issueBoards = window.gl.issueBoards || {};

app/assets/javascripts/boards/components/board_list.js.es6

+/* eslint-disable */
 //= require ./board_card
 //= require ./board_new_issue
 

app/assets/javascripts/boards/components/board_new_issue.js.es6

+/* eslint-disable */
 (() => {
   const Store = gl.issueBoards.BoardsStore;
 

app/assets/javascripts/boards/components/new_list_dropdown.js.es6

+/* eslint-disable */
 $(() => {
   const Store = gl.issueBoards.BoardsStore;
 

app/assets/javascripts/boards/mixins/sortable_default_options.js.es6

+/* eslint-disable */
 ((w) => {
   window.gl = window.gl || {};
   window.gl.issueBoards = window.gl.issueBoards || {};

app/assets/javascripts/boards/models/issue.js.es6

+/* eslint-disable */
 class ListIssue {
   constructor (obj) {
     this.id = obj.iid;

app/assets/javascripts/boards/models/label.js.es6

+/* eslint-disable */
 class ListLabel {
   constructor (obj) {
     this.id = obj.id;

app/assets/javascripts/boards/models/list.js.es6

+/* eslint-disable */
 class List {
   constructor (obj) {
     this.id = obj.id;

app/assets/javascripts/boards/models/user.js.es6

+/* eslint-disable */
 class ListUser {
   constructor (user) {
     this.id = user.id;

app/assets/javascripts/boards/services/board_service.js.es6

+/* eslint-disable */
 class BoardService {
   constructor (root, boardId) {
     this.lists = Vue.resource(`${root}/${boardId}/lists{/id}`, {}, {

app/assets/javascripts/boards/stores/boards_store.js.es6

+/* eslint-disable */
 (() => {
   window.gl = window.gl || {};
   window.gl.issueBoards = window.gl.issueBoards || {};

app/assets/javascripts/boards/test_utils/simulate_drag.js

+/* eslint-disable */
 (function () {
 	'use strict';
 

app/assets/javascripts/boards/vue_resource_interceptor.js.es6

+/* eslint-disable */
 Vue.http.interceptors.push((request, next) => {
   Vue.activeResources = Vue.activeResources ? Vue.activeResources + 1 : 1;
 

app/assets/javascripts/breakpoints.js

+/* eslint-disable */
 (function() {
   this.Breakpoints = (function() {
     var BreakpointInstance, instance;

app/assets/javascripts/broadcast_message.js

+/* eslint-disable */
 (function() {
   $(function() {
     var previewPath;

app/assets/javascripts/build.js

+/* eslint-disable */
 (function() {
   var bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 

app/assets/javascripts/build_artifacts.js

+/* eslint-disable */
 (function() {
   this.BuildArtifacts = (function() {
     function BuildArtifacts() {

app/assets/javascripts/build_variables.js.es6

+/* eslint-disable */
 $(function(){
   $('.reveal-variables').off('click').on('click',function(){
     $('.js-build').toggle().niceScroll();

app/assets/javascripts/commit.js

+/* eslint-disable */
 (function() {
   this.Commit = (function() {
     function Commit() {

app/assets/javascripts/commit/file.js

+/* eslint-disable */
 (function() {
   this.CommitFile = (function() {
     function CommitFile(file) {

app/assets/javascripts/commit/image_file.js

+/* eslint-disable */
 (function() {
   this.ImageFile = (function() {
     var prepareFrames;

app/assets/javascripts/commits.js

+/* eslint-disable */
 (function() {
   this.CommitsList = (function() {
     function CommitsList() {}

app/assets/javascripts/compare.js

+/* eslint-disable */
 (function() {
   this.Compare = (function() {
     function Compare(opts) {

app/assets/javascripts/compare_autocomplete.js.es6

+/* eslint-disable */
 (function() {
   this.CompareAutocomplete = (function() {
     function CompareAutocomplete() {

app/assets/javascripts/confirm_danger_modal.js

+/* eslint-disable */
 (function() {
   this.ConfirmDangerModal = (function() {
     function ConfirmDangerModal(form, text) {

app/assets/javascripts/copy_to_clipboard.js

+/* eslint-disable */
 
 /*= require clipboard */
 

app/assets/javascripts/create_label.js.es6

+/* eslint-disable */
 (function (w) {
   class CreateLabelDropdown {
     constructor ($el, namespacePath, projectPath) {

app/assets/javascripts/cycle_analytics.js.es6

+/* eslint-disable */
 //= require vue
 
 ((global) => {

app/assets/javascripts/diff.js

+/* eslint-disable */
 (function() {
   this.Diff = (function() {
     var UNFOLD_COUNT;

app/assets/javascripts/diff_notes/components/comment_resolve_btn.js.es6

+/* eslint-disable */
 ((w) => {
   w.CommentAndResolveBtn = Vue.extend({
     props: {

app/assets/javascripts/diff_notes/components/jump_to_discussion.js.es6

+/* eslint-disable */
 (() => {
   JumpToDiscussion = Vue.extend({
     mixins: [DiscussionMixins],

app/assets/javascripts/diff_notes/components/resolve_btn.js.es6

+/* eslint-disable */
 ((w) => {
   w.ResolveBtn = Vue.extend({
     props: {

app/assets/javascripts/diff_notes/components/resolve_count.js.es6

+/* eslint-disable */
 ((w) => {
   w.ResolveCount = Vue.extend({
     mixins: [DiscussionMixins],

app/assets/javascripts/diff_notes/components/resolve_discussion_btn.js.es6

+/* eslint-disable */
 ((w) => {
   w.ResolveDiscussionBtn = Vue.extend({
     props: {

app/assets/javascripts/diff_notes/diff_notes_bundle.js.es6

+/* eslint-disable */
 //= require vue
 //= require vue-resource
 //= require_directory ./models

app/assets/javascripts/diff_notes/mixins/discussion.js.es6

+/* eslint-disable */
 ((w) => {
   w.DiscussionMixins = {
     computed: {

app/assets/javascripts/diff_notes/models/discussion.js.es6

+/* eslint-disable */
 class DiscussionModel {
   constructor (discussionId) {
     this.id = discussionId;

app/assets/javascripts/diff_notes/models/note.js.es6

+/* eslint-disable */
 class NoteModel {
   constructor (discussionId, noteId, canResolve, resolved, resolved_by) {
     this.discussionId = discussionId;

app/assets/javascripts/diff_notes/services/resolve.js.es6

+/* eslint-disable */
 ((w) => {
   class ResolveServiceClass {
     constructor() {

app/assets/javascripts/diff_notes/stores/comments.js.es6

+/* eslint-disable */
 ((w) => {
   w.CommentsStore = {
     state: {},

app/assets/javascripts/dispatcher.js.es6

+/* eslint-disable */
 (function() {
   var Dispatcher;
 

app/assets/javascripts/dropzone_input.js

+/* eslint-disable */
 
 /*= require preview_markdown */
 

app/assets/javascripts/due_date_select.js.es6

+/* eslint-disable */
 (function(global) {
   class DueDateSelect {
     constructor({ $dropdown, $loading } = {}) {

app/assets/javascripts/extensions/array.js

+/* eslint-disable */
 Array.prototype.first = function() {
   return this[0];
 }

app/assets/javascripts/extensions/element.js.es6

+/* eslint-disable */
 Element.prototype.matches = Element.prototype.matches || Element.prototype.msMatches;
 
 Element.prototype.closest = function closest(selector, selectedElement = this) {

app/assets/javascripts/extensions/jquery.js

+/* eslint-disable */
 // Disable an element and add the 'disabled' Bootstrap class
 (function() {
   $.fn.extend({

app/assets/javascripts/files_comment_button.js

+/* eslint-disable */
 (function() {
   var bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 

app/assets/javascripts/flash.js

+/* eslint-disable */
 (function() {
   this.Flash = (function() {
     var hideFlash;

app/assets/javascripts/gfm_auto_complete.js.es6

+/* eslint-disable */
 // Creates the variables for setting up GFM auto-completion
 (function() {
   if (window.GitLab == null) {

app/assets/javascripts/gl_dropdown.js

+/* eslint-disable */
 (function() {
   var GitLabDropdown, GitLabDropdownFilter, GitLabDropdownRemote,
     bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; },

app/assets/javascripts/gl_field_errors.js.es6

+/* eslint-disable */
 ((global) => {
   /*
    * This class overrides the browser's validation error bubbles, displaying custom

app/assets/javascripts/gl_form.js

+/* eslint-disable */
 (function() {
   this.GLForm = (function() {
     function GLForm(form) {

app/assets/javascripts/graphs/graphs_bundle.js

+/* eslint-disable */
 // This is a manifest file that'll be compiled into including all the files listed below.
 // Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
 // be included in the compiled file accessible from http://example.com/assets/application.js

app/assets/javascripts/graphs/stat_graph.js

+/* eslint-disable */
 (function() {
   this.StatGraph = (function() {
     function StatGraph() {}

app/assets/javascripts/graphs/stat_graph_contributors.js

+/* eslint-disable */
 
 /*= require d3 */
 

app/assets/javascripts/graphs/stat_graph_contributors_graph.js

+/* eslint-disable */
 
 /*= require d3 */
 

app/assets/javascripts/graphs/stat_graph_contributors_util.js

+/* eslint-disable */
 (function() {
   window.ContributorsStatGraphUtil = {
     parse_log: function(log) {

app/assets/javascripts/group_avatar.js

+/* eslint-disable */
 (function() {
   this.GroupAvatar = (function() {
     function GroupAvatar() {

app/assets/javascripts/groups_select.js

+/* eslint-disable */
 (function() {
   var slice = [].slice;
 

app/assets/javascripts/importer_status.js

+/* eslint-disable */
 (function() {
   this.ImporterStatus = (function() {
     function ImporterStatus(jobs_url, import_url) {

app/assets/javascripts/issuable.js.es6

+/* eslint-disable */
 (function() {
   var issuable_created;
 

app/assets/javascripts/issuable_context.js

+/* eslint-disable */
 (function() {
   this.IssuableContext = (function() {
     function IssuableContext(currentUser) {

app/assets/javascripts/issuable_form.js

+/* eslint-disable */
 (function() {
   var bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 

app/assets/javascripts/issue.js

+/* eslint-disable */
 
 /*= require flash */
 /*= require jquery.waitforimages */

app/assets/javascripts/issue_status_select.js

+/* eslint-disable */
 (function() {
   this.IssueStatusSelect = (function() {
     function IssueStatusSelect() {

app/assets/javascripts/issues_bulk_assignment.js.es6

+/* eslint-disable */
 ((global) => {
 
   class IssuableBulkActions {

app/assets/javascripts/label_manager.js.es6

+/* eslint-disable */
 ((global) => {
 
   class LabelManager {

app/assets/javascripts/labels.js

+/* eslint-disable */
 (function() {
   var bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 

app/assets/javascripts/labels_select.js

+/* eslint-disable */
 (function() {
   this.LabelsSelect = (function() {
     function LabelsSelect() {

app/assets/javascripts/layout_nav.js

+/* eslint-disable */
 (function() {
   var hideEndFade;