An error occurred fetching the project authors.
  1. 19 Aug, 2016 1 commit
  2. 17 Aug, 2016 1 commit
  3. 12 Aug, 2016 7 commits
  4. 11 Aug, 2016 3 commits
  5. 03 Aug, 2016 6 commits
  6. 02 Aug, 2016 1 commit
    • Paco Guzman's avatar
      Speedup DiffNote#active? on discussions, preloading noteables and avoid... · 8716ff7f
      Paco Guzman authored
      Speedup DiffNote#active? on discussions, preloading noteables and avoid touching git repository to return diff_refs when possible
      
      - Preloading noteable we share the same noteable instance when more than one 
      discussion refers to the same noteable.
      - Any other call to that object that is cached in that object will be for any 
      discussion.
      - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that 
      diff_refs using directly those sha instead accessing to the git repository to first get the 
      commits and later the sha.
      8716ff7f
  7. 31 Jul, 2016 2 commits
  8. 29 Jul, 2016 2 commits
  9. 26 Jul, 2016 1 commit
  10. 18 Jul, 2016 1 commit
  11. 13 Jul, 2016 4 commits
    • Robert Speicher's avatar
      Revert "Merge branch '18193-developers-can-merge' into 'master' · 530f5158
      Robert Speicher authored
      This reverts commit 9ca633eb, reversing
      changes made to fb229bbf.
      530f5158
    • Timothy Andrew's avatar
      Don't ask the user to "merge this request manually". · af7e7516
      Timothy Andrew authored
      1. If they are a developer with "Developers can Merge" switched on.
      af7e7516
    • Timothy Andrew's avatar
      Refactor `Gitlab::GitAccess` · 60245bbe
      Timothy Andrew authored
      1. Don't use case statements for dispatch anymore. This leads to a lot
         of duplication, and makes the logic harder to follow.
      
      2. Remove duplicated logic.
      
          - For example, the `can_push_to_branch?` exists, but we also have a
            different way of checking the same condition within `change_access_check`.
      
          - This kind of duplication is removed, and the `can_push_to_branch?`
            method is used in both places.
      
      3. Move checks returning true/false to `UserAccess`.
      
          - All public methods in `GitAccess` now return an instance of
            `GitAccessStatus`. Previously, some methods would return
            true/false as well, which was confusing.
      
          - It makes sense for these kinds of checks to be at the level of a
            user, so the `UserAccess` class was repurposed for this. The prior
            `UserAccess.allowed?` classmethod is converted into an instance
            method.
      
          - All external uses of these checks have been migrated to use the
            `UserAccess` class
      
      4. Move the "change_access_check" into a separate class.
      
          - Create the `GitAccess::ChangeAccessCheck` class to run these
            checks, which are quite substantial.
      
          - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as
            well.
      
      5. Break out the boolean logic in `ChangeAccessCheck` into `if/else`
         chains - this seems more readable.
      
      6. I can understand that this might look like overkill for !4892, but I
         think this is a good opportunity to clean it up.
      
          - http://martinfowler.com/bliki/OpportunisticRefactoring.html
      60245bbe
    • Mathias Vestergaard's avatar
      Added "developers can merge" setting to protected branches · f0577d83
      Mathias Vestergaard authored
      - Cherry-picked from `mvestergaard:branch-protection-dev-merge`
      - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4220
      f0577d83
  12. 08 Jul, 2016 2 commits
  13. 06 Jul, 2016 7 commits
  14. 05 Jul, 2016 2 commits