- 25 Jan, 2017 40 commits
-
-
Fatih Acet authored
Resolve "Line numbers now in copy pasta data" Closes #27021 See merge request !8706
-
Douwe Maan authored
Fix race conditions for AuthorizedProjectsWorker Closes #26194 and #26310 See merge request !8701
-
Alejandro Rodríguez authored
[ci skip]
-
Fatih Acet authored
Fixed label select toggle not updating correctly Closes #26119 See merge request !8601
-
Fatih Acet authored
Fix autocomplete initial undefined state (loading) Closes #26775 See merge request !8667
-
Fatih Acet authored
Prevent removal of input that is the parent dropdown element Closes #25312 See merge request !8397
-
Grzegorz Bizon authored
Fix CI requests concurrency See merge request !8760
-
Grzegorz Bizon authored
Backport changes introduced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1078 See merge request !8657
-
Annabel Dunstone Gray authored
Fix mini-pipeline stage tooltip text wrapping Closes #27014 See merge request !8771
-
Clement Ho authored
Display fullscreen button on small screens Closes #19891 See merge request !5302
-
Alejandro Rodríguez authored
-
winniehell authored
-
Sam Rose authored
-
Yorick Peterse authored
EE backport for new application settings update service See merge request !8665
-
Rémy Coutable authored
Fix spec failure due to timestamp ordering issue in mySQL Closes #26622 See merge request !8778
-
Dmitriy Zaporozhets authored
Fix 500 error for Group#web_url method if nested group See merge request !8743
-
Kamil Trzcinski authored
-
Dmitriy Zaporozhets authored
Nested groups feature improvemetns See merge request !8448
-
Sean McGivern authored
Update enviroments.md - example CURL requests had a typo in the URL See merge request cd ../gdk-ee/
-
Sean McGivern authored
Enable HAML-LINT linters phase 2 Closes #22072 See merge request !8566
-
Yorick Peterse authored
There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
-
Rémy Coutable authored
Fixed error with filter keyboard tests See merge request !8777
-
Sean McGivern authored
Only show Merge Request button when user can create a MR See merge request !8639
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Sean McGivern authored
Support notes without a project (personal snippets notes) See merge request !8468
-
James Lopez authored
-
Phil Hughes authored
Issue filter now appends a space & the test wasn't taking this into account when checking the value
-
Rémy Coutable authored
Grapify last endpoint of the branches API See merge request !8755
-
Toon Claes authored
`can?` already includes the `feature_available?` check, so no need to check this again.
-
Toon Claes authored
In case Merge Requests are disabled on the project, no one should see the Merge Request button.
-
Toon Claes authored
The project was not public and this caused a 404. So the tests were giving deceiving results. By searching for the Merge Request button in `#content-body` this is overcome, and also other Merge Request buttons (e.g. in the sidebar) are ignored.
-
Sean McGivern authored
Make diff discussions more reliable Closes #23646 See merge request !8378
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
The conflict happens when we try to update a build, but fail to do so due to fact that we update the same build concurrently for two different runners.
-
Kamil Trzcinski authored
-
Jarka Kadlecova authored
-
Jacob Schatz authored
Only render the list if it is visible See merge request !8710
-
Jacob Schatz authored
Fixed keyboard navigation not working in filtered search bar Closes #26840 See merge request !8656
-