- 22 Nov, 2016 40 commits
-
-
Fatih Acet authored
Disabled award emoji button when user is not logged in ## What does this MR do? The award emoji buttons are now disabled when the user is not signed in, stopping them from clicking it & then getting an error. ## Screenshots (if relevant) ![Screen_Shot_2016-11-22_at_10.25.20](/uploads/210378bde90e689fbc12940ce271c05e/Screen_Shot_2016-11-22_at_10.25.20.png) ## What are the relevant issue numbers? Closes #24680 See merge request !7651
-
Kamil Trzciński authored
Fix exceptions when loading build trace ## What does this MR do? This MR fixes exceptions when loading build trace. - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [x] Tests added for this feature/bug ## What are the relevant issue numbers? Closes #24638 See merge request !7658
-
Fatih Acet authored
Resolve "Labeling system notes downcase labels" ## What does this MR do? This MR fixes issues of label gets lowercase in system note as describe in #24737 ## Are there points in the code the reviewer needs to double check? NR ## Why was this MR needed? This MR fixes the regression of becoming labels and its description and title lowercase in system note ## Screenshots (if relevant) **Before:** ![before](/uploads/ac99fd5d1219ee3b4b7c699319267087/before.png) **After:** ![after](/uploads/d1b6413c857d18f122252f421ac498b0/after.png) ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24737 Closes #24751 See merge request !7636
-
Achilleas Pipinellis authored
Add changes to JIRA api docs See merge request !7675
-
Fatih Acet authored
shows unconfirmed email status in profile ## What does this MR do? This MR closes #24413 ## Are there points in the code the reviewer needs to double check? NR ## Why was this MR needed? When modifying an account email address in profile settings a new confirmation email is sent, and shows the information that s/he got an email to confirm. ## Screenshots (if relevant) **Before** ![2016-11-22_19.54.51](/uploads/361fd605a3c1e997a58defe45a63081a/2016-11-22_19.54.51.gif) **After** ![2016-11-22_20.01.21](/uploads/6b07663f71d6684d2138798920cf07af/2016-11-22_20.01.21.gif) ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24413 See merge request !7611
-
Annabel Dunstone Gray authored
Last minute CI Style tweaks for 8.14 ## What does this MR do? - Skipped builds now have use a lighter gray. - Converted all status icons to be managed by scss colors only - Consolidated all status icon styles into icons.scss - Deleted any classes or styles within the svg's - Gave status badges a hover style, but only if clickable - Fixed alignment issue mini-pipeline graph ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? As per the discussion in the slack chat https://gitlab.slack.com/archives/ci/p1479743986004879 ## Screenshots (if relevant) - skipped builds: ![image](/uploads/f59c615045472b9b13940463a64c8038/image.png) ![image](/uploads/26503d1da9c93b3c22c5c0c1369feceb/image.png) - hover style status badges: ![2016-11-22_00.21.27](/uploads/36afa7aa64d60e1755bf39d97f90c59f/2016-11-22_00.21.27.gif)![2016-11-22_00.58.38](/uploads/1d95fa5db124412d3f83b3e79b9b71ec/2016-11-22_00.58.38.gif) - mini pipeline graph: before: ![image](/uploads/38e5e57ada3907b17c6e24e1446b4514/image.png) after: ![image](/uploads/de4476693a1397eebfc680661159daf7/image.png) ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !7643
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
[ci skip]
-
Rémy Coutable authored
See merge request !7676
-
Alejandro Rodríguez authored
-
Achilleas Pipinellis authored
[ci skip]
-
James Lopez authored
fixed bug to do with calculating durations Fixes a couple of small bugs while calculating durations in cycle analytics - probably due to some bad refactoring - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24796 See merge request !7663
-
Achilleas Pipinellis authored
[ci skip]
-
Kamil Trzciński authored
Merge branch '24804-wrong-render-index-should-be-render-show-in-projects-pipelinessettingscontroller-update' into 'master' Resolve "Wrong `render 'index'`, should be `render 'show'` in `Projects::PipelinesSettingsController#update`" Closes #24804 See merge request !7665
-
Rémy Coutable authored
See merge request !7672
-
Alejandro Rodríguez authored
-
Kamil Trzciński authored
Issue creation now accepts trailing whitespace See merge request !7633
-
Sean McGivern authored
Add shortcuts for adding users to a project team with a specific role Closes #20944 See merge request !7565
-
Rémy Coutable authored
Do not use MergeRequest#commits in define_pipelines_vars ## What does this MR do? `MergeRequest#commits` requires merge_request_diff to be present. This is not the case when creating a new merge request. ## What are the relevant issue numbers? Fix up for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7568 Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24798 See merge request !7664
-
Sean McGivern authored
Allow admins to stop impersonating users without e-mail addresses Closes #24576 See merge request !7550
-
Rémy Coutable authored
Fix IID filter for merge requests and milestones I updated the example in the docs and added a test. The milestones API was also broken for the same reason. Related to !7358 and !7373 See merge request !7648
-
Rémy Coutable authored
Handle orphans when removing soft deleted groups This fixes the migration from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7528 so it handles orphans as mentioned in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7528/diffs#note_18800962. This needs to go in 8.14.0 as otherwise customers may run into the same problem. See merge request !7657
-
Achilleas Pipinellis authored
Add new image for Cycle Analytics See merge request !7666
-
Rémy Coutable authored
Add concern for reuse pagination params declaration in API Closes #23532 See merge request !7646
-
Achilleas Pipinellis authored
[ci skip]
-
James Lopez authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Achilleas Pipinellis authored
Revert "Merge branch 'docs/jira-old' into 'master'" See merge request !7531
-
Adam Niedzielski authored
MergeRequest#commits requires merge_request_diff to be present. This is not the case when creating a new merge request.
-
James Lopez authored
-
Yorick Peterse authored
There may be more tables but these were the tables that were problematic for GitLab.com due to foreign key constraints (without cascading deletes).
-
Grzegorz Bizon authored
-
Fatih Acet authored
Improve readability of environments table ## What does this MR do? Fix the environments table columns width ## Before ![Screen_Shot_2016-11-21_at_18.13.00](/uploads/1771b0546eb3cb15f4894b719fd44286/Screen_Shot_2016-11-21_at_18.13.00.png) ## After ![Screen_Shot_2016-11-21_at_18.11.18](/uploads/a20194a055b6ec0f7989f0c1499883d3/Screen_Shot_2016-11-21_at_18.11.18.png) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !7628
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
Fatih Acet authored
Add help section for MM commands ## What should this MR do Check @pedroms' design for the Mattermost service screen: https://gitlab.com/gitlab-org/gitlab-ce/issues/22540 Now this has to be implemented, I've created a clean canvas for you, @lbennett, to draw on. ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !7558
-
Kamil Trzciński authored
External jobs do not have show page nor traces Fixes #24677 See merge request !7617
-
Rémy Coutable authored
Avoid helper call with default parameters The helpers can ultimately be removed when the issue API uses the Grape DSL. See merge request !7649
-
Grzegorz Bizon authored
-
Robert Schilling authored
-