- 02 Jun, 2021 10 commits
-
-
Jérome Perrin authored
payment transaction group workflow's deliver action is a two step delivery, which "start delivery" and wait for an interaction to finish the delivery. Add a default interaction workflow which finishes the delivery immediately, otherwise the payment transaction group stay in delivering state when user use the Deliver workflow action.
-
Jérome Perrin authored
For same reasons as f692aa61 ([erp5_bank_reconciliation] Rename your_mode field, to prevent naming conflict in hal, 2019-10-23)
-
Jérome Perrin authored
Enable the "select column" of the listbox so that user can choose one by one the lines to add to the group. The default action, when nothing is selected, remain the same "select everything".
-
Jérome Perrin authored
This uses a listbox search column, which is not yet supported in ERP5JS, so for now the feature is only available in erp5_xhtml_style.
-
Jérome Perrin authored
Show an empty listbox at the beginning, that will be populated when user start to search. This is required if we want the ?reset=1 from the action URL to really reset the selection.
-
Jérome Perrin authored
This list is currently not sortable, so don't show sort column
-
Jérome Perrin authored
This was often leaving a comment with 'None'
-
Jérome Perrin authored
Checking that for all lines: - bank account is set, for both sides - bank accounts have IBAN and BIC - bank accounts are validated - bank accounts belong to the section (to prevent problem when cloning and not changing the bank account) These constraints are present in a property sheet that have to be associated to accounting transaction movement portal type in a configurator step, and also as assertions in the file generation.
-
Jérome Perrin authored
and only show the generate credit transfer action if the payment mode is correct.
-
Jérome Perrin authored
-
- 31 May, 2021 17 commits
-
-
Jérome Perrin authored
For SEPA files "End to End ID" we need a reference on payment transactions. In the first prototype, the reference was set at the time of generating the file, but it's a non common behaviour to generate reference when producing reports, so we changed to ensuring payment has reference when adding to the group.
-
Jérome Perrin authored
Instead of using only setAggregate(), specify a portal type to consider only payment transaction groups.
-
Jérome Perrin authored
Because of the wrong TALES, jump and select was not working on the aggregate relation field on accounting transaction line.
-
Jérome Perrin authored
Support generating pain.001.001.02 credit transfer from payment transaction groups.
-
Jérome Perrin authored
-
Jérome Perrin authored
Having a portal type is required to use the listbox as "Proxy Listbox ID" in a relation field.
-
Jérome Perrin authored
Follow the same rule that allow other organisations from the same group to use bank account from the main section when selecting the payments and displaying the payments from the group.
-
Jérome Perrin authored
This constraint will have to be enabled by configurator/upgrader.
-
Jérome Perrin authored
-
Jérome Perrin authored
Instead of selecting already stopped payments, introduce a new "mode" field in the dialog, where user can choose the previous behavior of selecting stopped payments, or a new behavior where user would select planned or confirmed payments, in that case the payments will be automatically stopped before being added to the group.
-
Jérome Perrin authored
Functional test for erp5_payment_mean with ERP5JS
-
Jérome Perrin authored
Functional test for erp5_payment_mean
-
Jérome Perrin authored
Rename the field, because on xhtml_style, submitting the field with an empty limit now cause an error like: ValueError: invalid literal for int() with base 10: '' and on ERP5JS it is ignoed. Also, make the field required and set a small default value and a range, to prevent accidentally displaying/selecting too much when there's lot of data matching.
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
We don't want to show the ID which has a prefix, but the reference
-
Jérome Perrin authored
See merge request nexedi/erp5!1427
-
- 27 May, 2021 4 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
testSQLCachedWorklist is now part of a dedicated erp5_worklist_sql_test business template.
-
Jérome Perrin authored
This script creates Web Message, not Mail Message
-
- 26 May, 2021 6 commits
-
-
Roque authored
See merge request nexedi/erp5!1411
-
Jérome Perrin authored
Fixes [#20210517-960A47](https://erp5js.nexedi.net/#/bug_module/20210517-960A47) The most important changes are: - coding style is enabled again for workflow scripts and starts to be enabled for ERP5 Python scripts - monaco editor support for workflow scripts, SQL methods and .less - small fixes for python/workflow scripts forms and ZMI See merge request !1422
-
Jérome Perrin authored
Changing state directly in Base_contribute was only functional for the case where metadata was discovered asynchronously. In the case of synchronous discovery, the state was first changed state, and Document_convertToBaseFormatAndDiscoverMetadata was executed - but this this was causing Unauthorized like this: Module script, line 10, in Document_convertToBaseFormatAndDiscoverMetadata - <PythonScript at /erp5/Document_convertToBaseFormatAndDiscoverMetadata used for /erp5/document_module/163> - Line 10 return context.discoverMetadata(filename=filename, Unauthorized: You are not allowed to access 'discoverMetadata' in this context because once we have already changed state, regular user no longer have permission to access discoverMetadata, because that method needs ModifyPortalContent permission. Instead, of handling publication_state only in Base_contribute, treat it like others user input parameter and change state during discovery. Tests were also re-organised to move Base_contribute related test in testIngestion and also to run Base_contribute tests as a non-manager user.
-
Jérome Perrin authored
This was never supported, we support only [state in $workflow_id] See also: https://erp5js.nexedi.net/#/bug_module/1740 b6dcbc19 (l10n_fr,l10n_jp: Fix translation of "Open", 2021-04-30) Generated from this script: #!/srv/slapgrid/slappart3/srv/runner/software/cc0326f0dcb093f56c01291c300c8481/parts/erp5/venv/bin/python import polib import sys import re pofile = polib.pofile(sys.argv[1]) msgs = dict() for entry in pofile: msgs[entry.msgid] = entry.msgstr transition_re = re.compile(r'(.*) \[transition in .*\]') fixed_messages = dict() for entry in pofile: match = transition_re.match(entry.msgid) if match: # in erp5_l10n_de some msgstr also have the [transition in ...], we drop them if transition_re.match(entry.msgstr): continue short = match.groups()[0] if short.endswith('Action'): continue if short not in msgs: print(f"
🤔 {short} not translated ( from {entry.msgid} )") fixed_messages[short] = entry.msgstr else: fixed_messages[entry.msgid] = entry.msgstr pofile.clear() for k, v in fixed_messages.items(): pofile.append(polib.POEntry(msgid=k, msgstr=v)) pofile.save(sys.argv[1]) import subprocess subprocess.check_output( [ '/opt/slapos-shared/gettext/4df93a547efd86e0eb70495b88a5d3b1/bin/msgattrib', sys.argv[1], "--no-fuzzy", "--translated", "-s", "--no-wrap", "-o", sys.argv[1] ] ) -
Jérome Perrin authored
using: msgattrib translation.po --no-fuzzy --translated -s --no-wrap -o translation.po
-
Jérome Perrin authored
translated_title is used in listbox search columns, so it's very confusing for users if they can not use the usual % character for partial matches. This changes the behaviour of translated_title to autodetect the presence of % and use LIKE comparison operator in such case.
-
- 24 May, 2021 3 commits
-
-
Jérome Perrin authored
these ERP5 Python Scripts were not covered by coding style tests
-
Jérome Perrin authored
This ERP5 Python script was not checked until now, and add wrong indentation
-
Jérome Perrin authored
The ID is calculated from reference, showing reference is enough. There is no "callable_type" property on workflow script
-