Commit 6026d1b5 authored by Jérome Perrin's avatar Jérome Perrin

SQLExpression: only warn for string from_expression

EntireQuery pass a PlaceHolderTableDefinition for almost all catalog
searches, so "from_expression" itself can not be deprecated at this
point
parent efa37474
......@@ -133,7 +133,7 @@ class SQLExpression(object):
raise ValueError('Unrecognized "limit" value: %r' % (limit, ))
else:
self.limit = (limit, )
if from_expression is not None:
if isinstance(from_expression, basestring):
warnings.warn("Providing a 'from_expression' is deprecated.",
DeprecationWarning)
self.from_expression = from_expression
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment