- 30 Oct, 2019 2 commits
-
-
Ivan Tyagov authored
-
Sebastien Robin authored
-
- 29 Oct, 2019 3 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
Until now it was disabled which means that if Component A imports Component B and the latter is not in {validated,modified} state, Component A could be validated without raising any error and failed at execution time. As this relies on Pylint transform/hook and avoiding monkey patch as much as possible, make Products.ERP5Type.patches.pylint available for Python3 (not actually tested with ERP5 but no AttributeError nor ImportError with Python3 with this code). Also, allow developer to call validate action from 'modified' state to handle import use case: 1. Edit A which raises an error stating that B. 2. Fix B and validate it. 3. Validate again A without requiring a modification of {reference,version,text_content}.
-
Arnaud Fontaine authored
ZODB Components: Source code was checked even when setting text_content_{error,warning}_message_list properties. So only check source code and validate when _set{TextContent,Reference,Version} are called and remove wildcards.
-
- 25 Oct, 2019 3 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
Because this is using SQLDict, when we had multiple conversion activities for the same path with different conversion parameters, only one was executed. We don't want this here, as the recent failures on testDmsWithPreConversion.TestDocumentWithPreConversion are showing, when the same image is referenced with different conversion parameters we want to pre-convert for all conversion parameters. Use SQLQueue, which allows calling the same method more than once. /reviewed-on nexedi/erp5!971
-
Jérome Perrin authored
Sometimes validator.erp5.net replies with error code 502 and this cause ERP5 tests to fail. While this is a bit like ignoring problems, problems with validator.erp5.net should not impact ERP5 tests results. /reviewed-on nexedi/erp5!968
-
- 24 Oct, 2019 6 commits
-
-
Sven Franck authored
-
Bryton Lacquement authored
This is a fixup for commit 1519d81a. There was a typo.
-
Ivan Tyagov authored
-
Jérome Perrin authored
This test was using a blind `pause` instead of an explicit waitFor*, so it was failing when machine was not fast enough. Also refactor the test a bit to simplify the assertion by first selecting the iframe we are going to inspect and make the test compatible with both chrome and firefox - they behave differently when interpreting new lines in selenium test tables. /reviewed-on !967
-
Jérome Perrin authored
We want to have FAILED test results before PASSED, to easily see the failed tests. Apparently this was a local change on nexedi ERP5 for some time but the change got lost in last update. Let's commit it to make this permanent. /reviewed-on nexedi/erp5!960
-
Jérome Perrin authored
test_04c_startTestSuiteOrderWithManyTestNodes is using same test results names ("test suite 1", "test suite 2", ...) as some previous tests ( test_04b_startTestSuiteOrder ) so it's safer to start the test by cancelling all previous test runs and renaming them. /reviewed-on !959
-
- 23 Oct, 2019 7 commits
-
-
Bryton Lacquement authored
-
Bryton Lacquement authored
-
Romain Courteaud authored
-
Sven Franck authored
-
Ivan Tyagov authored
-
Arnaud Fontaine authored
erp5_trade_ja: New bt5 for wkhtmltopdf printout for 'Sale Invoice' with >2019/10/01 new Japanese VAT ratio support. Based on the following ODT Templates (erp5_invoicing): * Invoice_viewAsODT.oot. * Invoice_viewAsODTStyles_l10n_ja.oot. wkhtmltopdf template is based on work from slapos_accounting bt5: * SaleInvoiceTransaction_viewSlapOSPrintout.zpt. * SaleInvoiceTransaction_getSlapOSPrintout.css.zpt.
-
Arnaud Fontaine authored
Conversion Server code is no longer bound to OOo, as emphasized by: * Renaming of Preference Properties ooodoc_server* to document_conversion_server*. * Conversion Server exceptions are already defined in Document.py. * Conversion Server also handles video/audio/... conversions. Thus, refactor the code to connect to Conversion Server by moving it from Products.ERP5OOo.Document to Products.ERP5.Document.Document (while keeping backward compatibility): * Renamed: + OOoServerProxy => DocumentConversionServerProxy + OOO_SERVER_PROXY_TIMEOUT => DOCUMENT_CONVERSION_SERVER_PROXY_TIMEOUT + OOO_SERVER_RETRY => DOCUMENT_CONVERSION_SERVER_RETRY * Moved: + enc + dec + global_server_proxy_uri_failure_time Also, Introduced erp5.module.TransformLib (in erp5_core as currently all Transforms are there even though it should probably not be so) to define DocumentConversionServerTransform and which will hold libtransforms content when this will be moved to ZODB Components. Note: Ideally, OOOdCommandTransform should inherit from DocumentConversionServerTransform but wkhtmltopdf Handler on Cloudooo side is a hack only implemented in Manager.convertFile() whereas OOOdCommandTransform still uses legacy Manager.run_generate(), so leave it as it is to avoid breaking things (this will be addressed in a separate MR). /reviewed-on !955
-
- 18 Oct, 2019 1 commit
-
-
Roque authored
/reviewed-on nexedi/erp5!965
-
- 17 Oct, 2019 2 commits
-
-
Arnaud Fontaine authored
ZODB Components: Add 'Origin' (source_reference) field showing from which FS module it was imported.
-
Arnaud Fontaine authored
* pylint may return a false positive error which have to be disabled and failing to import it because of that requires to edit on the FS and try again so it is not practical for a whole Product. Instead it is easier to import it and not validate * Validation was done only for 'Test Component' and 'Extension Component', but all imported Components had their consistency and source code checked and this is not consistent to not validate but do these checks. * importFromFilesystem() was checking consistency and source code, and this was done again when validating. So leave the imported ZODB Components as draft and let the developer fixes issues upon validation before committing.
-
- 16 Oct, 2019 1 commit
-
-
Arnaud Fontaine authored
ZODB Components: List of migratable 'Module Components' in Products.XXX.* should include any kind of objects and not only modules. This fixes Products.ERP5VCS.Git module not being displayed because Products.ERP5VCS.__init__ only imports one of its class and not the whole module (and the module was not imported anywhere else too) so it was not in Products.ERP5VCS.__dict__.
-
- 15 Oct, 2019 2 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
useStdin=False => temporary file was not created. useStdin=True => temporary file was created.
-
- 14 Oct, 2019 1 commit
-
-
Ivan Tyagov authored
When multiple repositories exists and two of them contain scalability_test package be wiser and really check if neeeded Test Suite class exists before trying to load it.
-
- 11 Oct, 2019 2 commits
-
-
Roque authored
-
Yusei Tahara authored
-
- 10 Oct, 2019 7 commits
-
-
Klaus Wölfel authored
-
Jérome Perrin authored
-
Jérome Perrin authored
When running tests the path to git command is just git, because we have set $PATH
-
Jérome Perrin authored
updateConfiguration is a method to set the list of partitions, not to add partitions to an existing computer. The previous (slapos.core <1.5.0) implementation of slap proxy was incorrect and was adding more partitions each time it was called, but that was never the indented behavior. Prepare the list of partitions and call updateConfiguration only once to set all partitions. This should fix SLAPOS-SR-TEST that are still using erp5.util
-
Jérome Perrin authored
Some tests where patching SlapOSControler to replace methods by a no-op, but this was never reset. I believe we should rewrite this using mock which takes care of un-doing the patches for us and makes this testing easier, but for now I'm just reseting the missing methods like all others were already reseted.
-
Jérome Perrin authored
configparser read options as strings, node_quantity is not supposed to be an int.
-
Jérome Perrin authored
pkg_resources.resource_string reads the file as binary, if we want to substitute in this string we need to decode it.
-
- 09 Oct, 2019 3 commits
-
-
Arnaud Fontaine authored
ZODB Components: Monkey patch pylint to avoid 'No config file found, using default configuration' on stderr. Another solution could have been to have a configuration file for pylint instead of command line arguments but it depends on the type of Component (for example 'Interface Component' has specific arguments).
-
Ivan Tyagov authored
Value of text_content is an unicode string whose (inside XML) encoding is utf-8. This inconsistency raises in xml library thus it is safer to convert back to utf-8 which is the intended encoding anyway.
-
Arnaud Fontaine authored
After upgrading bt5s, portal_sms may still ERP5BaseBroken until restarting Zope.
-