Commits · 186ec9aeaa3fd2758ebdf15374e41e88c64d2b05 · Vincent Pelletier / neoppod

29 Jul, 2009 9 commits

Add a load() on PartitionTable() to remove some logic from handlers, add · 186ec9ae

Grégory Wisniewski authored Jul 29, 2009

docstring and comments.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1070 71dcc9de-d417-0410-9af5-da40c76e7ee4

186ec9ae

Add a TODO entry. · 15d368f0

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1069 71dcc9de-d417-0410-9af5-da40c76e7ee4

15d368f0

Factorize partition table loading with update(). · 86337ecc

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1068 71dcc9de-d417-0410-9af5-da40c76e7ee4

86337ecc

Use UUID instead of Node class instance as dictionnary keys. · 0bcad6d5

Vincent Pelletier authored Jul 29, 2009

Make display order of nodes more natural (saves from iterating in node list a second time and factorises code a bit).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1067 71dcc9de-d417-0410-9af5-da40c76e7ee4

0bcad6d5

Unknown storage nodes have to be in temporarily down state. · 4244140f
Grégory Wisniewski authored Jul 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1066 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4244140f
Add the ptid parameter to update() method of PartitionTable class for · 16e0aefd
Grégory Wisniewski authored Jul 29, 2009
```
consistency.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1065 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
16e0aefd

Fix command line representation. · 74ace0c4

Vincent Pelletier authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1064 71dcc9de-d417-0410-9af5-da40c76e7ee4

74ace0c4

Update tests to follow changes introduced wiith commit #1032 and avoid crash · 371ae1f5
Grégory Wisniewski authored Jul 29, 2009
```
many tests.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1063 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
371ae1f5
Fix bug introduced with #1058, duplicate OIDs were generated. · e3392cd7
Grégory Wisniewski authored Jul 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1062 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e3392cd7

28 Jul, 2009 31 commits

Remove this XXX, clarify node states is in TODO list. · 104b3ac3
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1061 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
104b3ac3
Move getPartition() in master's pt module for consistency. · 9adb3fe7
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1060 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9adb3fe7

Remove two XXX and add an entry in the TODO list. · 18341e55

Grégory Wisniewski authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1059 71dcc9de-d417-0410-9af5-da40c76e7ee4

18341e55

Merge getNextOID() and getNewOIDList() to remove an XXX. · 2d5cb3d7
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1058 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2d5cb3d7

This bug could not be reproduced. Removing. · 41937c5e

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1057 71dcc9de-d417-0410-9af5-da40c76e7ee4

41937c5e

Work done, remove from TODO file. · d96379b4

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1056 71dcc9de-d417-0410-9af5-da40c76e7ee4

d96379b4

Enum class now inherit from dict for integer/Item mapping. · e0019f27

Grégory Wisniewski authored Jul 28, 2009

Remove VALID_* definitions because checks are done in the protocol module when
getting the Item from the integer value.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1055 71dcc9de-d417-0410-9af5-da40c76e7ee4

e0019f27

Fix a forgotten call to Connection.notify providing it a msg_id. Use Connection.answer. · 08849b8b
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1054 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
08849b8b
Fix a forgotten call to Connection.notify providing it a msg_id. Use Connection.answer. · caa3ffe8
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1053 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
caa3ffe8

Remove those assertions since the debugging stage about node/cell state · dde50609

Grégory Wisniewski authored Jul 28, 2009

inconsistency is finished.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1052 71dcc9de-d417-0410-9af5-da40c76e7ee4

dde50609

Fix admin node knowing a disconnected primary master as being in RUNNING_STATE... · ad90889d

Vincent Pelletier authored Jul 28, 2009

Fix admin node knowing a disconnected primary master as being in RUNNING_STATE (it won't notify its own disconnection !).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1051 71dcc9de-d417-0410-9af5-da40c76e7ee4

ad90889d

Remove some TODO and XXX implemented or put in the TODO list. · ea58c9cb
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1050 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ea58c9cb

Remove an XXX comment: it is safe to ignore out of order partition table... · 455cfea7

Vincent Pelletier authored Jul 28, 2009

Remove an XXX comment: it is safe to ignore out of order partition table updates, this is what ptid is for.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1049 71dcc9de-d417-0410-9af5-da40c76e7ee4

455cfea7

Remove an unused "node" local variable (found by pylint). · cfcc8dc3

Vincent Pelletier authored Jul 28, 2009

Avoid using a local variable to display just one in a log.
Fix some inconsistently-named variables.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1048 71dcc9de-d417-0410-9af5-da40c76e7ee4

cfcc8dc3

Except during import, no OID overlapping should happen. Remove TODO entries · 3db3bf56

Grégory Wisniewski authored Jul 28, 2009

about this issue and add another about data import improvements.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1047 71dcc9de-d417-0410-9af5-da40c76e7ee4

3db3bf56

Fix Connection.notify prototype. It has no meaning to make it accept a msg_id... · 773cd549

Vincent Pelletier authored Jul 28, 2009

Fix Connection.notify prototype. It has no meaning to make it accept a msg_id parameter (it was used as a dirty work around to Connection.answer which didn't accept a msg id as parameter).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1046 71dcc9de-d417-0410-9af5-da40c76e7ee4

773cd549

Change Connection.answer prototype: it now takes a msg_id as parameter, not a... · c109d56c

Vincent Pelletier authored Jul 28, 2009

Change Connection.answer prototype: it now takes a msg_id as parameter, not a message any longer. This make this method easier to call from places where the entire message might not be available.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1045 71dcc9de-d417-0410-9af5-da40c76e7ee4

c109d56c

Remove a bug entry in the TODO list, it's fixed with commit #1026. · f04b641b
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1044 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f04b641b
Remove some TODO entries, done in previous commits. · f1aacd24
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1043 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f1aacd24

Don't crash the application when a protocol error packet is received. Since the · 23cd2585

Grégory Wisniewski authored Jul 28, 2009

connection should have been closed, the node should reconnect or trigger any
event as if it was disconnected.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1042 71dcc9de-d417-0410-9af5-da40c76e7ee4

23cd2585

Remove methods that ignore packets to enforce the protocol. · bb8106c2
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1041 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bb8106c2

Remove dead code (_connectionLost raises). · 39357b95

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1040 71dcc9de-d417-0410-9af5-da40c76e7ee4

39357b95

Remove useless method overloading. · 037af03a

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1039 71dcc9de-d417-0410-9af5-da40c76e7ee4

037af03a

Make admin node send a "not ready" error when requested to do something which... · a971382c

Vincent Pelletier authored Jul 28, 2009

Make admin node send a "not ready" error when requested to do something which requires acces to primary master node and the connection is not established.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1038 71dcc9de-d417-0410-9af5-da40c76e7ee4

a971382c

Make neoctl expect & handle properly a "not ready" error code from admin node. · 31c25e4c
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1037 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
31c25e4c
Replace assert with intended ones, do not just disable them. · d1530fcd
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1036 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d1530fcd

An empty partition table is a valid partition table (happens when a master... · 7e103f2a

Vincent Pelletier authored Jul 28, 2009

An empty partition table is a valid partition table (happens when a master didn't get any from a storage). A missing partition table must be detected with a None value.
Don't trash data we received from previous primary master when getting disconnected. It is still valuable, and interesting to fetch from neoctl.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1035 71dcc9de-d417-0410-9af5-da40c76e7ee4

7e103f2a

Remove a line commited by error, used for test purpose. · d1ffa1dc
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1034 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d1ffa1dc
Update neoctl application according to previous commit. · b12e02da
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1033 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b12e02da
Use a named logger and define it in the root module. · db6fcb9b
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1032 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
db6fcb9b

Factorise MasterEventHandler instanciation. · 1b82f1e4

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1031 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b82f1e4