Commits · 46eeac6fa7cf33e25d9005994fd158bb79bc72bc · Vincent Pelletier / neoppod

04 Feb, 2010 6 commits

A transaction must have been started when lock/unlock is received. · 46eeac6f
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1633 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
46eeac6f

Bug fix: Don't drop transaction information when locked. · 66ef9bed

Grégory Wisniewski authored Feb 04, 2010

If a client node disconnect from storage node right after send 'finishTransaction' to the primary master, then the storage clear it's related information and can not store them later in the database, when notifyUnlockInformation is received from the master.
Here the transaction object got a new attribute '_locked' set when the storage receive the 'lockInformation' from the master, meaning that the client is finish it's transaction.
If locked, the transaction is not cleared when the client disconnect from storage node.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1632 71dcc9de-d417-0410-9af5-da40c76e7ee4

66ef9bed

Try executed pending events only if something has changed. · feea26c9
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1631 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
feea26c9
There is at most one iteration that match, break when found. · 5d9248b6
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1630 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5d9248b6
Add a bug entry related to transaction manager from storage side. · defcca90
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1629 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
defcca90
Remove unexplained try/except/pass statements. · d3869809
Grégory Wisniewski authored Feb 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1628 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d3869809

03 Feb, 2010 28 commits

Rewrite of client's master handler tests. · 43b1e494
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1627 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
43b1e494
Rewrite of client's master handler tests. · 7b86a853
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1626 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
7b86a853
Split client's handlers test module in two. · 57f41fbd
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1625 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
57f41fbd
Check 'tid' parameter, must match with current transaction. · 320e4f54
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1624 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
320e4f54
Raise if a TransactionFinished packet contains a wrong TID. · 00f89a53
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1623 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
00f89a53
Few accesses to 'app', don't get intermediate variable. · c7deb039
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1622 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c7deb039
Client handlers take dispatcher reference from app. · 31087cad
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1621 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
31087cad

Fix handling of notifyNodeInformation in client side. · c2088712

Grégory Wisniewski authored Feb 03, 2010

Cut the connection to non-running nodes and remove it from pool in case of storage nodes.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1620 71dcc9de-d417-0410-9af5-da40c76e7ee4

c2088712

Add a comment to explain a try/except/pass · 6755bd49
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1619 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6755bd49

Fix the meaning of a comment. · 8f3889eb

Grégory Wisniewski authored Feb 03, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1618 71dcc9de-d417-0410-9af5-da40c76e7ee4

8f3889eb

Only a primary master is binded to this handler. · 68972dad
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1617 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
68972dad
Unknown master nodes must not be accepted. · 946faf6f
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1616 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
946faf6f
A master node must always supply an UUID to the accepted client. · 568e83bc
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1615 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
568e83bc
Retreive the node after check basics requirements. · 00ab5bff
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1614 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
00ab5bff
Log notifyNodeInformation packet content. · 5e799d01
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1613 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5e799d01
expectAssignedCells now takes the process as parameter instead of UUID. · deeb6b2c
Grégory Wisniewski authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1612 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
deeb6b2c
Simplify a "if: pass else: ..." block. · 49b6acad
Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1611 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
49b6acad
Add XXX near lock release which doesn't check who owns the lock. · 47c4926f
Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1610 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
47c4926f
Add TODOs near possibly abusive "try:..except..: pass" blocks. · 1b412591
Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1609 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1b412591

Simplify loop exit logic. · af907e65

Vincent Pelletier authored Feb 03, 2010

Also, don't add 10 to "t" on each iteration.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1608 71dcc9de-d417-0410-9af5-da40c76e7ee4

af907e65

Get rid of a try:..except: pass. · 6961628f

Vincent Pelletier authored Feb 03, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1607 71dcc9de-d417-0410-9af5-da40c76e7ee4

6961628f

Get rid of empty BaseStorageHandler class. · 87ea655c
Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1606 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
87ea655c
Add an XXX about master shutdown code for later review. · 3353d4db
Vincent Pelletier authored Feb 03, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1605 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3353d4db

Make ClientServiceHandler inherit from MasterHandler directly. · f80215e1

Vincent Pelletier authored Feb 03, 2010

BaseServiceHandler only logic doesn't apply to a client connection, so
there is no benefit in inheriting from it.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1604 71dcc9de-d417-0410-9af5-da40c76e7ee4

f80215e1

Enable autocommit on SQL connections established in tests. · e37f79c2

Vincent Pelletier authored Feb 03, 2010

This makes sure changes made while expecting condition to happen are
visible to that connection.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1603 71dcc9de-d417-0410-9af5-da40c76e7ee4

e37f79c2

Close storage connection right after sending it a shutdown request. · 8ba76a4f

Vincent Pelletier authored Feb 03, 2010

Otherwise, storage shutdown would be handled as an unexpected
disconnection, and would cause the node to reappear as temporarily down.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1602 71dcc9de-d417-0410-9af5-da40c76e7ee4

8ba76a4f

Make testDropNodeThenRestartCluster wait for partition table changes to · ee265260

Vincent Pelletier authored Feb 03, 2010

become persistent.

If the storage is stopped before handling partition changed notification,
it will come back with dropped storage node as up-to-date, which is
outside the scope of this test.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1601 71dcc9de-d417-0410-9af5-da40c76e7ee4

ee265260

Add a method to get all connections with a given UUID. · 7ebe221d

Vincent Pelletier authored Feb 03, 2010

This makes clear that it is possible to have more than one connection
to/from a given node. Most obvious case is election, where all masters
try to connect with each other.

Deprecate getConnectionByUUID.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1600 71dcc9de-d417-0410-9af5-da40c76e7ee4

7ebe221d

02 Feb, 2010 6 commits

Fix functional tests around 'expectOutdatedCells' · 7096624a

Grégory Wisniewski authored Feb 02, 2010

Ensure all storage nodes started are well known by the master before check that there is no more outdated cells to avoid random false success with no outdated cells but with a missing storage node.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1599 71dcc9de-d417-0410-9af5-da40c76e7ee4

7096624a

Move client's connection pool out of client's app. · 39843379
Grégory Wisniewski authored Feb 02, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1598 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
39843379
Move ConnectionClosed exception to the dedicated python module. · acf308ba
Grégory Wisniewski authored Feb 02, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1597 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
acf308ba

Add some minors TODOs. · 4adcc6aa

Grégory Wisniewski authored Feb 02, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1596 71dcc9de-d417-0410-9af5-da40c76e7ee4

4adcc6aa

Change log level to warning for an ignored packet. · cf098000
Grégory Wisniewski authored Feb 02, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1595 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cf098000

Fix indentation. · 4aa872d2

Grégory Wisniewski authored Feb 02, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1594 71dcc9de-d417-0410-9af5-da40c76e7ee4

4aa872d2